From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19495 invoked by alias); 8 Feb 2002 05:22:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19348 invoked from network); 8 Feb 2002 05:22:32 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 8 Feb 2002 05:22:32 -0000 Received: from localhost.redhat.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id VAA03913; Thu, 7 Feb 2002 21:22:29 -0800 (PST) Received: by localhost.redhat.com (Postfix, from userid 469) id 142FA112E4; Fri, 8 Feb 2002 00:22:22 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15459.24717.916794.336839@localhost.redhat.com> Date: Thu, 07 Feb 2002 21:22:00 -0000 To: Andrew Cagney Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [PATCH] New gdb port: Hitachi SH5 (sh64-elf) In-Reply-To: <3C635B36.5080104@cygnus.com> References: <15459.21685.558343.429478@localhost.redhat.com> <3C635B36.5080104@cygnus.com> X-Mailer: VM 7.00 under Emacs 20.7.1 X-SW-Source: 2002-02/txt/msg00221.txt.bz2 Andrew Cagney writes: > > +#ifdef GDB_TARGET_IS_SH64 > > + case bfd_mach_sh5: > > BTW, is this needed? I noticed that the sh64 opcodes (and sim?), when it was submitted, looked messed up as it didn't include all the assemblers. I suggested that be fixed. > > Not all of those, no (I just went overboard). It is needed around the invocation of the disassembly function, because that one is only defined when the target is sh64-elf. If we had opcodes compile also the sh64 files whe the target is sh-elf, the problem would go away. It would be really good to unify sim+binutils. Adding a variant like this, seems a bit of an anachronism. libgdb.a(sh-tdep.o): In function `gdb_print_insn_sh64': /es/scratch/ezannoni/sources/gdb/sh-tdep.c:958: undefined reference to `print_insn_sh64x_media' collect2: ld returned 1 exit status Elena > Andrew > >