From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47997 invoked by alias); 26 Dec 2018 14:11:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47976 invoked by uid 89); 26 Dec 2018 14:11:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=careful, menu, effectively, searching X-HELO: mailsec117.isp.belgacom.be Received: from mailsec117.isp.belgacom.be (HELO mailsec117.isp.belgacom.be) (195.238.20.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Dec 2018 14:11:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1545833506; x=1577369506; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=t9g4EnMhbUwfq2p3ptT8EcQndosG1jR5t1Ybsz5tQ4U=; b=rqkj/E2Ek6wf20AmQWQdMr/58TgNRXwdCKmFXhwkknZz2ie3NBNZdF/j kN4WSiPV8EA6ljs4uhmZhamcBO1Wlg==; Received: from 184.205-67-87.adsl-dyn.isp.belgacom.be (HELO md) ([87.67.205.184]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 26 Dec 2018 15:11:43 +0100 Message-ID: <1545833503.31031.10.camel@skynet.be> Subject: Re: [RFA] Fix some gdb.ada tests failures due to naming conflict. From: Philippe Waroquiers To: Joel Brobecker Cc: gdb-patches@sourceware.org Date: Wed, 26 Dec 2018 14:11:00 -0000 In-Reply-To: <20181226045630.GB21851@adacore.com> References: <20181224141509.11807-1-philippe.waroquiers@skynet.be> <20181226045630.GB21851@adacore.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00327.txt.bz2 Hello Joel, Thanks for the review comments. I just submitted an RFAv2 that should handle all below comments. On Wed, 2018-12-26 at 08:56 +0400, Joel Brobecker wrote: > > Fix these by using names that have more chances to be unique. > > Thanks for doing that, Philippe. I believe this is because you are > using a version of the compiler where the entire runtime has debugging > information, which is not AdaCore's normal mode. > > Would you mind terribly splitting this commit into a series of coomits, > with one commit per tescase? If you are unsure how to do that with git, > take a look at git reset (and prob. google as well ;-)). RFAv2 has now one commit per testcase. > > > > > packed_array_assign.exp > > So, update to test the new (more unique) names in the source order. > > We have to te be careful about the component order. AdaCore implemented > a change last year where components can be automatically re-ordered > if it makes the code more efficient. One way we can handle this is by > accepting both orders. However, looking at the record, and the purpuse > of the testcase, I think we achieve the same goals by just reordering > the fields in Packed_Rec. That way, the component order chosen by > the compiler remains the same regardless of the compiler. Effectively, gcc 6.3.0 and a recent gnat pro behaved differently. I have updated the test so that both compilers are giving the same component order. > > > rename_subscript_param.exp > > Fix by renaming 'b' to 'rename_subscript_param_b. ... > This renaming is unnecessary. What is probably happening as you guessed > is that the compiler failed to generate the renaming. As a result, > GDB failed to find "B" in the current scope. That's when it started > searching in the static then global scope. The wider search does not > happen if some symbols were found in the current scope, so the > ambiguity you are seeing is only because of the inability to find "B". > > You can still rename "B" if you would like, but the only advantage > I can see for doing that is that you get the second error message > (no definition of...) instead of the multiple choice menu in > situations like yours where the compiler failed to generate > the necessary debug info. I have kept the renaming, as this ensures the test fails directly rather than with a timeout. > > > 2018-12-24 Philippe Waroquiers > > > > * gdb.ada/assign_arr/target_wrapper.ads (Input): Rename to > > Assign_Arr_Input. > > main_p324_051.adb: Update accordingly. > > It is already written up, and it is fine as is, so no need to > waste more time on more Changelog writing; but for the future, > you can saveyourself a bit of time by saying... > > * gdb.ada/assign_arr/target_wrapper.ads (Input): Rename to > Assign_Arr_Input. All users updated. > > ... and that's it! Any hint making writing ChangeLog less frustrating is good to know :). Thanks Philippe