Re: [RFA] Ensure deterministic result order in gdb.ada/info_auto_lang.exp

Joel Brobecker
2018-12-20T07:57:39Z

> Simon/Joel, thanks for the help, I see everyday that I am far to
> master the gdb subtleties :).

Please point me in the direction of someone who knows them all.. ;-)

> On Thu, 2018-12-20 at 00:50 -0500, Simon Marchi wrote:
> > On 2018-12-20 00:29, Joel Brobecker wrote:
> ...
> > > However, if you configure using a relative path to the configure
> > > script,
> > > things become different.
> Effectively, I am building and testing out-of-tree, but with a relative
> configure => I will change to use an absolute configure path.

I don't think you have to, and from my perspective, I don't see
why it should be a requirement.

> > Then, I think it makes sense to normalize the paths in order to have a
> > predictable output, regardless of how gdb was configured, as Philippe
> > suggested. Are you also ok with his patch?
>
> And if ok, do we better do standard_csrcfile_for_ada used for all such
> c files used by gdb.ada, or do we limit the normalization to this test
> ?

I don't have a strong opinion. I don't see a compelling reason to
do the normalization systematically at the moment, as perhaps
it gives us more diverse testing coverage. The cost is indeed
those occasional testcases that fail for some but not others.
I don't know if we expect this to happen so often that we need
to make it systematic.

I would personally start with your patch, and adjust later, if it turns
out we have enough testcases facing that issue.

And for the avoidance of doubt, and not hold the patch waiting for me,
your patch looks good to me.

--
Joel