From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6877 invoked by alias); 1 Feb 2002 02:45:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6797 invoked from network); 1 Feb 2002 02:45:14 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 1 Feb 2002 02:45:14 -0000 Received: from localhost.cygnus.com ([10.255.17.130]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with SMTP id SAA23398; Thu, 31 Jan 2002 18:45:12 -0800 (PST) Received: (from ezannoni@localhost) by localhost.cygnus.com (8.11.2/8.11.2) id g111mVh02847; Thu, 31 Jan 2002 20:48:31 -0500 From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15449.62447.668648.375754@localhost.cygnus.com> Date: Thu, 31 Jan 2002 18:45:00 -0000 To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Replace some literal consts with enums. In-Reply-To: <200202010108.g1118GN31973@reddwarf.cygnus.com> References: <200202010108.g1118GN31973@reddwarf.cygnus.com> X-Mailer: VM 7.00 under Emacs 20.7.1 X-SW-Source: 2002-01/txt/msg00828.txt.bz2 Cool, I like enums. But the formatting of the enum in the .h file is non-GNU. Is symfile.c the only place where these are used? Would it be possible to pull the enum inside symfile.c, if this is the case? Thanks Elena Michael Snyder writes: > > 2002-01-31 Michael Snyder > > * symfile.h (enum overlay_debugging_state): > Define enum constant values for overlay mode. > * symfile.c (overlay_debugging): Use enums instead of literals. > (overlay_is_mapped, overlay_auto_command, > overlay_manual_command): Ditto. > > Index: symfile.h > =================================================================== > RCS file: /cvs/src/src/gdb/symfile.h,v > retrieving revision 1.11 > diff -p -r1.11 symfile.h > *** symfile.h 2001/12/07 12:10:15 1.11 > --- symfile.h 2002/02/01 01:10:58 > *************** extern void find_lowest_section (bfd *, > *** 253,259 **** > extern bfd *symfile_bfd_open (char *); > > /* Utility functions for overlay sections: */ > ! extern int overlay_debugging; > extern int overlay_cache_invalid; > > /* return the "mapped" overlay section containing the PC */ > --- 253,263 ---- > extern bfd *symfile_bfd_open (char *); > > /* Utility functions for overlay sections: */ > ! extern enum overlay_debugging_state { > ! ovly_off, > ! ovly_on, > ! ovly_auto > ! } overlay_debugging; > extern int overlay_cache_invalid; > > /* return the "mapped" overlay section containing the PC */