From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32466 invoked by alias); 2 Dec 2018 16:57:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32456 invoked by uid 89); 2 Dec 2018 16:57:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:562, leaks X-HELO: mailsec103.isp.belgacom.be Received: from mailsec103.isp.belgacom.be (HELO mailsec103.isp.belgacom.be) (195.238.20.99) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 02 Dec 2018 16:57:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1543769835; x=1575305835; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=CKZvdrm2dEu7QDEhdI6nH0IxBaFe+fVTmYURzitbl10=; b=g+zRK0OlM1QcnXQRGTfYcULYNB0Md71Z4XMwB1CUiQYhqqV048q7D9E2 0THR9RiLis98ntswF75tvkPbDd6tXA==; Received: from 184.205-67-87.adsl-dyn.isp.belgacom.be (HELO md) ([87.67.205.184]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 02 Dec 2018 17:57:12 +0100 Message-ID: <1543769832.10519.2.camel@skynet.be> Subject: Re: [PATCH] Merge forward-search/reverse-search, use gdb::def_vector, remove limit (Re: [RFA] Fix leak in forward-search) From: Philippe Waroquiers To: Pedro Alves , gdb-patches@sourceware.org Date: Sun, 02 Dec 2018 16:57:00 -0000 In-Reply-To: <6e8a2a00-bcbd-cdc6-f332-f59988bb8c40@redhat.com> References: <20181127233328.5164-1-philippe.waroquiers@skynet.be> <3cf960b8-ff82-0670-fa90-c94d78573bfe@redhat.com> <1543532723.4149.7.camel@skynet.be> <6e8a2a00-bcbd-cdc6-f332-f59988bb8c40@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00014.txt.bz2 On Fri, 2018-11-30 at 19:43 +0000, Pedro Alves wrote: > I looked a little and found that we do indeed have tests, however > they test using the "search" alias, instead of "forward-search", > which made them invisible to greps for the latter. > > I also noticed a couple other things... See the patch below. WDYT? Looks much better than the previous code, and as expected, no leaks there ... So, FWIW, patch looks good to me ... Philippe