From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125936 invoked by alias); 29 Nov 2018 23:14:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125917 invoked by uid 89); 29 Nov 2018 23:14:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=transfer X-HELO: mailsec104.isp.belgacom.be Received: from mailsec104.isp.belgacom.be (HELO mailsec104.isp.belgacom.be) (195.238.20.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 23:14:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1543533243; x=1575069243; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=9xoan1tD8fMn+a9WxetODhwidkwqovt45oyPxkf5SqM=; b=cdkOBBzRKXmO5ulUu4iAzNTAyaLVhl25Jx1J1GTuuS3Wt+BUc3cR+cpU bYIuH3fV2DQfoWcKziEF4zx5PrZH5Q==; Received: from 184.205-67-87.adsl-dyn.isp.belgacom.be (HELO md) ([87.67.205.184]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 30 Nov 2018 00:14:01 +0100 Message-ID: <1543533240.4149.9.camel@skynet.be> Subject: Re: [PUSHED/OBVIOUS] Re-fix leak in source.c (open_source_file). From: Philippe Waroquiers To: Tom Tromey Cc: gdb-patches@sourceware.org Date: Thu, 29 Nov 2018 23:14:00 -0000 In-Reply-To: <87ftvjbvmc.fsf@tromey.com> References: <20181124115237.8943-1-philippe.waroquiers@skynet.be> <87ftvjbvmc.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00558.txt.bz2 On Thu, 2018-11-29 at 11:12 -0700, Tom Tromey wrote: > > > > > > "Philippe" == Philippe Waroquiers writes: > > Philippe> Leak fixed in '8e6a5953e1d Fix 4K leak in open_source_file' has been partially > Philippe> undone by '2179fbc36d23 Return scoped_fd from open_source_file'. Re-add the > Philippe> transfer of current s->fullname to the unique_xmalloc_ptr fullname given to > Philippe> find_and_open_source. > > Sorry about that, and thank you for fixing it. No problem. Note that after having run all GDB tests under valgrind, I still see some 4K leaks in open_source_file appearing (I suspect) when GDB reloads an executable that has changed. Philippe