From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15332 invoked by alias); 14 Jan 2002 16:39:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15295 invoked from network); 14 Jan 2002 16:39:56 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 14 Jan 2002 16:39:56 -0000 Received: from localhost.cygnus.com (cse.sfbay.redhat.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA17066; Mon, 14 Jan 2002 08:39:14 -0800 (PST) Received: (from ezannoni@localhost) by localhost.cygnus.com (8.11.2/8.11.2) id g0EFq1s08282; Mon, 14 Jan 2002 10:52:01 -0500 From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15426.65184.586503.236676@localhost.cygnus.com> Date: Mon, 14 Jan 2002 08:39:00 -0000 To: "H . J . Lu" Cc: msnyder@redhat.com, gdb-patches@sources.redhat.com Subject: Re: Bad checkin breaks Linux In-Reply-To: <20020112163246.A1516@lucon.org> References: <20020112163246.A1516@lucon.org> X-Mailer: VM 7.00 under Emacs 20.7.1 X-SW-Source: 2002-01/txt/msg00391.txt.bz2 H . J . Lu writes: > This patch > > http://sources.redhat.com/ml/gdb-patches/2002-01/msg00195.html > > breaks Linux targets which don't use PTRACE_GETFPXREGS. The problem is > has > > /* Single step the process. > This is not supported on all machines. */ > PTRACE_SINGLESTEP = 9, > #define PT_STEP PTRACE_SINGLESTEP > > /* Get all general purpose registers used by a processes. > This is not supported on all machines. */ > PTRACE_GETREGS = 12, > #define PT_GETREGS PTRACE_GETREGS > > /* Set all general purpose registers used by a processes. > This is not supported on all machines. */ > PTRACE_SETREGS = 13, > #define PT_SETREGS PTRACE_SETREGS > > /* Get all floating point registers used by a processes. > This is not supported on all machines. */ > PTRACE_GETFPREGS = 14, > #define PT_GETFPREGS PTRACE_GETFPREGS > > /* Set all floating point registers used by a processes. > This is not supported on all machines. */ > PTRACE_SETFPREGS = 15, > #define PT_SETFPREGS PTRACE_SETFPREGS > > /* Get all extended floating point registers used by a processes. > This is not supported on all machines. */ > PTRACE_GETFPXREGS = 18, > #define PT_GETFPXREGS PTRACE_GETFPXREGS > > /* Set all extended floating point registers used by a processes. > This is not supported on all machines. */ > PTRACE_SETFPXREGS = 19, > #define PT_SETFPXREGS PTRACE_SETFPXREGS > > You can't assume you can use PTRACE_GETFPXREGS if it is defined. Due > to that change, gdb won't build on Linux/mips. I am afraid the current > gdb from CVS may be broken even without that patch: > > # gcc -c -g -O2 -I. -I/home/hjl/work/gnu/src/gdb/gdb/gdb -I/home/hjl/work/gnu/src/gdb/gdb/gdb/config -DHAVE_CONFIG_H -I/home/hjl/work/gnu/src/gdb/gdb/gdb/../include/opcode -I/home/hjl/work/gnu/src/gdb/gdb/gdb/../readline/.. -I../bfd -I/home/hjl/work/gnu/src/gdb/gdb/gdb/../bfd -I/home/hjl/work/gnu/src/gdb/gdb/gdb/../include -I../intl -I/home/hjl/work/gnu/src/gdb/gdb/gdb/../intl -DMI_OUT=1 -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized /home/hjl/work/gnu/src/gdb/gdb/gdb/thread-db.c > /home/hjl/work/gnu/src/gdb/gdb/gdb/thread-db.c: In function > `enable_thread_event_reporting': > /home/hjl/work/gnu/src/gdb/gdb/gdb/thread-db.c:398: warning: cast from pointer to integer of different size > /home/hjl/work/gnu/src/gdb/gdb/gdb/thread-db.c:411: warning: cast from pointer to integer of different size > /home/hjl/work/gnu/src/gdb/gdb/gdb/thread-db.c: In function `thread_db_store_registers': > /home/hjl/work/gnu/src/gdb/gdb/gdb/thread-db.c:843: warning: passing arg 2 of pointer to function from incompatible pointer type > FWIW, about the last warning, see the thread: http://sources.redhat.com/ml/gdb/2001-11/msg00203.html Elena > > H.J.