From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11767-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 12829 invoked by alias); 10 Jan 2002 00:04:23 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 12730 invoked from network); 10 Jan 2002 00:04:19 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 10 Jan 2002 00:04:19 -0000
Received: from localhost.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA05170;
	Wed, 9 Jan 2002 16:04:16 -0800 (PST)
Received: (from ezannoni@localhost)
	by localhost.cygnus.com (8.11.2/8.11.2) id g09NH4501965;
	Wed, 9 Jan 2002 18:17:04 -0500
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15420.53104.770587.362588@localhost.cygnus.com>
Date: Wed, 09 Jan 2002 16:04:00 -0000
To: Michael Snyder <msnyder@cygnus.com>
Cc: gdb-patches@sources.redhat.com, drow@mvista.com
Subject: Re: [PATCH] Export fill_fpxregset
In-Reply-To: <200201092228.g09MSGl03285@reddwarf.cygnus.com>
References: <200201092228.g09MSGl03285@reddwarf.cygnus.com>
X-Mailer: VM 7.00 under Emacs 20.7.1
X-SW-Source: 2002-01/txt/msg00212.txt.bz2


Sorry, but does this conflict with the extern in gregset.h?

extern void fill_fpxregset (gdb_fpxregset_t *fpxregs, int regno);

We have gdb_fpxregset_t vs. elf_fpxregset_t.

Should we just use one or the other?
I just remembered running into a similar problem some time back.

Thanks

Elena


Michael Snyder writes:
 > 2002-01-09  Michael Snyder  <msnyder@redhat.com>
 > 
 > 	* i386-linux-nat.c (fill_fpxregset): Make global.
 > 	(store_fpxregset): Ditto.
 > 
 > Index: i386-linux-nat.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/i386-linux-nat.c,v
 > retrieving revision 1.33
 > diff -c -3 -p -r1.33 i386-linux-nat.c
 > *** i386-linux-nat.c	2001/12/27 19:52:31	1.33
 > --- i386-linux-nat.c	2002/01/09 22:25:44
 > ***************
 > *** 1,5 ****
 >   /* Native-dependent code for Linux/x86.
 > !    Copyright 1999, 2000, 2001 Free Software Foundation, Inc.
 >   
 >      This file is part of GDB.
 >   
 > --- 1,5 ----
 >   /* Native-dependent code for Linux/x86.
 > !    Copyright 1999, 2000, 2001, 2002 Free Software Foundation, Inc.
 >   
 >      This file is part of GDB.
 >   
 > *************** static void store_fpregs (int tid, int r
 > *** 452,458 ****
 >   /* Fill GDB's register array with the floating-point and SSE register
 >      values in *FPXREGSETP.  */
 >   
 > ! static void
 >   supply_fpxregset (elf_fpxregset_t *fpxregsetp)
 >   {
 >     i387_supply_fxsave ((char *) fpxregsetp);
 > --- 452,458 ----
 >   /* Fill GDB's register array with the floating-point and SSE register
 >      values in *FPXREGSETP.  */
 >   
 > ! void
 >   supply_fpxregset (elf_fpxregset_t *fpxregsetp)
 >   {
 >     i387_supply_fxsave ((char *) fpxregsetp);
 > *************** supply_fpxregset (elf_fpxregset_t *fpxre
 > *** 462,468 ****
 >      *FPXREGSETP with the value in GDB's register array.  If REGNO is
 >      -1, do this for all registers.  */
 >   
 > ! static void
 >   fill_fpxregset (elf_fpxregset_t *fpxregsetp, int regno)
 >   {
 >     i387_fill_fxsave ((char *) fpxregsetp, regno);
 > --- 462,468 ----
 >      *FPXREGSETP with the value in GDB's register array.  If REGNO is
 >      -1, do this for all registers.  */
 >   
 > ! void
 >   fill_fpxregset (elf_fpxregset_t *fpxregsetp, int regno)
 >   {
 >     i387_fill_fxsave ((char *) fpxregsetp, regno);