From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22363 invoked by alias); 9 Jan 2002 18:45:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22335 invoked from network); 9 Jan 2002 18:45:41 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 9 Jan 2002 18:45:41 -0000 Received: from localhost.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id KAA03172; Wed, 9 Jan 2002 10:45:23 -0800 (PST) Received: (from ezannoni@localhost) by localhost.cygnus.com (8.11.2/8.11.2) id g09Hvqp01561; Wed, 9 Jan 2002 12:57:52 -0500 From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15420.33952.241143.297813@localhost.cygnus.com> Date: Wed, 09 Jan 2002 10:45:00 -0000 To: Andrew Cagney Cc: Eli Zaretskii , Richard.Earnshaw@arm.com, gdb-patches@sources.redhat.com Subject: Re: Patch for building gdb on arm-netbsd In-Reply-To: <3C3C7C07.2090203@cygnus.com> References: <3C3C7C07.2090203@cygnus.com> X-Mailer: VM 7.00 under Emacs 20.7.1 X-SW-Source: 2002-01/txt/msg00185.txt.bz2 Andrew Cagney writes: > > On Wed, 9 Jan 2002, Richard Earnshaw wrote: > > > > > >> The following patch is needed to enable building of gdb on arm-netbsd. > >> The definition of IN_SIGTRAMP tests NAME for being NULL and if not calls > >> STREQ to compare the strings. > > > > > > Nitpicking: Elena will probably be very happy if you toss STREQ and use > > strcmp instead. > > > I'm puzzled as to why it would be Elena? Oh, just because I expressed a few times a strong dislike for STREQ. :-) Elena > Anyway, Richard, when > generating new code just keep an eye on > http://sources.redhat.com/gdb/ari/ for things to not copy. > > BTW, people tend to just use NULL. > > either way, yes it is obvious, > Andrew