From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GNo/GQHSbF9RBAAAWB0awg (envelope-from ) for ; Thu, 24 Sep 2020 13:06:09 -0400 Received: by simark.ca (Postfix, from userid 112) id 6281A1EE05; Thu, 24 Sep 2020 13:06:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E5A181E599 for ; Thu, 24 Sep 2020 13:06:06 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 447413959E60; Thu, 24 Sep 2020 17:06:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 447413959E60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1600967166; bh=auP+TcqZWW8hC55FHKcVZiO/1RTreKXGubaBhwxzs50=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=gLmqQWKO+m5b/V4euvk7jkVfn7v63Gx0tkjwc1naZ4oYZRAstR8yQyX2gAZSyft3m IHadI5lKJ+QtJXJ41OmjHNQCRnI3QduMpjHY9gqneKCgWS1ELyb1CKMFxftGDrKeeZ dIkWfXtCW4RC4iIIq6xAdo4R+POXNzijwEQVO064= Received: from sonic309-25.consmr.mail.ir2.yahoo.com (sonic309-25.consmr.mail.ir2.yahoo.com [77.238.179.83]) by sourceware.org (Postfix) with ESMTPS id 5255B385DC17 for ; Thu, 24 Sep 2020 17:06:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5255B385DC17 X-YMail-OSG: abNO4RMVM1nMg4aEevPEzKN24.P9XgnxuzafJ8FWFIj.tiCu9ERWn0ONIcdcF3a HH0u.pQrdsLKCwH8CZDTENd5fdLtOqedzsNFefL6WD2SgRCUOV08WCaE4pXwuj2cqFT4B8Mo60_m SXg4v6HlyCP0escKtQAdaG8RS.VMX2pi4RHkfqpgNxELUvvqvnEtWRLxPam4nWTApqt6HBUE_XND 9rEGqj2bphOX4XJaq2OQtbuVQkd0Os06trhVpQe09mSI_fKQJlg7Vl4bF8tjjckIo9TbAGCKBmL0 f9TvkjHH1zWVhwlVJiLEp7n0VpvokMrYYK7FPigUR3Ke_oAClC1Ckh0PEbAzQijqWuuw5DmPtbr. 7sgx89PSNDI6.ljsc4CYS0V2IkrPNarghvvkvGa4NA3hfQuWPsdGc0V567.Az_9oChmqSJkyvuId rwdg2ynJoy1BXhn.oNjgkUYAmZBUgSGTkiPp0rnHUxQc4QerrRZSNiqUhYbaJKOEh3PJsg.v2nuP akePYYin3._DHcZoV5Z9rungIhRuJyTZOWEHNPEoblYxqDVm4N_cyWntMUYQkjUj8uZ3u6BsvLfb Domv4ALAwxBTlhDcoRlOQ.gO.m0zhtvA5hzgffsj6.q6jvI9FHRI8h1ymnw8ndzRI7aBturlqtzd 9ay_6XgITKqBJfTVru9GSu63lHTz9srBea59EQD49HWv9PU9WcbJc0EzteAwwi3Lt7k7NBjMIsAc dQKwj4EqkWMjs4Jjti6Lff2M_yfO.NH0pytlPOs_pLyMaUd5vNMsrV7wYy4WOYp.mtCr.SCYGTf_ ndqvl16in9KjSi6qGQIjKN3n6L9aG0VkRPA6tlD_TtOhlk8GdPOnvQBq9DANnqCNXlbNI6ZCSGRX _KbOBIyY2lIXoauqx8EfV6qE7ulQcj9Fl7iITgYFYKItPL9.ggtbAqUeanL8zRiwxbYXSvbPYUVC M2_FjdIL6i5tWfM9TA48uYJi.W5GUT9Z.HNVtj42vmHuRMfhbuw7w8KJxiAxvGgHfYwLgN0Ks8UN lxA_FLhhI3mYfjnRXn0NB2mIY4COB9vyGKFhgRLiC0sSnODvkvhr15aM6.Be56x9goPomxtzHn7O AVeEn8_K4ZED5G22YE.H93qlkC9X10Ol3jt8l0O5ubg9Q9kUoB4y01S.5ZLEQX5kO9Dul.gP2c5. HDvpXCAbVK0zZ2BT8AYrUxXoCbRwyNbE2gQqkykelbfkck1E9_iOmOHxU_zT2wxNLcd92GTPHsC5 RGicNtyHbaFSgt..RcI5_dLi1yWyAZ7eHmbB52FeSS5ObGSGG1ecXokwKZnJNmF0LqhhsbJOn414 Yq3lNbK9xiIhSr65aRQnNc2v_MPdF1_myS7jSYkDCWe9Libpiwqk_UmlqhvEBOY9YH4UbeToOUrq TemGJXK3Yi0phcAOa9I0c1u7PyVpZjCj4IbQGoNfKDQUBBl3H Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Thu, 24 Sep 2020 17:06:00 +0000 Date: Thu, 24 Sep 2020 17:05:56 +0000 (UTC) To: "gdb-patches@sourceware.org" , Simon Marchi , Joel Brobecker Message-ID: <153976107.672644.1600967156864@mail.yahoo.com> In-Reply-To: <8c6040f0-d21a-40b5-8587-be23a312689c@simark.ca> References: <20200923172122.2089-1-ssbssa.ref@yahoo.de> <20200923172122.2089-1-ssbssa@yahoo.de> <0ce3a433-4256-93e9-8843-57cd5f28ba73@simark.ca> <2023373258.594579.1600961165295@mail.yahoo.com> <538186656.652086.1600965451252@mail.yahoo.com> <8c6040f0-d21a-40b5-8587-be23a312689c@simark.ca> Subject: Re: [PATCH 1/3] Handle 64bit breakpoints of WOW64 processes as SIGINT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.16674 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Donnerstag, 24. September 2020, 18:42:33 MESZ hat Simon Marchi Folgendes geschrieben: > On 2020-09-24 12:37 p.m., Hannes Domani via Gdb-patches wrote: > >=C2=A0 Am Donnerstag, 24. September 2020, 17:29:50 MESZ hat Simon Marchi= Folgendes geschrieben: > > > >> On 2020-09-24 11:26 a.m., Hannes Domani wrote: > >>> Is it ok with this addition?: > >>> > >>> diff --git a/gdb/nat/windows-nat.c b/gdb/nat/windows-nat.c > >>> index a277156138..2cbbc0f2cc 100644 > >>> --- a/gdb/nat/windows-nat.c > >>> +++ b/gdb/nat/windows-nat.c > >>> @@ -243,6 +243,13 @@ handle_exception (struct target_waitstatus *ours= tatus, bool debug_exceptions) > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else if (wow64_process) > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* This breakpoint except= ion is triggered for WOW64 processes when > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 r= eaching an int3 instruction in 64bit code. > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 g= db checks for int3 in case of SIGTRAP, this fails because > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 W= ow64GetThreadContext can only report the pc of 32bit code, and > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 g= db lets the target process continue. > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 S= o handle it as SIGINT instead, then the target is stopped > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 u= nconditionally.=C2=A0 */ > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DEBUG_EXCEPTION= _SIMPLE ("EXCEPTION_BREAKPOINT"); > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rec->ExceptionC= ode =3D DBG_CONTROL_C; > >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ourstatus->valu= e.sig =3D GDB_SIGNAL_INT; > >> > >> That is fine with me, thanks. > >> > >> Just to make sure I understand, stopping a 32-bit process from a 64-bi= t > >> GDB is the only time we expect this to happen, right? > > Ok, thanks.=C2=A0 Please go ahead and merge. Pushed, thanks. I think it would be great to have this in the gdb-10-branch. Would that be possible? Hannes