From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112089 invoked by alias); 1 Oct 2018 22:05:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112076 invoked by uid 89); 1 Oct 2018 22:05:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:p.m, p.m, pm, exhaustive X-HELO: NAM04-CO1-obe.outbound.protection.outlook.com Received: from mail-eopbgr690112.outbound.protection.outlook.com (HELO NAM04-CO1-obe.outbound.protection.outlook.com) (40.107.69.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Oct 2018 22:05:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=impinj.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CGNufsDaTNhfijIIpoOUfy3hkLR+KEVQypZ85kYR5tU=; b=p32LBRN2uv7PN6iYK1AbLg3WektQGkjct54hlKpIH4jKuy4XgFjnR/xMR0V79hIzagkMg814H58TU+DMHjCXIq9tMLAJYCh7Hqi8kYfhdJK/IWJSvM29Xe+dIEusq5/ngMdD7PrmCLTQXPUd7gme3TsNRvRqUZpIIqc8uTszk10= Received: from MWHPR0601MB3708.namprd06.prod.outlook.com (10.167.236.38) by MWHPR0601MB3594.namprd06.prod.outlook.com (10.167.173.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.20; Mon, 1 Oct 2018 22:05:12 +0000 Received: from MWHPR0601MB3708.namprd06.prod.outlook.com ([fe80::f4ee:3633:74c0:ab4]) by MWHPR0601MB3708.namprd06.prod.outlook.com ([fe80::f4ee:3633:74c0:ab4%3]) with mapi id 15.20.1185.024; Mon, 1 Oct 2018 22:05:12 +0000 From: Trent Piepho To: "simark@simark.ca" , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Record ARM THUMB2 PLD/PLI cache instructions Date: Mon, 01 Oct 2018 22:05:00 -0000 Message-ID: <1538431511.6709.18.camel@impinj.com> References: <20180928230437.4329-1-tpiepho@impinj.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=tpiepho@impinj.com; received-spf: None (protection.outlook.com: impinj.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <1822C31AEAC66A4DAF7C504C16E66C64@namprd06.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2018-10/txt/msg00029.txt.bz2 T24gU3VuLCAyMDE4LTA5LTMwIGF0IDEwOjIxIC0wNDAwLCBTaW1vbiBNYXJj aGkgd3JvdGU6DQo+IE9uIDIwMTgtMDktMjggNzowNCBwLm0uLCBUcmVudCBQ aWVwaG8gd3JvdGU6DQo+ID4gVGhlc2Ugd2VyZW4ndCBkZWNvZGVkIGNvcnJl Y3RseSBhbmQgdHJpZ2dlciBhbiB1bmtub3duIGluc3RydWN0aW9uIGVycm9y DQo+ID4gd2hlbiByZWNvcmRpbmcuICBUaGUgQVJNIGZvcm1hdCB3YXMgaGFu ZGxlZCwgYnV0IG5vdCB0aGUgMzItYml0IFRIVU1CMg0KPiA+IGZvcm1hdC4N Cj4gPiANCj4gPiBTaW5jZSB0aGV5IGFyZSBvbmx5IGhpbnRzIHRoYXQgbWF5 IGFmZmVjdCBjYWNoZSBzdGF0ZSwgdGhlcmUgaXMgbm90aGluZw0KPiA+IHRv IHJlY29yZC4NCj4gPiANCj4gPiBnZGIvQ2hhbmdlTG9nDQo+ID4gMjAxOC0w OS0yOCAgVHJlbnQgUGllcGhvICA8dHBpZXBob0BpbXBpbmouY29tPg0KPiA+ IA0KPiA+ICAgICAgICAgUFIgZ2RiLzIzNzI1DQo+ID4gICAgICAgICAqIGdk Yi9hcm0tdGRlcC5jICh0aHVtYjJfcmVjb3JkX2xkX21lbV9oaW50cyk6IERl Y29kZSB0aHVtYjIgUExEL1BMSQ0KPiA+IC0tLQ0KPiA+ICBnZGIvYXJtLXRk ZXAuYyB8IDggKysrKysrKysNCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5z ZXJ0aW9ucygrKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9nZGIvYXJtLXRk ZXAuYyBiL2dkYi9hcm0tdGRlcC5jDQo+ID4gaW5kZXggYzMyODBlZTIxMS4u OTA5MzZhZGE4ZSAxMDA2NDQNCj4gPiAtLS0gYS9nZGIvYXJtLXRkZXAuYw0K PiA+ICsrKyBiL2dkYi9hcm0tdGRlcC5jDQo+ID4gQEAgLTEyNjgzLDYgKzEy NjgzLDE0IEBAIHRodW1iMl9yZWNvcmRfbGRfbWVtX2hpbnRzIChpbnNuX2Rl Y29kZV9yZWNvcmQgKnRodW1iMl9pbnNuX3IpDQo+ID4gICAgICAgICAgICAg ICAgICByZWNvcmRfYnVmKTsNCj4gPiAgICAgICAgcmV0dXJuIEFSTV9SRUNP UkRfU1VDQ0VTUzsNCj4gPiAgICAgIH0NCj4gPiArICBlbHNlDQo+ID4gKyAg ICB7DQo+ID4gKyAgICAgIGlmIChiaXRzICh0aHVtYjJfaW5zbl9yLT5hcm1f aW5zbiwgMjAsIDIyKSA9PSAweDEpDQo+ID4gKwl7DQo+ID4gKwkgIC8qIEhh bmRsZSBQTEQsIFBMSSBhZmZlY3Qgb25seSBjYWNoZXMsIHNvIG5vdGhpbmcg dG8gcmVjb3JkICovDQo+ID4gKwkgIHJldHVybiBBUk1fUkVDT1JEX1NVQ0NF U1M7DQo+ID4gKwl9DQo+ID4gKyAgICB9DQo+ID4gIA0KPiA+ICAgIHJldHVy biBBUk1fUkVDT1JEX0ZBSUxVUkU7DQo+ID4gIH0NCj4gPiANCj4gDQo+IEhp IFRyZW50LA0KPiANCj4gVGhhbmtzIGZvciB0aGUgcGF0Y2guICBBZnRlciBz dGFyaW5nIGF0IHRoZSBBUk0gYXJjaGl0ZWN0dXJlIHJlZmVyZW5jZSBtYW51 YWwgZW5vdWdoLCBJDQo+IHRoaW5rIHRoaXMgaXMgZmluZS4NCj4gDQo+IElu IHRoZSBtYW51YWwsIGhvd2V2ZXIsIGluIHRhYmxlICJUYWJsZSBBNS0yMCBM b2FkIGJ5dGUsIG1lbW9yeSBoaW50cyIsIHNvbWUgZW5jb2RpbmdzIHdpdGgN Cj4gUnQgPT0gMGIxMTExIGRlY29kZSB0byAiVU5QUkVESUNUQUJMRSIuICBT aG91bGQgdGhlIHJlY29yZCBmYWlsIGZvciB0aG9zZT8gIEkgdGhpbmsgY3Vy cmVudGx5DQo+IHdpdGggeW91ciBwYXRjaCB3ZSB3aWxsIGFjY2VwdCB0aGVt LiAgSSBhbSB0aGlua2luZyBpdCB3b3VsZCBiZSBnb29kIHRvIGZhaWwsIGJl Y2F1c2Ugc2luY2UNCj4gd2UgY2FuJ3Qga25vdyB0aGUgc2lkZSBlZmZlY3Rz IG9mIHN1Y2ggaW5zdHJ1Y3Rpb24sIHdlIHJpc2sgc2hvd2luZyBzb21lIGZh bHNlIGluZm9ybWF0aW9uIGlmDQo+IHdlIGp1c3QgYXNzdW1lIG5vdGhpbmcg aGFzIGNoYW5nZWQuDQoNCkknbSBub3Qgc3VyZSB3aGF0IGRvY3VtZW50IHRo aXMgaXMgZnJvbSwgYnV0IGluIGh0dHBzOi8vc3RhdGljLmRvY3MuYXJtDQou Y29tL2RkaTA0MDYvYy9EREkwNDA2Q19DX2FybV9hcmNoaXRlY3R1cmVfcmVm ZXJlbmNlX21hbnVhbC5wZGYNCg0KVGFibGUgQTYtMjAgaXMgdGl0bGVkIGFz IGFib3ZlLg0KDQpSYXRoZXIgdGhhbiB0aGlzLCBJIHVzZWQgdGhlIHRodW1i MiBzdXBwbGVtZW50IEkgZm91bmQgaGVyZTogaHR0cDovL2hlcg0KbWVzLndp bmdzLmNzLndpc2MuZWR1L2ZpbGVzL1RodW1iLTJTdXBwbGVtZW50UmVmZXJl bmNlTWFudWFsLnBkZg0KDQpTZWN0aW9uIDMuMy4zIGhhZCB0aGUgbW9zdCB1 c2VmdWwgdGFibGUgYW5kIGV4aGF1c3RpdmUgbGlzdCBvZiBwb3NzaWJsZQ0K ZW5jb2RpbmdzIGZvciB0aGlzIHR5cGUgb2YgdGh1bWIyIGluc3RydWN0aW9u Lg0KDQpJIHNlZSBub3cgdGhhdCBub3QgZXZlcnkgcG9zc2libGUgYWRkcmVz c2luZyBtb2RlIGlzIHN1cHBvcnRlZCBmb3INClBMRC9QTEksIGFuZCB0aGVy ZSBhcmUgd2F5cyB0byBlbmNvZGUgYSByZXNlcnZlZCBhZGRyZXNzaW5nIG1v ZGUgZm9yDQphbGwgaW5zdHJ1Y3Rpb25zIG9mIHRoaXMgdHlwZS4NCg0KSSd2 ZSBwcmVwYXJlZCBhIGZvbGxvdyBvbiBwYXRjaCB0aGF0IHNob3VsZCBwcm92 aWRlIGFuIGV4aGF1c3RpdmUgY2hlY2sNCmZvciBQTEQgYW5kIFBMSSBpbnN0 cnVjdGlvbnMuICBJdCBhbHNvIGVuaGFuY2VzIHRoZSBjaGVjayBmb3Igb3Ro ZXINCmluc3RydWN0aW9ucyBvZiB0aGlzIGdlbmVyYWwgZm9ybWF0LCBidXQg SSd2ZSBub3QgdmVyaWZpZWQgdGhhdCB0aGUNCmNvZGUgaXMgZXhoYXVzdGl2 ZSB0aGVyZS4gIEl0IGlzIGF0IGxlYXN0IGJldHRlciB0aGFuIGl0IHdhcy4N Cg0KPiBJZiB5b3UgYXJlIG1vdGl2YXRlZCwgaXQgd291bGQgYmUgbmljZSB0 byBhZGQgYSB0ZXN0IGZvciB0aGlzIGluc3RydWN0aW9uIGluIGFybV9yZWNv cmRfdGVzdCwNCj4gYnV0IEkgd29uJ3QgcmVxdWlyZSBpdCwgc2luY2UgdGhl IGN1cnJlbnQgc3RhdGUgaXMgdGhhdCB0aGlzIHRlc3QgaXNuJ3QgbWVhbnQg dG8gdGVzdCBhbGwNCj4gcG9zc2libGUgaW5zdHJ1Y3Rpb24sIGFuZCBJIGRv bid0IHdhbnQgdG8gaW1wb3NlIHRoYXQgYnVyZGVuIG9uIHlvdS4NCg0KSSBt aWdodCB0aGF0IGJlIFRIQVQgbW90aXZhdGVkLCBzaW5jZSBJJ3ZlIG5ldmVy IGV2ZW4gdXNlZCB0aGF0IHRlc3QNCmZlYXR1cmUu >From gdb-patches-return-151312-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Oct 01 22:08:57 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 122806 invoked by alias); 1 Oct 2018 22:08:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 122775 invoked by uid 89); 1 Oct 2018 22:08:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:969 X-HELO: NAM02-CY1-obe.outbound.protection.outlook.com Received: from mail-cys01nam02on0104.outbound.protection.outlook.com (HELO NAM02-CY1-obe.outbound.protection.outlook.com) (104.47.37.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Oct 2018 22:08:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=impinj.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QK8AVO7HQCPvdhLa2VAbSlQbEpbbPuhgP4lly12V7z4=; b=lA8BoJiwVwcVrf7qezP0VKjYUMv/iV14ulTOCOsXImtZFu14UbP8uXR8piybK3HTrF9dPaQUZNGafuZUB7tSaMcIiVNngrwTRMMyxe5pBdDN9faRrDVp8qzasdWMl+RwZhzSmpSXlXTmoL7Vfem/Tcvo7jHv7yDXLYDLtl8PsSM= Received: from MWHPR0601MB3708.namprd06.prod.outlook.com (10.167.236.38) by MWHPR0601MB3705.namprd06.prod.outlook.com (10.167.236.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Mon, 1 Oct 2018 22:08:51 +0000 Received: from MWHPR0601MB3708.namprd06.prod.outlook.com ([fe80::f4ee:3633:74c0:ab4]) by MWHPR0601MB3708.namprd06.prod.outlook.com ([fe80::f4ee:3633:74c0:ab4%3]) with mapi id 15.20.1185.024; Mon, 1 Oct 2018 22:08:51 +0000 From: Trent Piepho To: "gdb-patches@sourceware.org" CC: Trent Piepho Subject: [PATCH v2 1/2] Record ARM THUMB2 PLD/PLI cache instructions Date: Mon, 01 Oct 2018 22:08:00 -0000 Message-ID: <20181001220826.10429-1-tpiepho@impinj.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=tpiepho@impinj.com; received-spf: None (protection.outlook.com: impinj.com does not designate permitted sender hosts) Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2018-10/txt/msg00030.txt.bz2 Content-length: 989 These weren't decoded correctly and trigger an unknown instruction error when recording. The ARM format was handled, but not the 32-bit THUMB2 format. Since they are only hints that may affect cache state, there is nothing to record. gdb/ChangeLog 2018-09-28 Trent Piepho PR gdb/23725 * gdb/arm-tdep.c (thumb2_record_ld_mem_hints): Decode thumb2 PLD/PLI --- gdb/arm-tdep.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index c3280ee211..90936ada8e 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -12683,6 +12683,14 @@ thumb2_record_ld_mem_hints (insn_decode_record *th= umb2_insn_r) record_buf); return ARM_RECORD_SUCCESS; } + else + { + if (bits (thumb2_insn_r->arm_insn, 20, 22) =3D=3D 0x1) + { + /* Handle PLD, PLI affect only caches, so nothing to record */ + return ARM_RECORD_SUCCESS; + } + } =20 return ARM_RECORD_FAILURE; } --=20 2.14.4