From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11187-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 28958 invoked by alias); 9 Dec 2001 19:10:47 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 28937 invoked from network); 9 Dec 2001 19:10:45 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 9 Dec 2001 19:10:45 -0000
Received: from rtl.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA00883;
	Sun, 9 Dec 2001 11:10:43 -0800 (PST)
Received: (from ezannoni@localhost)
	by rtl.cygnus.com (8.11.2/8.11.0) id fB9JGmf01255;
	Sun, 9 Dec 2001 14:16:48 -0500
X-Authentication-Warning: krustylu.cygnus.com: ezannoni set sender to ezannoni@cygnus.com using -f
From: Elena Zannoni <ezannoni@cygnus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15379.47264.397391.436411@krustylu.cygnus.com>
Date: Sun, 09 Dec 2001 11:10:00 -0000
To: fnf@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: Hopefully last one of these init_types() tweaks
In-Reply-To: <200112091815.fB9IF9e02565@fishpond.ninemoons.com>
References: <200112091815.fB9IF9e02565@fishpond.ninemoons.com>
X-Mailer: VM 6.97 under Emacs 20.7.1
X-SW-Source: 2001-12/txt/msg00254.txt.bz2

Fred Fish writes:
 > Found one more case where init_types could simply be called with the
 > right flag bits rather than setting them after the fact.  I believe
 > this is the last one of these, except for one in java_lookup_class()
 > that is in code that is commented out and is broken code anyway.
 > 
 > -Fred


Yes, please commit it.

Thanks
Elena

 > 
 > 2001-12-09  Fred Fish  <fnf@redhat.com>
 > 
 > 	* mdebugread.c (cross_ref): Pass TYPE_FLAG_STUB to init_type()
 > 	rather than setting it after the type is created.
 > 
 > Index: mdebugread.c
 > ===================================================================
 > RCS file: /cvs/cvsfiles/devo/gdb/mdebugread.c,v
 > retrieving revision 2.88
 > diff -c -p -r2.88 mdebugread.c
 > *** mdebugread.c	2001/11/10 03:02:19	2.88
 > --- mdebugread.c	2001/12/08 21:20:59
 > *************** cross_ref (int fd, union aux_ext *ax, st
 > *** 4234,4241 ****
 >     if (rf == -1)
 >       {
 >         *pname = "<undefined>";
 > !       *tpp = init_type (type_code, 0, 0, (char *) NULL, current_objfile);
 > !       TYPE_FLAGS (*tpp) |= TYPE_FLAG_STUB;
 >         return result;
 >       }
 >   
 > --- 4234,4240 ----
 >     if (rf == -1)
 >       {
 >         *pname = "<undefined>";
 > !       *tpp = init_type (type_code, 0, TYPE_FLAG_STUB, (char *) NULL, current_objfile);
 >         return result;
 >       }
 >