From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103013 invoked by alias); 25 Sep 2018 04:37:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103002 invoked by uid 89); 25 Sep 2018 04:37:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=evening, H*x:Evolution, H*UA:Evolution X-HELO: mailsec106.isp.belgacom.be Received: from mailsec106.isp.belgacom.be (HELO mailsec106.isp.belgacom.be) (195.238.20.102) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Sep 2018 04:37:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1537850231; x=1569386231; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=7Pw96aT0q/xlYUOK3iekLQjCdC17JoJZF3+k4jkFQPw=; b=P/77ap0iLpT49a10ykk8e42QabxWRcuVg9bkUGbNA4PNLWxMeuN7l9GB 1RlelPJeGcFIp6iHRx+nxxIvVCv4Ww==; Received: from 148.211-243-81.adsl-dyn.isp.belgacom.be (HELO md) ([81.243.211.148]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 25 Sep 2018 06:37:08 +0200 Message-ID: <1537850228.1486.3.camel@skynet.be> Subject: Re: [RFAv2 1/6] New cli-utils.h/.c function extract_info_print_args From: Philippe Waroquiers To: Tom Tromey Cc: gdb-patches@sourceware.org Date: Tue, 25 Sep 2018 04:37:00 -0000 In-Reply-To: <87tvmfniwi.fsf@tromey.com> References: <20180826165359.1600-1-philippe.waroquiers@skynet.be> <20180826165359.1600-2-philippe.waroquiers@skynet.be> <878t3yu8vv.fsf@tromey.com> <1537733790.3924.13.camel@skynet.be> <87tvmfniwi.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00826.txt.bz2 On Mon, 2018-09-24 at 07:07 -0600, Tom Tromey wrote: > Maybe it is too late to fix the "mem" command. I am not sure. I do > know that back when I approved a similar change to "disasssemble" (I > thought I'd written that! But the history shows not), there were > complaints -- we broke people's workarounds for the bad parsing > behavior. On the other hand, "disasssemble" is probably used a lot more > than "mem". > > Philippe> So, it looks possible to have extract_arg behaviour replaced by > Philippe> extract_arg_maybe_quoted behaviour. > Philippe> If you agree with the above analysis, I will work on that in a separate > Philippe> patch series. > > One idea might be to upgrade the calls where it seems reasonable and > then leave the legacy behavior for the ones where it is not... perhaps > at the end, renaming extract_arg so that the name makes it clear that it > shouldn't be used in new code. > > What do you think of that? It's not necessary for you to do all the > work involved. Yes, that sounds a reasonable approach. No problem for me to work on that, and give a proposal 'change to new behavior' or 'keep legacy behavior' for each extract_arg call (it might take a week or 2, as gdb is an evening/week-end activity). Once the analysis of which calls are reasonable to change is done, the code changes should be pretty small. Philippe