From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14533 invoked by alias); 5 Dec 2001 20:39:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14493 invoked from network); 5 Dec 2001 20:39:11 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 5 Dec 2001 20:39:11 -0000 Received: from rtl.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA11179; Wed, 5 Dec 2001 12:39:08 -0800 (PST) Received: (from ezannoni@localhost) by rtl.cygnus.com (8.11.2/8.11.0) id fB5KjIE06187; Wed, 5 Dec 2001 15:45:18 -0500 X-Authentication-Warning: krustylu.cygnus.com: ezannoni set sender to ezannoni@cygnus.com using -f From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15374.34654.430691.479716@krustylu.cygnus.com> Date: Wed, 05 Dec 2001 12:39:00 -0000 To: Michael Snyder Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix regexp problem with "operator* etc. In-Reply-To: <3C0E7F54.B4122F5A@cygnus.com> References: <200111020929.DAA09585@duracef.shout.net> <3C0BCFF9.3C476F2@cygnus.com> <15374.10460.202277.477676@krustylu.cygnus.com> <3C0E7F54.B4122F5A@cygnus.com> X-Mailer: VM 6.97 under Emacs 20.7.1 X-SW-Source: 2001-12/txt/msg00149.txt.bz2 Michael Snyder writes: > Elena Zannoni wrote: > > > > Michael Snyder writes: > > > > > > I committed this change, without Michael Chastain's worthy suggestion > > > regarding the size of the alloca. Will submit that separately. > > > > > > Michael Elizabeth Chastain wrote: > > > > > > > > cplusfuncs.exp: > > > > In my maintainer area. > > > > Approved unconditionally. > > > > No matter what gdb does, the test script should do the right thing. > > > > > > > > alloca change: > > > > Outside my maintainer area. > > > > Recommended for rework. > > > > > > > > I think the size is long enough, but the proof of correctness is > > > > too delicate. There is no space explicitly allocated for the final > > > > null, so the alloca is correct only because it occurs in a context > > > > where at least one character is being deleted. This also relies on > > > > some character-class tests being the same in this function and > > > > in operator_chars. How about something stupidly correct: > > > > > > > > alloca (8 + fix + strlen(opname) + 1) > > > > Ah, OK. > > > > > > > > > > operator_chars change: > > > > Outside my maintainer area. > > > > Proofread and tested, works for me. > > > > Recommended for approval. > > > > Whoops, I missed this one. Sorry, I'll go and look at it. Did you > > commit it already? > > Yep, I guess I mistook silence for assent. Sorry if I overstepped. > I'll back it out if it doesn't look OK to you. No, no problem. It's fine. Elena