Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Define SVR4 link map offset fetcher for Linux/PPC
Date: Sun, 02 Dec 2001 21:32:00 -0000	[thread overview]
Message-ID: <15371.4042.166544.538072@krustylu.cygnus.com> (raw)
In-Reply-To: <3C0A6CB3.9080104@cygnus.com>

Andrew Cagney writes:
 > > I've tested this patch on AIX (to make sure I didn't break the build
 > > or cause any regressions) and also in a Linux/x86 cross Linux/PPC test
 > > environment.
 > 
 > Kevin, did you try this with --target=powerpc-eabi as listed in the 
 > MAINTAINERS?  I'm seeing a -Werror of solib_add() undefined:
 > 
 > > /home/scratch/PENDING/rm-obsolete/src/gdb/solib-svr4.c:912: warning: implicit declaration of function `solib_add'
 > > gmake[1]: *** [solib-svr4.o] Error 1
 > > gmake[1]: Leaving directory `/home/scratch/PENDING/rm-obsolete/carp/X-powerpc-eabi/gdb'
 > > gmake: *** [all-gdb] Error 2
 > 
 > enjoy,
 > Andrew
 > 


With powerpc-eabi I am also getting these:

/bart/ezannoni/uberbaum/src/gdb/solib-svr4.c:857: undefined reference to `remove_solib_event_breakpoints'
/bart/ezannoni/uberbaum/src/gdb/solib-svr4.c:984: undefined reference to `create_solib_event_breakpoint'
libgdb.a(solib.o): In function `clear_solib':
/bart/ezannoni/uberbaum/src/gdb/solib.c:732: undefined reference to `disable_breakpoints_in_shlibs'
collect2: ld returned 1 exit status

I guess it is missing the SOLIB_ADD macro definition.
Should an 
#include "solib.h" be added to the config/powerpc/*.h files?

That seems to work.

Elena





 > > 	* ppc-linux-tdep.c (solib-svr4.h): Include.
 > > 	(ppc_linux_svr4_fetch_link_map_offsets): New function.
 > > 	* ppc-tdep.h (ppc_linux_svr4_fetch_link_map_offsets): Declare.
 > > 	* rs6000-tdep.c (solib-svr4.h): Include.
 > > 	(rs6000_gdbarch_init): Set up ppc_linux_svr4_fetch_link_map_offsets()
 > > 	as the link map offsets fetcher.
 > > 
 > > 	* config/powerpc/aix.mt (TDEPFILES): Add solib-svr4.o.
 > > 	* config/powerpc/macos.mt (TDEPFILES): Likewise.
 > > 	* config/powerpc/nbsd.mt (TDEPFILES): Likewise.
 > > 	* config/powerpc/ppc-eabi.mt (TDEPFILES): Likewise.
 > > 	* config/powerpc/ppc-sim.mt (TDEPFILES): Likewise.
 > > 	* config/powerpc/ppcle-eabi.mt (TDEPFILES): Likewise.
 > > 	* config/powerpc/ppcle-sim.mt (TDEPFILES): Likewise.
 > > 	* config/powerpc/vxworks.mt (TDEPFILES): Likewise.
 > > 	* config/rs6000/aix4.mt (TDEPFILES): Likewise.
 > > 	* config/rs6000/rs6000.mt (TDEPFILES): Likewise.
 > > 	* config/rs6000/rs6000lynx.mt (TDEPFILES): Likewise.
 > > 
 > 


  reply	other threads:[~2001-12-03  5:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-25  8:55 Kevin Buettner
2001-11-30 16:35 ` Kevin Buettner
2001-12-02 10:02 ` Andrew Cagney
2001-12-02 21:32   ` Elena Zannoni [this message]
2001-12-03 10:26     ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15371.4042.166544.538072@krustylu.cygnus.com \
    --to=ezannoni@cygnus.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox