From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 349 invoked by alias); 5 May 2017 19:21:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 335 invoked by uid 89); 5 May 2017 19:21:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=boards X-HELO: mail-wr0-f169.google.com Received: from mail-wr0-f169.google.com (HELO mail-wr0-f169.google.com) (209.85.128.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 05 May 2017 19:21:48 +0000 Received: by mail-wr0-f169.google.com with SMTP id l9so8950404wre.1 for ; Fri, 05 May 2017 12:21:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=uziRzh+extnaxyMUa6WAnMuACCTnjN8lLtjfG37t4cY=; b=OqnILqklQinflEPa3HrbF+MJcijwqDzyeIOvrlIn9/9qu79HILum6tBh73hvlgM3Hg ZLV12SqynoLd1RImw6xEw80XSqpdUnC8YnWUBMFSZuV0Ml0TVAyTer2MaCOnjfkIOjVq QC6F8fcQ7WZCADYB+PqkzrohtBwKMnPrGq2psBh7ls75gZWmFBYa1eyflxjUXxMnNBjy IQpEgamTrBGb64/7w23yULPQe68z1jvv/UKOd+pP9MBr1WSxGFzoerts97TN0CCois0d x1nTmOCgmRXj9OikYW0pdk3Stq1f62HiOt7qFwAcL3rDrfiV+Z7TDHr8qRmpkwFEP2kO p3ng== X-Gm-Message-State: AN3rC/5ycWWiaH0QDXaoz36Dhn9CLxkYSfJfduVmOkwGTgypz3+grmXU vg7hzY49BiZHTZNC X-Received: by 10.223.131.196 with SMTP id 62mr21263256wre.162.1494012109385; Fri, 05 May 2017 12:21:49 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id x20sm3365922wme.0.2017.05.05.12.21.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2017 12:21:48 -0700 (PDT) Subject: Re: [PATCH v6 4/4] Implement proper "startup-with-shell" support on gdbserver To: Sergio Durigan Junior , GDB Patches References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170504052954.16936-1-sergiodj@redhat.com> <20170504052954.16936-5-sergiodj@redhat.com> From: Pedro Alves Message-ID: <1536f3d7-a570-9195-9591-2e5882426c02@redhat.com> Date: Fri, 05 May 2017 19:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170504052954.16936-5-sergiodj@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00151.txt.bz2 On 05/04/2017 06:29 AM, Sergio Durigan Junior wrote: > --- a/gdb/gdbserver/server.c > +++ b/gdb/gdbserver/server.c > @@ -877,6 +877,31 @@ handle_general_set (char *own_buf) > return; > } > > + if (startswith (own_buf, "QStartupWithShell:")) > + { > + char *value = own_buf + strlen ("QStartupWithShell:"); const. > +set unique_file [standard_output_file "unique-file.unique-extension"] > +set unique_file_dir [standard_output_file ""] > + > +run_on_host "touch $unique_file" "touch" "$unique_file" > + This may require some tweaking or disabling when tested against a remote host. Not sure. Could you check whether the test runs with testsuite/boards/local-remote-host-native.exp? Otherwise this one LGTM. Thanks, Pedro Alves