From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elena Zannoni To: Kevin Buettner Cc: Daniel Jacobowitz , Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] W.I.P. AltiVec ppc registers support. Date: Thu, 29 Nov 2001 14:42:00 -0000 Message-id: <15366.47960.711736.518863@krustylu.cygnus.com> References: <15365.39495.801289.497931@krustylu.cygnus.com> <1011129183830.ZM18856@ocotillo.lan> <15366.44991.616576.411278@krustylu.cygnus.com> <1011129222000.ZM19585@ocotillo.lan> X-SW-Source: 2001-11/msg00578.html Kevin Buettner writes: > On Nov 29, 4:59pm, Elena Zannoni wrote: > > > > With regard to > > > > > > > Index: config/powerpc/nm-linux.h > > > [...] > > > > +#define FETCH_INFERIOR_REGISTERS > > > > > > I think this is a good thing. It *might not* be strictly necessary > > > for adding AltiVec support via PEEKUSER / POKEUSER, but it does give > > > us more control. Also doing this allows us to clean up the code in other > > > ways. E.g, the following bit from config/powerpc/nm-linux.h can be > > > removed: > > > > > > > extern int ppc_register_u_addr (int, int); > > > > #define REGISTER_U_ADDR(addr, blockend, regno) \ > > > > (addr) = ppc_register_u_addr ((blockend),(regno)); > > > > > > This in turn means that ppc_register_u_addr() can be made static > > > and that the ``ustart'' parameter can be removed. All calls to > > > register_addr() (in your new code) in ppc-linux-nat.c should be > > > changed to invoke ppc_register_u_addr() directly. > > > > > > > Unfortunately not. I thought the same, until I remembered about core > > file debugging. That function is called by fetch_core_registers() in > > core-aout.c. > > Hmm... I wonder if Linux/PPC even needs this function in core-aout.c. > Daniel J. is the expert on this stuff. Daniel, doesn't Linux/PPC use > core-regset.c instead? > Whoops, yes, you are right. False alarm. Elena > Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13709 invoked by alias); 29 Nov 2001 22:42:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13651 invoked from network); 29 Nov 2001 22:42:44 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by hostedprojects.ges.redhat.com with SMTP; 29 Nov 2001 22:42:44 -0000 Received: from rtl.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA16017; Thu, 29 Nov 2001 14:42:40 -0800 (PST) Received: (from ezannoni@localhost) by rtl.cygnus.com (8.11.2/8.11.0) id fATMmu404075; Thu, 29 Nov 2001 17:48:56 -0500 X-Authentication-Warning: krustylu.cygnus.com: ezannoni set sender to ezannoni@cygnus.com using -f From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15366.47960.711736.518863@krustylu.cygnus.com> Date: Tue, 20 Nov 2001 08:37:00 -0000 To: Kevin Buettner Cc: Daniel Jacobowitz , Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] W.I.P. AltiVec ppc registers support. In-Reply-To: <1011129222000.ZM19585@ocotillo.lan> References: <15365.39495.801289.497931@krustylu.cygnus.com> <1011129183830.ZM18856@ocotillo.lan> <15366.44991.616576.411278@krustylu.cygnus.com> <1011129222000.ZM19585@ocotillo.lan> X-Mailer: VM 6.97 under Emacs 20.7.1 X-SW-Source: 2001-11/txt/msg00363.txt.bz2 Message-ID: <20011120083700.zq2Hh4NlibabN1oRU89ZxAIh1C5ZUY78WvM0blOR1kA@z> Kevin Buettner writes: > On Nov 29, 4:59pm, Elena Zannoni wrote: > > > > With regard to > > > > > > > Index: config/powerpc/nm-linux.h > > > [...] > > > > +#define FETCH_INFERIOR_REGISTERS > > > > > > I think this is a good thing. It *might not* be strictly necessary > > > for adding AltiVec support via PEEKUSER / POKEUSER, but it does give > > > us more control. Also doing this allows us to clean up the code in other > > > ways. E.g, the following bit from config/powerpc/nm-linux.h can be > > > removed: > > > > > > > extern int ppc_register_u_addr (int, int); > > > > #define REGISTER_U_ADDR(addr, blockend, regno) \ > > > > (addr) = ppc_register_u_addr ((blockend),(regno)); > > > > > > This in turn means that ppc_register_u_addr() can be made static > > > and that the ``ustart'' parameter can be removed. All calls to > > > register_addr() (in your new code) in ppc-linux-nat.c should be > > > changed to invoke ppc_register_u_addr() directly. > > > > > > > Unfortunately not. I thought the same, until I remembered about core > > file debugging. That function is called by fetch_core_registers() in > > core-aout.c. > > Hmm... I wonder if Linux/PPC even needs this function in core-aout.c. > Daniel J. is the expert on this stuff. Daniel, doesn't Linux/PPC use > core-regset.c instead? > Whoops, yes, you are right. False alarm. Elena > Kevin