From: Xavier Roirand <roirand@adacore.com>
To: gdb-patches@sourceware.org
Cc: brobecker@adacore.com, simon.marchi@polymtl.ca, tom@tromey.com,
Xavier Roirand <roirand@adacore.com>
Subject: [RFA 5/5 v2] Darwin: fix SIGTRAP when debugging
Date: Sun, 09 Sep 2018 13:27:00 -0000 [thread overview]
Message-ID: <1536499653-10033-1-git-send-email-roirand@adacore.com> (raw)
Debugging a program under Darwin does not work:
(gdb) start
Temporary breakpoint 1 at 0x100000fb4: file /tmp/helloworld.c, line 1.
Starting program: /private/tmp/helloworld
[New Thread 0x2903 of process 60326]
During startup program terminated with signal SIGTRAP, Trace/breakpoint
trap.
Field signaled from darwin_thread_info is not initialized thus signal
sent to the debuggee is considered as not sent by GDB whereas it should.
This patch fixes this problem and also updates (change type, initialize)
single_step value in the same structure at the same time.
gdb/ChangeLog:
* darwin-nat.h (struct darwin_thread_info) <signaled>: Change
type and initialize.
(struct darwin_thread_info) <single_step>: Change type and
initialize.
Change-Id: I0fe2a6985df9d0dfcc8a2a258a3ef70cfa19b403
---
gdb/darwin-nat.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/darwin-nat.h b/gdb/darwin-nat.h
index 5965df08ab6..4232b5e0365 100644
--- a/gdb/darwin-nat.h
+++ b/gdb/darwin-nat.h
@@ -126,10 +126,10 @@ struct darwin_thread_info : public private_thread_info
enum darwin_msg_state msg_state;
/* True if this thread is single-stepped. */
- unsigned char single_step;
+ bool single_step = 0;
/* True if a signal was manually sent to the thread. */
- unsigned char signaled;
+ bool signaled = 0;
/* The last exception received. */
struct darwin_exception_msg event;
--
2.15.2 (Apple Git-101.1)
next reply other threads:[~2018-09-09 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-09 13:27 Xavier Roirand [this message]
2018-09-09 13:55 ` Simon Marchi
2018-09-09 13:57 ` Xavier Roirand
2018-09-09 18:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536499653-10033-1-git-send-email-roirand@adacore.com \
--to=roirand@adacore.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox