From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9633 invoked by alias); 19 Nov 2001 23:56:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9608 invoked from network); 19 Nov 2001 23:56:48 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sourceware.cygnus.com with SMTP; 19 Nov 2001 23:56:48 -0000 Received: from rtl.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA21849; Mon, 19 Nov 2001 15:56:46 -0800 (PST) Received: (from ezannoni@localhost) by rtl.cygnus.com (8.11.2/8.11.0) id fAK03CB02156; Mon, 19 Nov 2001 19:03:12 -0500 X-Authentication-Warning: krustylu.cygnus.com: ezannoni set sender to ezannoni@cygnus.com using -f From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15353.40384.889329.639945@krustylu.cygnus.com> Date: Wed, 07 Nov 2001 18:31:00 -0000 To: Andrew Cagney Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] infptrace.c: use regcache_collect In-Reply-To: <3BF97B51.6030605@cygnus.com> References: <15353.24043.102000.208495@krustylu.cygnus.com> <3BF97B51.6030605@cygnus.com> X-Mailer: VM 6.97 under Emacs 20.7.1 X-SW-Source: 2001-11/txt/msg00133.txt.bz2 Andrew Cagney writes: > > 2001-11-19 Elena Zannoni > > > > * infptrace.c (fetch_register): Dynamically allocate buffer for > > register. > > [Grrr] > > > (store_register): Use regcache_collect, instead of accessing the > > register buffer directly. > > > > Provided this has been tested and doesn't show regressions, I think the > elimination of code like this can be considered pretty obvious. (Only > 400 uses of registers[] remaining ...) > > Andrew > I had tested on ppc-linux native. No regressions. (I am going to get rid of another few...) Elena