Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] infptrace.c: use regcache_collect
Date: Wed, 07 Nov 2001 15:02:00 -0000	[thread overview]
Message-ID: <15353.24043.102000.208495@krustylu.cygnus.com> (raw)


Is this ok?

Thanks
Elena

2001-11-19  Elena Zannoni  <ezannoni@redhat.com>

	* infptrace.c (fetch_register): Dynamically allocate buffer for
	register.
	(store_register): Use regcache_collect, instead of accessing the
	register buffer directly.


Index: infptrace.c
===================================================================
RCS file: /cvs/uberbaum/gdb/infptrace.c,v
retrieving revision 1.18
diff -u -p -c -r1.18 infptrace.c
cvs server: conflicting specifications of output style
*** infptrace.c	2001/10/21 14:53:46	1.18
--- infptrace.c	2001/11/19 19:23:08
*************** fetch_register (int regno)
*** 359,365 ****
    char mess[128];		/* For messages */
    register int i;
    unsigned int offset;		/* Offset of registers within the u area.  */
!   char buf[MAX_REGISTER_RAW_SIZE];
    int tid;
  
    if (CANNOT_FETCH_REGISTER (regno))
--- 359,365 ----
    char mess[128];		/* For messages */
    register int i;
    unsigned int offset;		/* Offset of registers within the u area.  */
!   char *buf = alloca (MAX_REGISTER_RAW_SIZE);
    int tid;
  
    if (CANNOT_FETCH_REGISTER (regno))
*************** store_register (int regno)
*** 424,429 ****
--- 424,430 ----
    register int i;
    unsigned int offset;		/* Offset of registers within the u area.  */
    int tid;
+   char *buf = alloca (MAX_REGISTER_RAW_SIZE);
  
    if (CANNOT_STORE_REGISTER (regno))
      {
*************** store_register (int regno)
*** 437,447 ****
    offset = U_REGS_OFFSET;
  
    regaddr = register_addr (regno, offset);
    for (i = 0; i < REGISTER_RAW_SIZE (regno); i += sizeof (PTRACE_XFER_TYPE))
      {
        errno = 0;
        ptrace (PT_WRITE_U, tid, (PTRACE_ARG3_TYPE) regaddr,
! 	      *(PTRACE_XFER_TYPE *) & registers[REGISTER_BYTE (regno) + i]);
        regaddr += sizeof (PTRACE_XFER_TYPE);
        if (errno != 0)
  	{
--- 438,453 ----
    offset = U_REGS_OFFSET;
  
    regaddr = register_addr (regno, offset);
+ 
+   /* Put the contents of regno into a local buffer */
+   regcache_collect (regno, buf);
+ 
+   /* Store the local buffer into the inferior a chunk at the time. */
    for (i = 0; i < REGISTER_RAW_SIZE (regno); i += sizeof (PTRACE_XFER_TYPE))
      {
        errno = 0;
        ptrace (PT_WRITE_U, tid, (PTRACE_ARG3_TYPE) regaddr,
! 	      *(PTRACE_XFER_TYPE *) (buf + i));
        regaddr += sizeof (PTRACE_XFER_TYPE);
        if (errno != 0)
  	{


             reply	other threads:[~2001-11-19 19:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-07 15:02 Elena Zannoni [this message]
2001-11-07 17:58 ` Andrew Cagney
2001-11-07 18:31   ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15353.24043.102000.208495@krustylu.cygnus.com \
    --to=ezannoni@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox