Re: [PATCH v2 3/4] Add DWARF index cache

Simon Marchi
2018-07-30T17:05:03Z

On 2018-07-30 11:57, Eli Zaretskii wrote:
>> Date: Mon, 30 Jul 2018 11:33:20 -0400
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org
>>
>> > mkdir accepts only one argument, not 2.
>>
>> It builds fine with x86_64-w64-mingw32-g++ on Linux here. It looks
>> like
>> gnulib offers a compatibility fix, so I guess it's ok:
>>
>> https://www.gnu.org/software/gnulib/manual/html_node/mkdir.html
>>
>> Did you see an actual failure?
>
> No, I looked in the source tree and didn't see the Gnulib's mkdir
> imported. But maybe it was added meanwhile.

Well, it looks like gnulib's sys/stat.h offers some basic compatibility
fix (to get the right include and signature) when building on mingw and
MSVC, even without importing the mkdir module. But it would probably be
better to explicitly import the mkdir module, I'll do this in the next
version.

Simon