Re: [PATCH v2 3/4] Add DWARF index cache

Eli Zaretskii
2018-07-30T15:57:30Z

> Date: Mon, 30 Jul 2018 11:33:20 -0400
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org
>
> > mkdir accepts only one argument, not 2.
>
> It builds fine with x86_64-w64-mingw32-g++ on Linux here. It looks like
> gnulib offers a compatibility fix, so I guess it's ok:
>
> https://www.gnu.org/software/gnulib/manual/html_node/mkdir.html
>
> Did you see an actual failure?

No, I looked in the source tree and didn't see the Gnulib's mkdir
imported. But maybe it was added meanwhile.

> > MinGW uses DWARF debug info for quite a few years now, so caching will
> > definitely be useful.
>
> Ah, I didn't know that, thanks. So it produces DWARF embedded in the PE
> executable?

Yes.