From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109332 invoked by alias); 12 Jul 2018 21:12:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109322 invoked by uid 89); 12 Jul 2018 21:12:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:be, RFA_v4, rfa_v4, H*f:sk:89ff2c0 X-HELO: mailsec117.isp.belgacom.be Received: from mailsec117.isp.belgacom.be (HELO mailsec117.isp.belgacom.be) (195.238.20.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jul 2018 21:12:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1531429970; x=1562965970; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=d4J2szXDUiktl4aXhMvv5ubtw0gyxnQi+laJ97SMtKE=; b=Aztgw6OAO2AcPqt9jf6/13MoLmLUd1XHS5SFu9+H4oUxnEVOeh/G5VPi bla5axNZ16v8LKgKFjTS3ku/ykE+Xw==; Received: from 160.177-177-91.adsl-dyn.isp.belgacom.be (HELO md) ([91.177.177.160]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 12 Jul 2018 23:12:47 +0200 Message-ID: <1531429967.2074.0.camel@skynet.be> Subject: Re: [RFA_v4 0/8] Implement 'frame apply COMMAND', enhance 'thread apply COMMAND' From: Philippe Waroquiers To: Pedro Alves , gdb-patches@sourceware.org Date: Thu, 12 Jul 2018 21:12:00 -0000 In-Reply-To: <89ff2c0a-2654-d4a6-ded9-65bf726a61bf@redhat.com> References: <20180710213926.32240-1-philippe.waroquiers@skynet.be> <89ff2c0a-2654-d4a6-ded9-65bf726a61bf@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00363.txt.bz2 On Wed, 2018-07-11 at 11:58 +0100, Pedro Alves wrote: > On 07/10/2018 10:39 PM, Philippe Waroquiers wrote: > > This is the fifth iteration of the patch series that: > > * implements a new command > > 'frame apply [all | COUNT | -COUNT | level LEVEL...] [FLAG]... COMMAND'. > > * enhance 'thread apply COMMAND' by adding FLAG arguments. > > * adds some shortcuts commands. > > * documents the above in gdb.texinfo and NEWS. > > * adds a unit test for cli-utils.c. > > * adds test for 'frame apply'. > > * modify gdb.threads/pthreads.exp to test 'thread apply' FLAG arguments. > > > > The fifth version is RFA v4. It handles the third set of comments > > given by Pedro. > > The main changes compared to RFA v3 are: > > * frame level LEVEL... replaces frame id ID... > > Very nice. > > The changes to the testcases and the unit tests makes > them much clearer, IMHO, well done. > > This version looks great to me. This version was pushed now ... Thanks to Simon/Eli/Pedro for help/advise and the numerous reviews. Philippe