From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87066 invoked by alias); 15 Jul 2016 12:05:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87053 invoked by uid 89); 15 Jul 2016 12:05:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=relates X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Jul 2016 12:05:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 514EA28; Fri, 15 Jul 2016 05:06:52 -0700 (PDT) Received: from e108577-lin.localnet (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC0A13F387; Fri, 15 Jul 2016 05:05:45 -0700 (PDT) From: Thomas Preudhomme To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Build gdb.opt/inline-*.exp tests at -O0, rely on __attribute__((always_inline)) (was: Re: [PATCH v3 24/34] Push thread->control.command_interp to the struct thread_fsm) Date: Fri, 15 Jul 2016 12:05:00 -0000 Message-ID: <1529320.5zxBqYOqLZ@e108577-lin> User-Agent: KMail/4.13.3 (Linux/3.13.0-85-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <2455620.gRHMPhxaPl@e108577-lin> References: <1462538104-19109-25-git-send-email-palves@redhat.com> <20144b4c-11ee-fc84-e3ad-b9992f14ce15@redhat.com> <2455620.gRHMPhxaPl@e108577-lin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00171.txt.bz2 On Friday 01 July 2016 16:24:38 Thomas Preudhomme wrote: > On Friday 01 July 2016 13:05:35 Pedro Alves wrote: > > On 07/01/2016 12:02 PM, Thomas Preudhomme wrote: > > > The new tests added by this patch fail for arm-none-eabi targets because > > > -O2 leads to instructions to be reordered widely. In this case, the > > > instruction that follows the first one for line 64 is related to line 70 > > > so the test is failing. Shouldn't this test be compiled with -Og and > > > probably also -finline- small-functions -findirect-inlining > > > -fpartial-inlining which relates to inlining and are included in -O2. > > > > Or even just plain -O0. See the commit log below. WDYT? > > I'm not very familiar with GDB but the description looks great indeed. > Thanks! Hi Pedro, What is the status of that patch? Best regards, Thomas