From mboxrd@z Thu Jan 1 00:00:00 1970 From: Elena Zannoni To: Eli Zaretskii Cc: ezannoni@cygnus.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] Multiarch tm_print_insn Date: Tue, 04 Sep 2001 21:00:00 -0000 Message-id: <15253.42307.875233.300520@krustylu.cygnus.com> References: <15234.61471.459368.455580@krustylu.cygnus.com> <3405-Wed22Aug2001084554+0300-eliz@is.elta.co.il> <15236.12258.330506.371048@krustylu.cygnus.com> <9003-Thu23Aug2001085323+0300-eliz@is.elta.co.il> X-SW-Source: 2001-09/msg00005.html Eli Zaretskii writes: > > From: Elena Zannoni > > Date: Wed, 22 Aug 2001 18:19:14 -0400 > > > > > > This patch multiarches tm_print_insn. > > > > I changed all the direct callers to (*tm_print_insn), to use > > > > the multiarch macro TARGET_PRINT_INSN. > > > > > > Should this macro be documented in gdbint.texinfo? > > > > In which section should it go? > > The section "Target conditionals" sounds about right. How about this? [Note: I don't know how to reference correctly the 'opcodes' library.] Elena 2001-09-04 Elena Zannoni * gdbint.texinfo (Target Architecture Definition): Add explanation of TARGET_PRINT_INSN macro. Index: gdbint.texinfo =================================================================== RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v retrieving revision 1.35 diff -u -p -r1.35 gdbint.texinfo --- gdbint.texinfo 2001/08/15 14:47:53 1.35 +++ gdbint.texinfo 2001/09/05 03:59:40 @@ -3566,6 +3566,17 @@ If non-zero, the target has support for watchpoints. @xref{Algorithms, watchpoints}, for more details and other related macros. +@item TARGET_PRINT_INSN (@var{addr}, @var{info}) +@findex TARGET_PRINT_INSN +This is the function used by @value{GDBN} to print an assembly +instruction. It prints the instruction at address @var{addr} in +debugged memory abd returns the length of the instruction, in bytes. If +a target doesn't define its own printing routine, it defaults to an +accessor function for the global pointer @var{tm_print_insn}. This +usually points to a function in the @code{opcodes} library +(@xref{,,opcodes}). @var{info} is a structure defined in @code{opcodes} +used to pass information to the instruction decoding routine. + @item USE_STRUCT_CONVENTION (@var{gcc_p}, @var{type}) @findex USE_STRUCT_CONVENTION If defined, this must be an expression that is nonzero if a value of the