Re: [RFA]: Cleanup tui/tui-file.[ch]

Elena Zannoni
2001-07-17T13:40:00Z

Andrew Cagney writes:
>
> > Ah!!! The marvellous -Werror that I'm currently figthing with in ChorusOS
> > to remove all our warnings..... ... ...
> >
> >
> >> I think it is because you removed the #include "tuiIO.h".
> >>
> >> Can I put it back?
> >
> >
> > Sure!
>
>
> Hmm, is tui-file now only needed when the TUI is included?
>
> Andrew

Looks that way. Another thought is that now we can get rid
of some the *_base_* functions that were added for the TUI. For
instance, print_frame_info_base and print_frame_info.

From the HP merge changelog (1998), just random grepping for _base:

* source.c :(print_source_lines): Rename to
print_source_lines_base and make static; formatting.
(print_source_lines): New function.

* stack.c (down_silently_base, up_silently_base,
args_plus_locals_info, print_frame_info_base,
print_stack_frame_base, print_stack_frame_base_stub): Declare.
(print_stack_frame_stub): New version created, old version renamed
to show_and_print_stack_frame_base_stub.
(print_stack_frame_base_stub, print_only_stack_frame_stub,
show_and_print_stack_frame, print_only_stack_frame,
stack_publish_stopped_with_no_frame, print_frame_info,
show_stack_frame, backtrace_full_command, args_plus_locals_info,
select_and_print_frame, select_and_maybe_print_frame,
current_frame_command, func_command): New functions.
(backtrace_command): New function, old renamed to
backtrace_command_1.
(print_block_frame_locals, print_frame_local_vars): Additional
parameter, number of tabs.
(up_silently_command): New function, old renamed to
up_silently_command_base.
(down_silently_command): New function, old renamed to
down_silently_base.

Elena