Re: [PATCH] Fix auto-solib-add bug (patch revised 7/1/2001)

[Elena Zannoni <ezannoni@cygnus.com>]

Kevin Buettner writes:
 > On Jul 1,  3:07pm, Fred Fish wrote:
 > 
 > > Here is the latest patch, which should apply cleanly to the sourceware
 > > gdb sources as of today.  I also made a couple of other minor tweaks
 > > and cleanups.
 > 
 > Fred,
 > 
 > Your patch is approved except for the portions which move the
 > declaration of auto_solib_add from symfile.h to coff-solib.h, solib.h,
 > and somsolib.h.  I would prefer that you submit a separate patch for
 > this change.  (I spoke with Jim Blandy about them and he pointed out
 > that the declaration of auto_solib_add ought to stay in symfile.h so
 > long as the definition remains in symfile.c.)  In any event, I think
 > that moving the declaration of auto_solib_add qualifies as a cleanup
 > activity and isn't necessary for the rest of your patch to work.
 > 
 > One of the problems with approving this patch is that it touches a lot
 > of files for which I am not a maintainer.  I have spoken with Michael
 > Snyder regarding your changes to infcmd.c and infrun.c and he has no
 > problem with them.  I believe that the rest of the changes are
 > "obvious" once the rest of your changes are accepted, but just the
 > same it probably wouldn't hurt to wait a couple of days before
 > checking them in just in case some other maintainer has issues...
 > 


Actually I have a question about auto_solib_add.  Is there any way to
remove the overloaded meaning of 'threshold' that HP has given to this
variable?  On some platforms it is a boolean, on others (HPUX) it is
a threshold in megabytes. I am not familiar with the code, but is
there a way to have an extra auto_solib_threshold variable, and
possibly make auto_solib_add an enum?

I also agree with Jim abd Kevin about keeping the definition in
symfile.h.

Elena


 > Kevin