Re: [PATCH 09/10] Move register_dump to regcache-dump.c

Simon Marchi
2018-02-21T12:57:52Z

On 2018-02-21 03:27, Yao Qi wrote:
> On Sat, Feb 17, 2018 at 3:50 AM, Simon Marchi <simon.marchi@polymtl.ca>
> wrote:
>> I think it would make sense to move the remaining dump-related things
>> (the
>> register_dump class, the register_dump::dump implementation) to
>> regcache-dump.c.
>>
>
> register_dump::dump accesses 'struct regcache_desc', which is declared
> in
> regcache.c, so that register_dump::dump can't be moved to
> regcache-dump.c.

Is there any reason we can't move struct regcache_descr to regcache.h?