Re: [PATCH 09/10] Move register_dump to regcache-dump.c

Simon Marchi
2018-02-17T03:50:36Z

Hi Yao,

I think it would make sense to move the remaining dump-related things
(the register_dump class, the register_dump::dump implementation) to
regcache-dump.c.

For all empty destructors, you can use "= default" instead of {}.

> diff --git a/gdb/regcache-dump.c b/gdb/regcache-dump.c
> new file mode 100644
> index 0000000..4780fc4
> --- /dev/null
> +++ b/gdb/regcache-dump.c
> @@ -0,0 +1,335 @@
> +/* Copyright (C) 1986-2017 Free Software Foundation, Inc.
> +
> + This file is part of GDB.
> +
> + This program is free software; you can redistribute it and/or
> modify
> + it under the terms of the GNU General Public License as published
> by
> + the Free Software Foundation; either version 3 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program. If not, see
> <http://www.gnu.org/licenses/>. */
> +
> +#include "defs.h"
> +#include "gdbcmd.h"
> +#include "regcache.h"
> +#include "common/def-vector.h"
> +#include "valprint.h"
> +#include "remote.h"
> +#include "reggroups.h"
> +#include "target.h"
> +
> +/* Dump registers from regcache, used for dump raw registers and
> + cooked registers. */

I just saw it now, but you could say either "used for dumping" or "used
to dump", but "for dump" doesn't sound right.

Simon