From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: [PATCH] Use boards/local-board.exp more
Date: Thu, 30 Nov 2017 16:35:00 -0000 [thread overview]
Message-ID: <1512059694-18986-1-git-send-email-simon.marchi@ericsson.com> (raw)
local-board.exp was introduced recently, containing the code required to
force the gdbserver boards to be non-remote (from the DejaGNU point of
view). Other board files use the same trick of forcing isremote to 0.
Instead of doing it by hand in each file, include local-board.exp.
gdb/testsuite/ChangeLog:
* boards/cc-with-tweaks.exp: Include local-board.exp instead of
setting isremote by hand.
* boards/dwarf4-gdb-index.exp: Likewise.
* boards/fission.exp: Likewise.
* boards/stabs.exp: Likewise.
---
gdb/testsuite/boards/cc-with-tweaks.exp | 5 +----
gdb/testsuite/boards/dwarf4-gdb-index.exp | 5 +----
gdb/testsuite/boards/fission.exp | 6 ++----
gdb/testsuite/boards/stabs.exp | 6 ++----
4 files changed, 6 insertions(+), 16 deletions(-)
diff --git a/gdb/testsuite/boards/cc-with-tweaks.exp b/gdb/testsuite/boards/cc-with-tweaks.exp
index 794217c..bdffdab 100644
--- a/gdb/testsuite/boards/cc-with-tweaks.exp
+++ b/gdb/testsuite/boards/cc-with-tweaks.exp
@@ -30,10 +30,7 @@ if ![info exists CC_WITH_TWEAKS_FLAGS] {
}
# This is needed otherwise dejagnu tries to rsh to host "cc-with-tweaks".
-# set_board_info only sets the value if not already set.
-# find_gcc checks for this, so set early.
-unset_board_info isremote
-set_board_info isremote 0
+load_board_description "local-board"
# This is based on baseboards/unix.exp.
# At the moment we only support systems that unix.exp supports.
diff --git a/gdb/testsuite/boards/dwarf4-gdb-index.exp b/gdb/testsuite/boards/dwarf4-gdb-index.exp
index 09c9c98..ea4f47a 100644
--- a/gdb/testsuite/boards/dwarf4-gdb-index.exp
+++ b/gdb/testsuite/boards/dwarf4-gdb-index.exp
@@ -20,10 +20,7 @@
# bash$ make check RUNTESTFLAGS='--target_board=dwarf4-gdb-index'
# This is needed otherwise dejagnu tries to rsh to host "dwarf4-gdb-index".
-# set_board_info only sets the value if not already set.
-# find_gcc checks for this, so set early.
-unset_board_info isremote
-set_board_info isremote 0
+load_board_description "local-board"
# This is based on baseboards/unix.exp.
# At the moment we only support systems that unix.exp supports.
diff --git a/gdb/testsuite/boards/fission.exp b/gdb/testsuite/boards/fission.exp
index 1eb89de..4a62ed9 100644
--- a/gdb/testsuite/boards/fission.exp
+++ b/gdb/testsuite/boards/fission.exp
@@ -31,7 +31,5 @@ set_board_info compiler "[find_gcc]"
# -gsplit-dwarf implies -ggnu-pubnames for gcc, it doesn't for clang.
set_board_info debug_flags "-gdwarf-4 -gsplit-dwarf -ggnu-pubnames -fdebug-types-section -Wl,--gdb-index"
-# This is needed otherwise dejagnu tries to rsh to host "fission". Blech.
-# Double blech: set_board_info only sets the value if not already set.
-unset_board_info isremote
-set_board_info isremote 0
+# This is needed otherwise dejagnu tries to rsh to host "fission".
+load_board_description "local-board"
diff --git a/gdb/testsuite/boards/stabs.exp b/gdb/testsuite/boards/stabs.exp
index cbf34d2..57de1e6 100644
--- a/gdb/testsuite/boards/stabs.exp
+++ b/gdb/testsuite/boards/stabs.exp
@@ -39,7 +39,5 @@ set_board_info compiler "[find_gcc]"
# Use -gstabs+ instead of -gstabs for better c++ support.
set_board_info debug_flags "-gstabs+"
-# This is needed otherwise dejagnu tries to rsh to host "stabs". Blech.
-# Double blech: set_board_info only sets the value if not already set.
-unset_board_info isremote
-set_board_info isremote 0
+# This is needed otherwise dejagnu tries to rsh to host "stabs".
+load_board_description "local-board"
--
2.7.4
next reply other threads:[~2017-11-30 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 16:35 Simon Marchi [this message]
2017-11-30 16:37 ` Pedro Alves
2017-11-30 16:41 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512059694-18986-1-git-send-email-simon.marchi@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox