From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122702 invoked by alias); 22 Nov 2017 16:41:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121371 invoked by uid 89); 22 Nov 2017 16:41:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD autolearn=ham version=3.3.2 spammy=poisoned, Hx-spam-relays-external:Unknown_Domain, H*RU:Unknown_Domain, xfree X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Nov 2017 16:41:43 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id CA.23.19528.4C8A51A5; Wed, 22 Nov 2017 17:41:41 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 22 Nov 2017 17:41:40 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from elxacz23q12.ericsson.se (129.192.64.65) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.2; Wed, 22 Nov 2017 16:41:32 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 0/4] Poison XNEW and friends for non-POD types Date: Wed, 22 Nov 2017 16:41:00 -0000 Message-ID: <1511368867-19365-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MWHPR17CA0061.namprd17.prod.outlook.com (2603:10b6:300:93::23) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a0cabdc-6b55-4390-7223-08d531c7e569 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600022)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;3:zV8kYqzXogLsSyzSdrw7Hif69jtC//3V9Sf594ANw8cGsYbeEJq+kpkfRzn2o46467DccrfcD25UFHsZ8wZvZDSF0ztUa9MFImsD3lYiJjwFOC/pWhlfAXmhJPEmn8VA3D2Jiz0+xk5iUQcrRff4rH1g1H03MM2dDJfvF+uUdp419MJ0KQ07J3naAgnQDY9UOx1DMF/Qi2tQIWbT9gR7KZbWTcmTt409C3f/Ks9la6Qp/veKwceOTnZ4RLc97J/H;25:t3ygzLY/bUWUAg5S9UHHrDOjgLjYlKrlRWBs89kfOTG3GN6Q8TbxTYxYKbJ/upScX6ZBLlzhpT2kCqmu9baYoDyQrxE4MK/+otrct7qhrMfv53dLT2M34jNNp8SD3xdca7uNPOBSpljYli6jviS77nFXbDGubxTUjo1+tGqYq4yHRB5Je9whrngcbagjOcCC18/aJ5WpxDoqh2Fkaql7ZzE8h/R70XBr180XqYLafhu/1Jf9+x4IScu1fpgNzs7CJG+mk5G6RZwQRPN31dnYoL+lk/1i3mQnbBRP394Jr75flyORaxMSlkq4YrGWsSrKg7+TOsPWfaJfY8k6dij/5bWujqj3TdSUl8m70BA4tVg=;31:31tU1QQG2cUD/y5u95gskFsH+/wUjE16guJ0WMNUaUWEsX5/+1wZZnO4N8XSnJZFpzVcrQSJ7hi7wkw/4Iqt892cLhXTl3Pi+yeuyvWYJmFp/EPdb24KYAlONkDJDfF08cDhp8W7Nl2+LJn10hvPOMKAu1TX5AvSPPzQirbsztfqkOWOP44ir+3HhS47DTvOIijt2xQSI3JfBAhO12u7nkqFEzllWkr/yR9BPmljuDM= X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;20:5M3w9Ino0iJ32KnkHtdi057FpQAvYuuTaP53SfI25KPSwFvgaF202LOqSi2YlFlQ3HZ6HtRPHzaiSdPKMCCRHmyKWuFso+d8I6kdK0C3Vh9EWPfSBML+6Wl4qyIv2ggdFl0r4bbsCBAPo7Zc+rDPxsW5uVazehzAYx17ZeTgIJJwjHR+AyRB5JbKiKkaHNeRJu4eb2Kx8lO8Bxd62Z/OZFXSooTvjfoHVwq8FB59pD4LZECJUf6UOtMkt8WsmUTGWv1TlQHPcOoOY9yzC/zwQJKAeYU/T2BnR5vAbLrtLxGRvW/4Ac+t4TTQZ1o1H9fMacXzzWDBU/3mWpINcvUmeT/ZGL6D5p80GCqP89Sj+prr/e7mtm1q97eh7p4ZRSAH4zxnN+xjPT/UdpYspsf4B6Rz5jKX6yQGGzyfJ9Ov+s7yNOSDsZlJHX9fpXXeb92QQCJZxmsiAa7Pm3cf2vksOjVFek5VZhIELiPSdso6rANASnXCodrlk7zROtXk6W5a;4:Gk0MCSlBMVJeoKMQzVh6Tt6cw2FJ/gePX0uIU0uMcIK63HP6tFWgPELTA70tLWPG3uGJLfwD4p63SGjOFYYMOoyT6HVm2EuB2oSv+Uw5CZU7LHabV+EoZQcNgo6ZPRyBhd4u8lJ3PGZus1Ya4uSzNZeK1iWdHDi5z4RMm5SpZLRjjbuSR0e54a3Ga05ooMQnp+ZZ54fjc90CIcb+brwn0mbsYz1I4t75/2hom1QhD95EQG7RlB8DmQzMN1bovtgK2chlSEWkIK7aOyVUzhWXBA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(3231022)(93006095)(93001095)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB312;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB312; X-Forefront-PRVS: 0499DAF22A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(39860400002)(199003)(189002)(4326008)(2351001)(81166006)(97736004)(2361001)(5660300001)(25786009)(7736002)(106356001)(2870700001)(50466002)(66066001)(23676004)(189998001)(50226002)(33646002)(68736007)(305945005)(101416001)(16526018)(8676002)(36756003)(107886003)(53936002)(6512007)(316002)(69596002)(81156014)(53416004)(6506006)(6116002)(6486002)(2906002)(50986999)(47776003)(105586002)(86362001)(478600001)(6916009)(8936002)(3846002)(6666003);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB312;H:elxacz23q12.ericsson.se;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTI7MjM6eSsxOS9CM0huZ2VSdzJtM1djT01kSnJzdVVX?= =?utf-8?B?cVlHRWhNNlpRRktpVUczOVdhSHpvcWRiYThES3RDRTcyb0xtTjFlS2ppYUc3?= =?utf-8?B?WVhMSk5UUFlkbitkSnJJOGQyUFNGZERQNmVBN0VnN1hxc3ZoM0F5ZlhPdEpR?= =?utf-8?B?R0l3U21Ha3U2TUNXSVZkSC9lME9oOVdZc1lmQmpLWkZtVWp3Q0Q4TkpBRXcz?= =?utf-8?B?eEN2S0xncTVvYy9Ha2tTK1Ruc2haeXNjcDRKME13OHJ3cGh5TkcrK2Z6TjZC?= =?utf-8?B?a1ErbGIwSVpJbVB0TlQ0NTZhRFdyUWQzQjlKdWxOaC9CcFJZSThBMzJaaDc0?= =?utf-8?B?TUVDMFhRMXJKemIyb0J1akdJTVNzNDJocnpyaE84bTNIZlZpN1NFVXI4WkpX?= =?utf-8?B?RU82S21GVm9FNEtFSEFSbUQzVFJOaVpWUVl0TFl5MVlkVXUxMFdaNVczdERL?= =?utf-8?B?a2IyZ3lyOEUrMUlZdmdMaHNSYmVqTEV6cmRFTWxCa29vOHI2Y1VuVjdHeFFl?= =?utf-8?B?TzE1SExhbWM3alRqOVcwRTBtVkFUbktzWnM0UFg1WGxuOWx2K1VUVkFQUkpP?= =?utf-8?B?MC9waW1zUjFKYTIrZThKTldhdTZKQjJ6RGxEb2NtbThxQXhtMzNiMDl1cTNu?= =?utf-8?B?dldFaXFzL0Q1T0lLc0hwRzE4bjN5T2FjVk9qWllGb01NQ2V5eUdkRXBQdWFJ?= =?utf-8?B?a0xQVzI5eS9yeGlvQmFhbThSY0crU0NHK0lnUTd4dXlmRS90UVFhc1Nkc29Q?= =?utf-8?B?dGQ1UGtpNHpSWWp5Z3d3U0xTektaUm1WbmIxQjFMQm15YWlhQitSaGdNUWhL?= =?utf-8?B?THlCSEp6WTFDeGpqNU5ENDE4Qk1sNDdIUTdLdW53bW40MHVrZU1CYzc3NDBz?= =?utf-8?B?NGlRUHh6Qy8xL3NMYXFSUFVtSmhWenNBazUrb2tzYlBROHJzTkQ1Z1B1b1lD?= =?utf-8?B?VCtsY081SUdTNmlma3VjZ29ZeHphWU56M1E3bU1yNEsvdUtRNU9Bc0FqR0Uw?= =?utf-8?B?blQ2akd0WVJYYnhkUVdsRHVNY29lOEZTbXNpaHRaZ0RzRE1VRkdLVzl0R0Fp?= =?utf-8?B?UVJqTVV4UVc3aENxV0EwQ2RZdFNzMFA5ZnorakJJRlROcHNXVG9STGpSbExl?= =?utf-8?B?WDM4VElyeFlNczVUOWhQUFRISCsvTE5CM0hId2JPUFFJSDBtTzQ3RGZoL29u?= =?utf-8?B?dnJTSGd3VnNkcndyTEZxa0diNDlOZXpHKzFXb1NvOWVaZk1LbWpQUEJUeG1J?= =?utf-8?B?NlUvSllzbHR3ZitmSnJWa3JSSVVTNVRhckJkeDk2b1dLU1ZxYTZoOE1NazBa?= =?utf-8?B?Uk1IQVB6dWpDMlMybGE0cE80UUdpdjFiWEZYa2ZodGI0TDVHY2YxZ0VKRHVQ?= =?utf-8?B?Y29Xc1ZCaUtiRXpsMmhKMklqbG80cW04aVZwSlpCVjhIbUprODlRRUMxV2VH?= =?utf-8?B?eTJTQnNhNGVkbFplRzVuU3d0aDVDYVJaOEF5NTk3RXI0ZXozWGpiOUo1eGVK?= =?utf-8?Q?VdCgF+DgVuYg7//m5qW57gYo=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;6:xueDtgg0YN4IzYyqLNF5MT1Cn0ek1hqZuMrdLtqaCUQXoZ74fp9Koi0Y0L5xf9FzErNtuibquXyM07Yoe3Chxk33mYaWRfR/QkI2KC1TD7JVPQHP8n2TOYDSAyodsvG1aNkIR4czX1ePOtwr3Vcbr6G3w3zo6RgjvvFDEf5xEVC8wdtxQd2SGhVvGErPNMtj6qIkkIqifHrsUkyPUUW/jrhyBbQW8LHYleYazLbhSBHfG4U5zcEoSNBpxmAC7ZUBLDmONoa9Fx/ZSp5t8LUAUmkxEqtoWje9H/le8GjUjXoB9uilvWHRo4Zjtoi6uUR/V4s+2af2XnEl2+hpcp706bWJCjujZb/2alGZ9Z/zz38=;5:tC2X5NFQ0/98CT9UjfJlctgaaQjlkK8mhDd0MO89hAssp9ViUOlNtSu8ynlJywuiag4FkGlgXedmMqcJ4YZjL8g32M9QncT4GYoKg72sM10S+j/p3VVdZ6/68fbcTfgC/BCTsgN/BCTEAE4NQzSqcuwB2Q0avSglyB5vHltk6pk=;24:j0RcespMS2ROKo3fw/FQebliG2/1g36HYAAfASr7vcsJaAjxMKwjhkIs9DbE2fGPUh5uHUVEy/L8IvprFYF8ygSWFCqv6PzyqYIN2FdkldQ=;7:IWlTWIZeQ+gtj+ywvNl8MyFtjwF1p5RK0VOchYPmZZL8W1bZQmnivCz1xsnIhp1Mw2qTTRl++o+IY5Gd7bfzyO1CTuqnUY0+9TBGz3NjY3dZID0JK/jo+1r08buaGmbC4C+7+I7LI/CzQwemDmUKhzdI483sBI4SVhTMLDW0HUhXRux8jWSXT31wiUjcse7tm5xhpXmiUyyuRVeCh1TsuPC/yK8WlOX8uoTP494QhKSd1RXOKvRq6KAFwvnM3Fae SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2017 16:41:32.5407 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a0cabdc-6b55-4390-7223-08d531c7e569 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00499.txt.bz2 As we convert types to C++, one easy mistake to do is forget to change a XNEW(T) to new T. This patch helps ensure that we don't use XNEW (or similar) with types that require using new. xfree is also "poisoned" the same way. The first three patches fix the last things that were in the way of doing this change, and patch 4 adds the actual poisoning. Simon Marchi (4): Create private_inferior class hierarchy remote: C++ify thread_item and threads_listing_context Create private_thread_info hierarchy Poison XNEW and friends for types that should use new/delete gdb/Makefile.in | 2 + gdb/aix-thread.c | 49 +++--- gdb/common/common-utils.c | 7 - gdb/common/common-utils.h | 14 +- gdb/common/poison.h | 132 +++++++++++++++ gdb/common/rsp-low.c | 13 ++ gdb/common/rsp-low.h | 6 + gdb/darwin-nat-info.c | 50 +++--- gdb/darwin-nat.c | 297 ++++++++++++++++++---------------- gdb/darwin-nat.h | 35 ++-- gdb/gdbthread.h | 18 ++- gdb/inferior.c | 4 +- gdb/inferior.h | 9 +- gdb/linux-thread-db.c | 41 ++--- gdb/nto-procfs.c | 30 +--- gdb/nto-tdep.c | 10 +- gdb/nto-tdep.h | 10 +- gdb/remote.c | 329 ++++++++++++++++---------------------- gdb/thread.c | 14 +- gdb/unittests/rsp-low-selftests.c | 59 +++++++ 20 files changed, 654 insertions(+), 475 deletions(-) create mode 100644 gdb/unittests/rsp-low-selftests.c -- 2.7.4