From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] [testsuite] Pass -lpthread in libs
Date: Fri, 17 Nov 2017 15:22:00 -0000 [thread overview]
Message-ID: <1510932166-11816-1-git-send-email-yao.qi@linaro.org> (raw)
"libs" is the right flag to pass a library to a linker, instead of
additional_flags. Without this patch, the test case can't be complied
by clang.
gdb compile failed, clang: warning: -lpthread: 'linker' input unused
gdb/testsuite:
2017-11-17 Yao Qi <yao.qi@linaro.org>
* gdb.base/info-os.exp: Pass -lpthread in libs.
* gdb.multi/multi-attach.exp: Likewise.
---
gdb/testsuite/gdb.base/info-os.exp | 2 +-
gdb/testsuite/gdb.multi/multi-attach.exp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/testsuite/gdb.base/info-os.exp b/gdb/testsuite/gdb.base/info-os.exp
index 574da26..b3109e1 100644
--- a/gdb/testsuite/gdb.base/info-os.exp
+++ b/gdb/testsuite/gdb.base/info-os.exp
@@ -28,7 +28,7 @@ if [gdb_skip_xml_test] then {
}
# Compile test program.
-if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-lpthread}] } {
+if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug libs=-lpthread}] } {
fail "cannot compile test program"
return -1
}
diff --git a/gdb/testsuite/gdb.multi/multi-attach.exp b/gdb/testsuite/gdb.multi/multi-attach.exp
index 9397f85..52acc91 100644
--- a/gdb/testsuite/gdb.multi/multi-attach.exp
+++ b/gdb/testsuite/gdb.multi/multi-attach.exp
@@ -23,7 +23,7 @@ if {![can_spawn_for_attach]} {
return 0
}
-if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug additional_flags=-lpthread}]} {
+if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug libs=-lpthread}]} {
return -1
}
--
1.9.1
next reply other threads:[~2017-11-17 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 15:22 Yao Qi [this message]
2017-11-17 16:54 ` Simon Marchi
2017-11-22 15:17 ` Yao Qi
2017-11-22 15:30 ` Simon Marchi
2017-11-22 16:52 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510932166-11816-1-git-send-email-yao.qi@linaro.org \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox