Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/3] Some terminal handling TCL
Date: Thu, 02 Nov 2017 15:12:00 -0000	[thread overview]
Message-ID: <1509635522-16945-1-git-send-email-palves@redhat.com> (raw)

In context of multi-target support, I've been messing around with
GDB's tty / job control handling, the 'terminal ours/inferior'
switching, etc, and staring at gdb/inflow.c a lot.  While
adjusting/extending this machinery, the fewer code paths / variants we
have to consider, the better.  Hence this precursor series.

Patch #1 removes support for the legacy termio and sgtty terminal
interfaces in favor of assuming termios.  I believe that no
gdb-supported system is actually using termio/sgtty today, and so I
believe that this is actually a no-op change.

Patch #2 removes really odd code that doesn't look like have any
reason to exist.

Patch #3 removes a small gdb abstraction over SIGTSTP that hasn't been
useful in decades.

Pedro Alves (3):
  Assume termios is available, remove support for termio and sgtty
  Don't set terminal flags twice in a row
  Eliminate STOP_SIGNAL, use SIGTSTP directly

 gdb/Makefile.in              |   9 +-
 gdb/common/gdb_termios.h     |  78 -------------
 gdb/common/job-control.c     |  23 ++--
 gdb/configure                |   3 +-
 gdb/configure.ac             |   3 +-
 gdb/event-top.c              |  26 ++---
 gdb/event-top.h              |  10 +-
 gdb/gdbserver/configure      |   2 +-
 gdb/gdbserver/configure.ac   |   2 +-
 gdb/gdbserver/remote-utils.c |  33 +-----
 gdb/inflow.c                 |  97 ++++------------
 gdb/inflow.h                 |  12 +-
 gdb/ser-base.c               |   8 --
 gdb/ser-base.h               |   3 -
 gdb/ser-event.c              |   1 -
 gdb/ser-go32.c               |  12 --
 gdb/ser-mingw.c              |   4 -
 gdb/ser-pipe.c               |   1 -
 gdb/ser-tcp.c                |   1 -
 gdb/ser-unix.c               | 264 +------------------------------------------
 gdb/serial.c                 |   8 --
 gdb/serial.h                 |  12 --
 gdb/top.c                    |   8 +-
 23 files changed, 63 insertions(+), 557 deletions(-)
 delete mode 100644 gdb/common/gdb_termios.h

-- 
2.5.5


             reply	other threads:[~2017-11-02 15:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 15:12 Pedro Alves [this message]
2017-11-02 15:12 ` [PATCH 1/3] Assume termios is available, remove support for termio and sgtty Pedro Alves
2017-11-02 18:54   ` Sergio Durigan Junior
2017-11-02 19:27     ` Pedro Alves
2017-11-02 19:32       ` Sergio Durigan Junior
2017-11-06 16:11         ` Pedro Alves
2017-11-06 16:31           ` [pushed] Don't check termio.h and sgtty.h in common/common.m4 either (Re: [PATCH 1/3] Assume termios is available, remove support for termio and sgtty) Pedro Alves
2017-11-02 15:12 ` [PATCH 3/3] Eliminate STOP_SIGNAL, use SIGTSTP directly Pedro Alves
2017-11-02 15:12 ` [PATCH 2/3] Don't set terminal flags twice in a row Pedro Alves
2017-11-02 18:34   ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509635522-16945-1-git-send-email-palves@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox