From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16308 invoked by alias); 23 Oct 2017 14:18:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16251 invoked by uid 89); 23 Oct 2017 14:18:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy=H*f:sk:1508768, H*i:sk:1508768, H*MI:sk:1508768 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Oct 2017 14:18:31 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F9664E02B for ; Mon, 23 Oct 2017 14:18:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4F9664E02B Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from cascais.lan (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CBAD57A1E2 for ; Mon, 23 Oct 2017 14:18:29 +0000 (UTC) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 2/6] Fix unstable test names in gdb.base/startup-with-shell.exp Date: Mon, 23 Oct 2017 14:18:00 -0000 Message-Id: <1508768307-11531-3-git-send-email-palves@redhat.com> In-Reply-To: <1508768307-11531-1-git-send-email-palves@redhat.com> References: <1508768307-11531-1-git-send-email-palves@redhat.com> X-SW-Source: 2017-10/txt/msg00721.txt.bz2 Currently, if you diff testsuite/gdb.sum of two builds in different directories you see these spurious hunks: -PASS: gdb.base/startup-with-shell.exp: touch /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-extension +PASS: gdb.base/startup-with-shell.exp: touch /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-extension -PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension +PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension -PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args /home/pedro/gdb1/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension +PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args /home/pedro/gdb2/build/gdb/testsuite/outputs/gdb.base/startup-with-shell/*.unique-extension Since the run_args arguments are already shown in the test prefix, we can change the "set args" test name to literally "set args $run_args". I.e., after this commit we'll show: PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: set args $run_args PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = *.unique-extension: set args $run_args PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = $TEST: set args $run_args PASS: gdb.base/startup-with-shell.exp: startup_with_shell = off; run_args = $TEST: set args $run_args gdb/testsuite/ChangeLog: yyyy-mm-dd Pedro Alves * gdb.base/startup-with-shell.exp ('touch $unique_file): Don't include the unstable output directory name in the test's name. (initial_setup_simple) <'set args'>: Use custom test name. --- gdb/testsuite/gdb.base/startup-with-shell.exp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp b/gdb/testsuite/gdb.base/startup-with-shell.exp index af06c88..29a4ec5 100644 --- a/gdb/testsuite/gdb.base/startup-with-shell.exp +++ b/gdb/testsuite/gdb.base/startup-with-shell.exp @@ -37,7 +37,9 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { set unique_file [standard_output_file "unique-file.unique-extension"] set unique_file_dir [standard_output_file ""] -run_on_host "touch $unique_file" "touch" "$unique_file" +run_on_host \ + "touch OUTPUT_DIR/unique-file.unique-extension" \ + "touch" "$unique_file" # Initial setup for simple test (wildcard expansion, variable substitution). @@ -48,7 +50,8 @@ proc initial_setup_simple { startup_with_shell run_args } { gdb_test_no_output "set startup-with-shell $startup_with_shell" - gdb_test_no_output "set args $run_args" + gdb_test_no_output "set args $run_args" \ + "set args \$run_args" set test "inferior started" if { [runto_main] } { -- 2.5.5