From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15429 invoked by alias); 23 Oct 2017 14:18:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15376 invoked by uid 89); 23 Oct 2017 14:18:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:1508768, H*i:sk:1508768, unstable, H*MI:sk:1508768 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Oct 2017 14:18:30 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7250ECD160 for ; Mon, 23 Oct 2017 14:18:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7250ECD160 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from cascais.lan (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 015AB7A1E2 for ; Mon, 23 Oct 2017 14:18:28 +0000 (UTC) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 1/6] Fix unstable test names in gdb.arch/arc-tdesc-cpu.exp Date: Mon, 23 Oct 2017 14:18:00 -0000 Message-Id: <1508768307-11531-2-git-send-email-palves@redhat.com> In-Reply-To: <1508768307-11531-1-git-send-email-palves@redhat.com> References: <1508768307-11531-1-git-send-email-palves@redhat.com> X-SW-Source: 2017-10/txt/msg00720.txt.bz2 Currently if you diff testsuite/gdb.sum of two builds built from different source trees you see this spurious hunk: -PASS: gdb.arch/arc-tdesc-cpu.exp: set tdesc filename /home/pedro/gdb1/src/gdb/testsuite/gdb.arch/arc-tdesc-cpu.xml +PASS: gdb.arch/arc-tdesc-cpu.exp: set tdesc filename /home/pedro/gdb2/src/gdb/testsuite/gdb.arch/arc-tdesc-cpu.xml After this commit we'll show this instead in gdb.sum: PASS: gdb.arch/arc-tdesc-cpu.exp: set tdesc filename $srcdir/gdb.arch/arc-tdesc-cpu.xml gdb/testsuite/ChangeLog: yyyy-mm-dd Pedro Alves * gdb.arch/arc-tdesc-cpu.exp ('set tdesc filename'): Use gdb_test with explicit test name. --- gdb/testsuite/gdb.arch/arc-tdesc-cpu.exp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.arch/arc-tdesc-cpu.exp b/gdb/testsuite/gdb.arch/arc-tdesc-cpu.exp index f1c009d..13f677f 100644 --- a/gdb/testsuite/gdb.arch/arc-tdesc-cpu.exp +++ b/gdb/testsuite/gdb.arch/arc-tdesc-cpu.exp @@ -26,10 +26,10 @@ gdb_start # doesn't pass architecture from the target description directly to the # disassembler and instead uses one of the valid CPU names. -set filename $srcdir/$subdir/arc-tdesc-cpu.xml - -set cmd "set tdesc filename $filename" -gdb_test $cmd +gdb_test \ + "set tdesc filename $srcdir/$subdir/arc-tdesc-cpu.xml" \ + ".*" \ + "set tdesc filename \$srcdir/$subdir/arc-tdesc-cpu.xml" # An error message is emitted by the disassembler, therefore it is not shown # unless the disassembler is actually invoked. Address "0" is not invalid, -- 2.5.5