RE: [PATCH v3 3/6] Fortran: Ptype, print type extension.

Wiederhake, Tim
2017-08-24T12:36:13Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1887 bytes --]

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Yao Qi
> Sent: Wednesday, August 23, 2017 1:05 PM
> To: Wiederhake, Tim <tim.wiederhake@intel.com>
> Cc: gdb-patches@sourceware.org; Bernhard Heckel
> <bernhard.heckel@intel.com>
> Subject: Re: [PATCH v3 3/6] Fortran: Ptype, print type extension.
>
> Tim Wiederhake <tim.wiederhake@intel.com> writes:
>
> > +gdb_test_multiple $test %test {
>
> s/%test/$test
>
> > + -re "$output_pass\r\n$gdb_prompt $" {
> > + pass "$test"
> > + }
> > + -re "$output_xfail\r\n$gdb_prompt $" {
> > + xfail "gcc/49475"
> > + }
> > +}
> > set test "ptype wp%coo"
> > gdb_test_multiple "$test" "$test" {
> > -re "$real \\(3\\)\r\n$gdb_prompt $" {
> > @@ -80,11 +92,15 @@ gdb_test "p wp_vla(1)%point" " = \\( coo = \\(10,
> 12, 10\\) \\)"
> > gdb_test "p wp_vla(1)" " = \\( point = \\( coo = \\(10, 12, 10\\) \\),
> angle = 101 \\)"
> >
> > gdb_test "whatis wp_vla" "type = Type waypoint \\(3\\)"
> > -gdb_test "ptype wp_vla" \
> > - [multi_line "type = Type waypoint" \
> > - " Type point :: point" \
> > - " $real :: angle" \
> > - "End Type waypoint \\(3\\)"]
> > +set test "ptype wp_vla"
> > +gdb_test_multiple $test %test {
>
> Likewise.

Both applied locally.

> Patch is good to me.

Thanks!

Now #1 and #3 are OK'd;
#2, #4, #5, #6 still need review.

Regards,
Tim

>
> --
> Yao (é½å°§)
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
\x16º&Öéj×!zÊÞ¶êç×uïib²Ö«r\x18\x1dn–­r\x17¬