From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/2] Re-indent reread.exp
Date: Wed, 19 Jul 2017 11:28:00 -0000 [thread overview]
Message-ID: <1500463680-1483-2-git-send-email-yao.qi@linaro.org> (raw)
In-Reply-To: <1500463680-1483-1-git-send-email-yao.qi@linaro.org>
gdb/testsuite:
2017-07-18 Yao Qi <yao.qi@linaro.org>
* gdb.base/reread.exp: Re-indent the code.
---
gdb/testsuite/gdb.base/reread.exp | 160 +++++++++++++++++++-------------------
1 file changed, 81 insertions(+), 79 deletions(-)
diff --git a/gdb/testsuite/gdb.base/reread.exp b/gdb/testsuite/gdb.base/reread.exp
index 74bd20e..6c7cd70 100644
--- a/gdb/testsuite/gdb.base/reread.exp
+++ b/gdb/testsuite/gdb.base/reread.exp
@@ -20,112 +20,114 @@ foreach_with_prefix opts {
{ "" "" }
{ "-fPIE" "ldflags=-pie" } } {
-# build the first test case
+ # build the first test case
-set testfile1 "reread1"
-set srcfile1 ${testfile1}.c
-# Cygwin needs $EXEEXT.
-set binfile1 [standard_output_file ${testfile1}$EXEEXT]
+ set testfile1 "reread1"
+ set srcfile1 ${testfile1}.c
+ # Cygwin needs $EXEEXT.
+ set binfile1 [standard_output_file ${testfile1}$EXEEXT]
-if { [gdb_compile "${srcdir}/${subdir}/${srcfile1}" "${binfile1}" executable [list debug nowarnings additional_flags=[lindex $opts 0] [lindex $opts 1]]] != "" } {
- untested "failed to compile first testcase"
- return -1
-}
+ if { [gdb_compile "${srcdir}/${subdir}/${srcfile1}" "${binfile1}" executable [list debug nowarnings additional_flags=[lindex $opts 0] [lindex $opts 1]]] != "" } {
+ untested "failed to compile first testcase"
+ return -1
+ }
-# build the second test case
+ # build the second test case
-set testfile2 "reread2"
-set srcfile2 ${testfile2}.c
-set binfile2 [standard_output_file ${testfile2}$EXEEXT]
+ set testfile2 "reread2"
+ set srcfile2 ${testfile2}.c
+ set binfile2 [standard_output_file ${testfile2}$EXEEXT]
-if { [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable [list debug nowarnings additional_flags=[lindex $opts 0] [lindex $opts 1]]] != ""
- && [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable [list debug nowarnings "additional_flags=-DNO_SECTIONS [lindex $opts 0]" [lindex $opts 1]]] != ""} {
- untested "failed to compile second testcase"
- return -1
-}
+ if { [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable [list debug nowarnings additional_flags=[lindex $opts 0] [lindex $opts 1]]] != ""
+ && [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable [list debug nowarnings "additional_flags=-DNO_SECTIONS [lindex $opts 0]" [lindex $opts 1]]] != ""} {
+ untested "failed to compile second testcase"
+ return -1
+ }
-# Start with a fresh gdb.
+ # Start with a fresh gdb.
-set testfile "reread"
-set binfile [standard_output_file ${testfile}$EXEEXT]
+ set testfile "reread"
+ set binfile [standard_output_file ${testfile}$EXEEXT]
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
+ gdb_start
+ gdb_reinitialize_dir $srcdir/$subdir
-# Load the first executable.
+ # Load the first executable.
-gdb_rename_execfile ${binfile1} ${binfile}
-gdb_load ${binfile}
+ gdb_rename_execfile ${binfile1} ${binfile}
+ gdb_load ${binfile}
-# Set a breakpoint at foo
+ # Set a breakpoint at foo
-gdb_test "break foo" \
- "Breakpoint.*at.* file .*$srcfile1, line 14.*" \
- "breakpoint foo in first file"
+ gdb_test "break foo" \
+ "Breakpoint.*at.* file .*$srcfile1, line 14.*" \
+ "breakpoint foo in first file"
-# Run, should see "Breakpoint 1, foo () at hello1.c:14"
+ # Run, should see "Breakpoint 1, foo () at hello1.c:14"
-gdb_run_cmd
-gdb_test "" "Breakpoint.* foo .* at .*$srcfile1:14.*" "run to foo()"
+ gdb_run_cmd
+ gdb_test "" "Breakpoint.* foo .* at .*$srcfile1:14.*" "run to foo()"
-# Restore first executable to its original name, and move
-# second executable into its place. Ensure that the new
-# executable is at least a second newer than the old.
+ # Restore first executable to its original name, and move
+ # second executable into its place. Ensure that the new
+ # executable is at least a second newer than the old.
-gdb_rename_execfile ${binfile} ${binfile1}
-gdb_rename_execfile ${binfile2} ${binfile}
-gdb_test "shell sleep 1" ".*" ""
-gdb_touch_execfile ${binfile}
+ gdb_rename_execfile ${binfile} ${binfile1}
+ gdb_rename_execfile ${binfile2} ${binfile}
+ gdb_test "shell sleep 1" ".*" ""
+ gdb_touch_execfile ${binfile}
-# Run a second time; GDB should detect that the executable has changed
-# and reset the breakpoints correctly.
-# Should see "Breakpoint 1, foo () at reread2.c:9"
+ # Run a second time; GDB should detect that the executable has changed
+ # and reset the breakpoints correctly.
+ # Should see "Breakpoint 1, foo () at reread2.c:9"
-set test "run to foo() second time"
-if [is_remote target] {
- unsupported $test
-} else {
- gdb_run_cmd
- gdb_test "" "Breakpoint.* foo .* at .*:9.*" $test
-}
+ set test "run to foo() second time"
+ if [is_remote target] {
+ unsupported $test
+ } else {
+ gdb_run_cmd
+ gdb_test "" "Breakpoint.* foo .* at .*:9.*" $test
+ }
-### Second pass: verify that GDB checks the executable file's
-### timestamp when the program is *restarted*, not just when it exits.
+ ### Second pass: verify that GDB checks the executable file's
+ ### timestamp when the program is *restarted*, not just when it exits.
-if [is_remote target] {
- unsupported "second pass: GDB should check for changes before running"
-} else {
+ if [is_remote target] {
+ unsupported "second pass: GDB should check for changes before running"
+ } else {
- # Put the older executable back in place.
- gdb_rename_execfile ${binfile} ${binfile2}
- gdb_rename_execfile ${binfile1} ${binfile}
+ # Put the older executable back in place.
+ gdb_rename_execfile ${binfile} ${binfile2}
+ gdb_rename_execfile ${binfile1} ${binfile}
- # Restart GDB entirely.
- clean_restart ${binfile}
+ # Restart GDB entirely.
+ clean_restart ${binfile}
- # Set a breakpoint on foo and run to it.
- gdb_test "break foo" \
- "Breakpoint.*at.* file .*$srcfile1, line 14.*" \
- "second pass: breakpoint foo in first file"
- gdb_run_cmd
- gdb_test "" "Breakpoint.* foo .* at .*$srcfile1:14.*" "second pass: run to foo()"
+ # Set a breakpoint on foo and run to it.
+ gdb_test "break foo" \
+ "Breakpoint.*at.* file .*$srcfile1, line 14.*" \
+ "second pass: breakpoint foo in first file"
+ gdb_run_cmd
+ gdb_test "" "Breakpoint.* foo .* at .*$srcfile1:14.*" \
+ "second pass: run to foo()"
- # This time, let the program run to completion. If GDB checks the
- # executable file's timestamp now, it won't notice any change.
- gdb_continue_to_end "second pass"
-
- # Now move the newer executable into place, and re-run. GDB
- # should still notice that the executable file has changed,
- # and still re-set the breakpoint appropriately.
- gdb_rename_execfile ${binfile} ${binfile1}
- gdb_rename_execfile ${binfile2} ${binfile}
- gdb_run_cmd
- gdb_test "" "Breakpoint.* foo .* at .*:9.*" "second pass: run to foo() second time"
-}
+ # This time, let the program run to completion. If GDB checks the
+ # executable file's timestamp now, it won't notice any change.
+ gdb_continue_to_end "second pass"
-}
+ # Now move the newer executable into place, and re-run. GDB
+ # should still notice that the executable file has changed,
+ # and still re-set the breakpoint appropriately.
+ gdb_rename_execfile ${binfile} ${binfile1}
+ gdb_rename_execfile ${binfile2} ${binfile}
+ gdb_run_cmd
+ gdb_test "" "Breakpoint.* foo .* at .*:9.*" \
+ "second pass: run to foo() second time"
+ }
+
+ }
# End of tests.
return 0
--
1.9.1
next prev parent reply other threads:[~2017-07-19 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 11:28 [PATCH 1/2] Catch exceptions thrown from gdbarch_skip_prologue Yao Qi
2017-07-19 11:28 ` Yao Qi [this message]
2017-07-21 21:57 ` Simon Marchi
2017-07-25 10:38 ` Yao Qi
2017-07-25 10:59 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500463680-1483-2-git-send-email-yao.qi@linaro.org \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox