From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113976 invoked by alias); 23 Nov 2016 13:03:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113953 invoked by uid 89); 23 Nov 2016 13:03:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=D*ericsson.com X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Nov 2016 13:03:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6EF0AC04B94E; Wed, 23 Nov 2016 13:03:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAND3NuS013026; Wed, 23 Nov 2016 08:03:23 -0500 Subject: Re: [PATCH 1/3] Remove unused parameter in solib_add and update_solib_list To: Marc-Andre Laperle , gdb-patches@sourceware.org References: <1473712054-30417-1-git-send-email-marc-andre.laperle@ericsson.com> From: Pedro Alves Message-ID: <14aff47e-e1f6-ca02-0150-a1a0c326bc0b@redhat.com> Date: Wed, 23 Nov 2016 13:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1473712054-30417-1-git-send-email-marc-andre.laperle@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00667.txt.bz2 Hi Marc-Andre, On 09/12/2016 09:27 PM, Marc-Andre Laperle wrote: > The target parameter in both solib_add and update_solib_list > functions is not used anymore and as not been used for a while. This > change removes the parameter to clean up the code a little bit. > > gdb/ChangeLog: > > * infcmd.c (post_create_inferior): Remove unused argument in > call to solib_add. > * remote.c (remote_start_remote): Likewise. > * solib-frv.c (frv_fetch_objfile_link_map): Likewise. > * solib-svr4.c: (svr4_fetch_objfile_link_map): Likewise. > (enable_break): Likewise. > * solib.c (update_solib_list): Remove unused target argument > and its documentation. > (solib_add): Remove unused target argument. Remove unused > argument in call to update_solib_list. > (info_sharedlibrary_command): Remove unused argument in call > to update_solib_list. > (sharedlibrary_command): Remove unused argument in call to > solib_add. > (handle_solib_event): Likewise. > (reload_shared_libraries): Likewise. > * solib.h (solib_add): Remove unused target argument. > > Signed-off-by: Marc-Andre Laperle OK. Thanks, Pedro Alves