From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by sourceware.org (Postfix) with ESMTPS id 066FF386F465 for ; Fri, 26 Jun 2020 13:19:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 066FF386F465 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f66.google.com with SMTP id z13so9493822wrw.5 for ; Fri, 26 Jun 2020 06:19:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lRWe7jwbUDa3oBVM5vzKZKmrJMdjiCsX/0HCUN0R+Z0=; b=FPX3PZBTFG3pHh5QqvCL+UnpYRwqAESB+88AIM0ietv7YXxfA2QiMR+/J3q7eBDpWz VCuxUJrqT4omjIkjlRCVZd4GlzhN1lkS2vYYF0qM/vEt6xMbiFv56UVyf+eiEDBeA/hh DejV0ODViPnOqUHno6dxyb4vQ6wVD/fWVBLLzufMhOjcvuifcde/UKHyqZ3QU1mkbzwp LeCG6a9rsk0e1l5dfln7AfL/rz93U2z4b0yVqsldx/JOeRj7FOEu9Eixr5uAR65o0avF fFO2TpodPBwKSk0zNUYXdJOQ3IH7gFwUV3PVnSbTpzvd1g0BO/ARPSAarRIo2pEMbubM ijHQ== X-Gm-Message-State: AOAM532XNQJJ3KQllmyVbj1WBYQR2rocxpz7ccsew1pRv1OE2vnOueB6 orYjxPVn0BjG48t3c+h+tM7vVT0moPweOQ== X-Google-Smtp-Source: ABdhPJzAMnHsnsh7i1ifjTckytc25H3yFrd9wJFG9ZoTSfcqOutbzzlf7QYh49q2Tug41XQce1lE4A== X-Received: by 2002:adf:dd83:: with SMTP id x3mr4088693wrl.292.1593177566578; Fri, 26 Jun 2020 06:19:26 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id q4sm16883443wmc.1.2020.06.26.06.19.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jun 2020 06:19:25 -0700 (PDT) Subject: Re: [PATCH v2] Fix -Wstring-compare testcase build failure To: Gary Benson , gdb-patches@sourceware.org References: <1593176700-16489-1-git-send-email-gbenson@redhat.com> From: Pedro Alves Message-ID: <14a03347-e8fe-b642-36b2-ff74ae17c618@palves.net> Date: Fri, 26 Jun 2020 14:19:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1593176700-16489-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2020 13:19:29 -0000 On 6/26/20 2:05 PM, Gary Benson wrote: > diff --git a/gdb/testsuite/gdb.cp/try_catch.exp b/gdb/testsuite/gdb.cp/try_catch.exp > index fb53294..e4da885 100644 > --- a/gdb/testsuite/gdb.cp/try_catch.exp > +++ b/gdb/testsuite/gdb.cp/try_catch.exp > @@ -63,5 +63,8 @@ gdb_continue_to_breakpoint "marker 3-throw" > gdb_breakpoint [gdb_get_line_number "marker 3-catch"] > gdb_continue_to_breakpoint "marker 3-catch" > > +gdb_breakpoint [gdb_get_line_number "marker test-complete"] > +gdb_test "p test" "= true" > + You need to continue the program to the breakpoint too. I.e., you're missing a gdb_continue_to_breakpoint "marker test-complete" line. OK with that change. Thanks, Pedro Alves