From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33593 invoked by alias); 12 Apr 2016 08:02:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33574 invoked by uid 89); 12 Apr 2016 08:02:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:209.85.220.65, H*RU:209.85.220.65, H*c:MHil, HX-Received:10.66.66.108 X-HELO: mail-pa0-f65.google.com Received: from mail-pa0-f65.google.com (HELO mail-pa0-f65.google.com) (209.85.220.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 12 Apr 2016 08:01:56 +0000 Received: by mail-pa0-f65.google.com with SMTP id zy2so879953pac.2 for ; Tue, 12 Apr 2016 01:01:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=3wfUSFK7sf0xF59FKbUO2YNftO48/9+665vUmQdPeVw=; b=HwOJrr5iFV228XSFJLHHaYjS+45uak4LX1NBUIeaXwMWCmKO9trTEjWy4z7Q+cnBYq wHHjWvmeI1+P7IB7uovdZ5mp4bCM/uY2GxP4qVJqds0QQgK/WoY+q6Bfn70/K5Nc82hu 9qnpCcfw4GxMT2WsEwsU5v8dDgGWWtPsYk3PPr9uuVVTW26xl4aecF5WpHJ99TDjouEl ljsoQfM/lidMv4G2baIN6lTrqpc+dYsilpp26DnxBN+jh4eN+Q4oHw9lvWPfexTYX+hs 0rMEoSQ+ZYN2zAARJHvTGEXWGuXgb36nak2avi3xqJ3oP+w+s9IEPyyIjR9fExy3N+Zz 94Hw== X-Gm-Message-State: AOPr4FVM1fVhFJyOF3BY7mGwRodWvaFNMSoGYbIOpsJgUkbN2fBXulYbs1NgTL911FvwbQ== X-Received: by 10.66.66.108 with SMTP id e12mr2766140pat.92.1460448114829; Tue, 12 Apr 2016 01:01:54 -0700 (PDT) Received: from [192.168.99.186] (elsi-gw.elsi.titech.ac.jp. [131.112.112.6]) by smtp.gmail.com with ESMTPSA id r88sm41277626pfi.9.2016.04.12.01.01.52 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Apr 2016 01:01:54 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_34C6271F-9918-44E2-BACB-DB3F79D98808"; protocol="application/pkcs7-signature"; micalg=sha1 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH v2] gdb: dwarf2read: implement handling of variables in Fortran common block From: G Helffrich In-Reply-To: <570C9D13.50307@intel.com> Date: Tue, 12 Apr 2016 08:02:00 -0000 Cc: gdb-patches@sourceware.org, Luis Machado Message-Id: <14BA18F0-9D4B-4E12-8C46-BD3B6A29DC9B@gmail.com> References: <13D2DB40-8745-4CF0-BA56-C88D4741610C@gmail.com> <570C9D13.50307@intel.com> To: "Heckel, Bernhard" X-SW-Source: 2016-04/txt/msg00238.txt.bz2 --Apple-Mail=_34C6271F-9918-44E2-BACB-DB3F79D98808 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 Content-length: 4192 Bernhard & Luis - Here is the dump of the analogous parts of the DWARF for my environment fo= r this testcase: 0x00000155: TAG_common_block [3] * AT_name( "fo_o" ) AT_decl_file( "gdb.fortran/common-block.f90" ) AT_decl_line( 31 ) AT_MIPS_linkage_name( "fo_o_" ) AT_location( [0x0000000000000000] ) AT_sibling( {0x000001b2} ) 0x00000171: TAG_variable [4]=20=20 AT_name( "ix" ) AT_decl_file( "gdb.fortran/common-block.f90" ) AT_decl_line( 23 ) AT_type( {0x00000230} ( integer(kind=3D4) ) ) AT_external( 0x01 ) AT_location( [0x0000000000000000] ) 0x00000186: TAG_variable [4]=20=20 AT_name( "iy2" ) AT_decl_file( "gdb.fortran/common-block.f90" ) AT_decl_line( 24 ) AT_type( {0x00000243} ( real(kind=3D4) ) ) AT_external( 0x01 ) AT_location( [0x0000000000000004] ) On 12 Apr 2016, at 16:00, Heckel, Bernhard wrot= e: > On 12/04/2016 02:31, G Helffrich wrote: >> This patch allows the gdb DWARF reader to handle variables located in Fo= rtran common blocks. This fixes 20 unexpected failures in the gdb.fortran = testsuite with host, target and build triplet x86_64-apple-darwin13.4.0 wit= h gfortran 4.9.2. >> Re-posted as requested with patch file attached. Revised from original = post to prevent double relocation. >> 2015-04-12 George Helffrich >>=20 >> * dwarf2read.c (read_common_block): Relocate symbols in Fortran = common >> blocks properly, and avoid double relocation. >> (read_new_symbol_full): Don't discard zero-offset symbols in F= ortran >> common blocks. >> (_initialize_dwarf2_read): Add debug diagnostic print for comm= on >> symbols. >> * psymtab.c (print_partial_symbols): Recognize and print >> COMMON_BLOCK_DOMAIN. >> * symmisc.c (print_symbol): Recognize and dump LOC_COMMON_BLOCK. >>=20 >>=20 > Hi George, Luis, >=20 > I manually patched last week and got 16 fails in the common block testcas= e. > Just adding a base-address to the variables lead to failing tests. > From what I have seen, all the child's of the common block have their own= fix (DW_OP_addr) location. > At least in my environment when I check the DWARF of the compiled testcas= e. >=20 > Here an excerpt of my DWARF > <2><4a>: Abbrev Number: 3 (DW_TAG_common_block) > <4b> DW_AT_name : (indirect string, offset: 0x0): fo_o > <4f> DW_AT_decl_file : 1 > <50> DW_AT_decl_line : 31 > <51> DW_AT_linkage_name: (indirect string, offset: 0x5): fo_o_ > <55> DW_AT_location : 9 byte block: 3 60 10 60 0 0 0 0 0 (DW_= OP_addr: 601060) > <5f> DW_AT_sibling : <0xa1> > <3><63>: Abbrev Number: 4 (DW_TAG_variable) > <64> DW_AT_name : ix > <67> DW_AT_decl_file : 1 > <68> DW_AT_decl_line : 23 > <69> DW_AT_type : <0x116> > <6d> DW_AT_external : 1 > <6d> DW_AT_location : 9 byte block: 3 60 10 60 0 0 0 0 0 (DW_= OP_addr: 601060) > <3><77>: Abbrev Number: 4 (DW_TAG_variable) > <78> DW_AT_name : iy2 > <7c> DW_AT_decl_file : 1 > <7d> DW_AT_decl_line : 24 > <7e> DW_AT_type : <0x11d> > <82> DW_AT_external : 1 > <82> DW_AT_location : 9 byte block: 3 64 10 60 0 0 0 0 0 (DW_= OP_addr: 601064) >=20 > May George can sent the important part of the DWARF >=20 >=20 > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Christian Lamprechter > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >=20 G Helffrich ghfbsd@gmail.com --Apple-Mail=_34C6271F-9918-44E2-BACB-DB3F79D98808 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 Content-length: 5499 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEH AQAAoIIMsDCCBeowggTSoAMCAQICEAC3TPlEwHJfbnGwcz7gtxcwDQYJKoZI hvcNAQELBQAwVjELMAkGA1UEBhMCQ0gxFTATBgNVBAoTDFN3aXNzU2lnbiBB RzEwMC4GA1UEAxMnU3dpc3NTaWduIFBlcnNvbmFsIFNpbHZlciBDQSAyMDE0 IC0gRzIyMB4XDTE1MDYxNzA4MzUwM1oXDTIwMDYxNzA4MzUwM1owQTEdMBsG A1UECxMURW1haWwgVmFsaWRhdGVkIE9ubHkxIDAeBgNVBAMUF0VtYWlsOiBn aGZic2RAZ21haWwuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKC AQEArCqbOzD1wrgSexsglbpShhaeYUNpWtWxO8unXBU+Zy4sjX8GbTehfG0f YbUWqD1AGzVtFXXcqP+tbb+Q5d8xXrYoX/TcwO53GgS1qY4LYCZRJNvme+mH GjngAiAOiq2tXewNuQjjlhi34n8MN4ODVG1gG7KpW1NXHNoQrQEv+0av88Ys u6iqzyvP9vbn6CLrZPKsGbujLfKKUT4Ak6JJ1sEmnbiAdglcki5NPxLceLOu sYzsajn9ufsKAHjgTVB0RyxquQqoNAjFwWBFrqKS1d5p0f3pWRbe8W6TPwmH IRD8gdHNFo2MH+4k8/cYsJBBdnkDEYpjRsrqk+b3Aug2LQIDAQABo4ICxzCC AsMwDgYDVR0PAQH/BAQDAgSwMBMGA1UdJQQMMAoGCCsGAQUFBwMEMB0GA1Ud DgQWBBT6UTfFqpyI1vK/VWUTTsKltQW7TjAfBgNVHSMEGDAWgBTwx6MykbXr yrVYdxWnTr4aXWFDJTCB/wYDVR0fBIH3MIH0MEegRaBDhkFodHRwOi8vY3Js LnN3aXNzc2lnbi5uZXQvRjBDN0EzMzI5MUI1RUJDQUI1NTg3NzE1QTc0RUJF MUE1RDYxNDMyNTCBqKCBpaCBooaBn2xkYXA6Ly9kaXJlY3Rvcnkuc3dpc3Nz aWduLm5ldC9DTj1GMEM3QTMzMjkxQjVFQkNBQjU1ODc3MTVBNzRFQkUxQTVE NjE0MzI1JTJDTz1Td2lzc1NpZ24lMkNDPUNIP2NlcnRpZmljYXRlUmV2b2Nh dGlvbkxpc3Q/YmFzZT9vYmplY3RDbGFzcz1jUkxEaXN0cmlidXRpb25Qb2lu dDBhBgNVHSAEWjBYMFYGCWCFdAFZAQMBBjBJMEcGCCsGAQUFBwIBFjtodHRw Oi8vcmVwb3NpdG9yeS5zd2lzc3NpZ24uY29tL1N3aXNzU2lnbi1TaWx2ZXIt Q1AtQ1BTLnBkZjCB2QYIKwYBBQUHAQEEgcwwgckwZAYIKwYBBQUHMAKGWGh0 dHA6Ly9zd2lzc3NpZ24ubmV0L2NnaS1iaW4vYXV0aG9yaXR5L2Rvd25sb2Fk L0YwQzdBMzMyOTFCNUVCQ0FCNTU4NzcxNUE3NEVCRTFBNUQ2MTQzMjUwYQYI KwYBBQUHMAGGVWh0dHA6Ly9zaWx2ZXItcGVyc29uYWwtZzIub2NzcC5zd2lz c3NpZ24ubmV0L0YwQzdBMzMyOTFCNUVCQ0FCNTU4NzcxNUE3NEVCRTFBNUQ2 MTQzMjUwGwYDVR0RBBQwEoEQZ2hmYnNkQGdtYWlsLmNvbTANBgkqhkiG9w0B AQsFAAOCAQEAUm7ncPoddC5SOIl/fv/g3fi9IloV1ElkR1NNbS5h6H+svqsD Eyr4GZkOnbw/Ydv7J5KUGl0yWw6o9KK9K8GyxgJ/RGqH/uwcuGEGmkbhbRpk G6TgzKqyjOgbJ1MBQO+UQehGtV5b77tB+eRzGQPIcMc6YTyJ7bXoS8B64voO 4o6nqBxXKLg1ks0d+7psr20cEhoDdnitbWYUh21FOgQ+d9wMLteOeixLVX2j cbFEpTSuNzxTs803RxdGntbRXW2QvUkxPSaRVYwHjLnyYfRc/tm0RFJnqhT5 wXkrPObIom1TkQ3AtWiINoogJcgWJ1d6GWh2DP9H2c22UuhU4FQC1DCCBr4w ggSmoAMCAQICDwVE1k6tHtM21TJAXQC5NjANBgkqhkiG9w0BAQsFADBHMQsw CQYDVQQGEwJDSDEVMBMGA1UEChMMU3dpc3NTaWduIEFHMSEwHwYDVQQDExhT d2lzc1NpZ24gU2lsdmVyIENBIC0gRzIwHhcNMTQwOTE5MjAzNjQ5WhcNMjkw OTE1MjAzNjQ5WjBWMQswCQYDVQQGEwJDSDEVMBMGA1UEChMMU3dpc3NTaWdu IEFHMTAwLgYDVQQDEydTd2lzc1NpZ24gUGVyc29uYWwgU2lsdmVyIENBIDIw MTQgLSBHMjIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDLObE5 hf76yaG8w4OpDkothHIe/2jFp8Qd7A/XqIsTHrPRFotA3A9TbwE97OhktZfb g7yoqMCEOFheAxQr5sow7wCy6xM5GZJHKiEA5XLNwjFiDsxWKv93xGOMmMJv eNe1tszpfR8zppEFKv7RUtb07Jz+TUxqUuGFdmK7uWjmUmP8wSGRkl0Z2NyA 0RnjSRZXAg4ZRIWrKckv+sZtawqh9vf/a2E1FSaUlAJpJV1p971ea4LZkAwG +UMFIknrNtAgWmMQ4zgh1X8WK0GKRnryZ+ik0LoefyQndZiUSS1WxFQzkZ1i +dVf3lupFZiclFPBgOkJFxW0G4ApMqHQrxOnAgMBAAGjggKWMIICkjAOBgNV HQ8BAf8EBAMCAQYwEgYDVR0TAQH/BAgwBgEB/wIBADAdBgNVHQ4EFgQU8Mej MpG168q1WHcVp06+Gl1hQyUwHwYDVR0jBBgwFoAUF6DNweRBtjpbO8tFnb0c wpj6hlgwgf8GA1UdHwSB9zCB9DBHoEWgQ4ZBaHR0cDovL2NybC5zd2lzc3Np Z24ubmV0LzE3QTBDREMxRTQ0MUI2M0E1QjNCQ0I0NTlEQkQxQ0MyOThGQTg2 NTgwgaiggaWggaKGgZ9sZGFwOi8vZGlyZWN0b3J5LnN3aXNzc2lnbi5uZXQv Q049MTdBMENEQzFFNDQxQjYzQTVCM0JDQjQ1OURCRDFDQzI5OEZBODY1OCUy Q089U3dpc3NTaWduJTJDQz1DSD9jZXJ0aWZpY2F0ZVJldm9jYXRpb25MaXN0 P2Jhc2U/b2JqZWN0Q2xhc3M9Y1JMRGlzdHJpYnV0aW9uUG9pbnQwYQYDVR0g BFowWDBWBglghXQBWQEDAQYwSTBHBggrBgEFBQcCARY7aHR0cDovL3JlcG9z aXRvcnkuc3dpc3NzaWduLmNvbS9Td2lzc1NpZ24tU2lsdmVyLUNQLUNQUy5w ZGYwgcYGCCsGAQUFBwEBBIG5MIG2MGQGCCsGAQUFBzAChlhodHRwOi8vc3dp c3NzaWduLm5ldC9jZ2ktYmluL2F1dGhvcml0eS9kb3dubG9hZC8xN0EwQ0RD MUU0NDFCNjNBNUIzQkNCNDU5REJEMUNDMjk4RkE4NjU4ME4GCCsGAQUFBzAB hkJodHRwOi8vb2NzcC5zd2lzc3NpZ24ubmV0LzE3QTBDREMxRTQ0MUI2M0E1 QjNCQ0I0NTlEQkQxQ0MyOThGQTg2NTgwDQYJKoZIhvcNAQELBQADggIBAMN5 p1e3e61RaPVEjEGVKAF8dNY7arxt76fXTTmZHWiNygjZ0HGxGTWTb4LGHEm4 Ue5M+WwKb9il+/77MF4A0pSrxBJRuqqKq2rdGdcrSvcWsmtRz3RbKaJz3pf+ 2E8gIX1pDLBQ5Y1YjIAu5Rcc3WN6qu8F+cNpnuSMcWJcQu468s3gEu+LXOnO Uygy7JULGVSiIY36f1CnT7wZe7JrjCk/dz7KI8dpWkGdfWYxb3pxedqpZTrr f9cQ1QtfVBl8zjclJIRQ0K9ANMJfkuJ6kfMvQkcbnzxC+9lfpbxwRY7voDmQ 9aF4bNfAZ1kZ4QDeXPx46E/du6yRLnKL/OpHb0MovLu5jpS++lDdUJMbTBi2 dv/DRwpZtM1tVdhqtl/JL8GUNj6+rkA1BiDt4AJMLTRFDkOvovTYkBXl0MCb RECuPI+TUbyZaHNpe3VYmbfUBE/f8YJxER17/BMdd2VVY9dScnzdMUeGp5XY rCZxPSPmEjv0f5qWhv4r6qDzJg11xhaMMSDnEUeh56lqsKWygR7cPdCh427V 8GamHH3XkohNAAcLcedz53PkVGVp/DeN8R5vcO6nbLNSRWdZ1gVIsSHplyjZ 2fS0pqBnIza8YEcOXCh/XZOKMbqNMTYUx3pCnW8gwWwq+BYPatkAlDK7PVWx xcOhDbF5d1Qd4DOCfu7qMYIC6jCCAuYCAQEwajBWMQswCQYDVQQGEwJDSDEV MBMGA1UEChMMU3dpc3NTaWduIEFHMTAwLgYDVQQDEydTd2lzc1NpZ24gUGVy c29uYWwgU2lsdmVyIENBIDIwMTQgLSBHMjICEAC3TPlEwHJfbnGwcz7gtxcw CQYFKw4DAhoFAKCCAVUwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkq hkiG9w0BCQUxDxcNMTYwNDEyMDgwMTUwWjAjBgkqhkiG9w0BCQQxFgQU+sTO cVxU9HOyUllFMIEs1BEcgtcweQYJKwYBBAGCNxAEMWwwajBWMQswCQYDVQQG EwJDSDEVMBMGA1UEChMMU3dpc3NTaWduIEFHMTAwLgYDVQQDEydTd2lzc1Np Z24gUGVyc29uYWwgU2lsdmVyIENBIDIwMTQgLSBHMjICEAC3TPlEwHJfbnGw cz7gtxcwewYLKoZIhvcNAQkQAgsxbKBqMFYxCzAJBgNVBAYTAkNIMRUwEwYD VQQKEwxTd2lzc1NpZ24gQUcxMDAuBgNVBAMTJ1N3aXNzU2lnbiBQZXJzb25h bCBTaWx2ZXIgQ0EgMjAxNCAtIEcyMgIQALdM+UTAcl9ucbBzPuC3FzANBgkq hkiG9w0BAQEFAASCAQA3MqDoOtC5AXl6LLZ9wKQTcBcCHg3iNk+LDtxksEe8 I5Yr36XZepOrRIuzl4ghWe8EUFWt3jwtVrQinSHZcnuplXc3Sv04o2nsFjpu Hms6dmArxMd/Te2WHqZTMaDqtKKCyp5I7ZJtScWbcpLlttg9fQVltEHeFlwc DqwIDytkkstU/xikvPPl66dQyrNPkrxgSshoT4AoC2zy4KCHYu+igdXDO3bu Y2J9PPxa4TbHeFi1JDtyvGrDykfCdX8svmz5XgZYCDPm4/j7z43+6/j79QC+ do40HhNvBBkQXRDGmeTZ14+NJ0qC+xY9o5Xq3kyUaooaF9rjVQgOorf076Q3 AAAAAAAA --Apple-Mail=_34C6271F-9918-44E2-BACB-DB3F79D98808--