From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96043 invoked by alias); 21 Jun 2017 20:15:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95045 invoked by uid 89); 21 Jun 2017 20:15:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Jun 2017 20:15:32 +0000 Received: from ESESSHC001.ericsson.se (Unknown_Domain [153.88.183.21]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 88.49.19050.DD3DA495; Wed, 21 Jun 2017 22:15:26 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.21) with Microsoft SMTP Server (TLS) id 14.3.339.0; Wed, 21 Jun 2017 22:15:24 +0200 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com; Received: from elxacz23q12.localdomain (80.216.243.234) by DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.6; Wed, 21 Jun 2017 20:15:19 +0000 From: Simon Marchi To: CC: Simon Marchi Subject: [PATCH 3/4] dtrace-probe: Put semicolon after while on its own line Date: Wed, 21 Jun 2017 20:15:00 -0000 Message-ID: <1498076108-29914-4-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> References: <1498076108-29914-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: HE1PR0802CA0016.eurprd08.prod.outlook.com (2603:10a6:3:bd::26) To DBXPR07MB320.eurprd07.prod.outlook.com (2a01:111:e400:941d::21) X-MS-Office365-Filtering-Correlation-Id: 3a4aa70b-38cc-4142-8335-08d4b8e23d8b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;3:thhOtFWwRk43c0aOOoc5JAlKrWiyd7N/hFvirq1n+zk/7RzcUbDw9uQECS52j+3V56PqjSEFZE/nGYE1aorrh0KiHCGI5G1JsA2xZVnLTTStSU8TufcnqO5v8vwV9uBRbpUHwOYDF0LDzsJ+PjKLqF7maGwjaEs6xv3c6KdEWoUP/IYtxBigAZRSOk8D7ATV6Q9RPg3ZVnpXwLUaaBTvLLhMgebfXgsatS3+WQs5BQEyqKgBQtRjLihyVnuZ8MohiL9vyPgoQ+y8qQ8H6gjn4ZUGH1+ZU59HrmmiCXkLKaR4fru5cIfHzhuf+FHcjh3CG8/mHUZLcE+o1YPRxEsDtg==;25:kUsqM+TNxGaYXnTKvHtpzVK+ec5eYvSgIBJLu32/Y7VhDm2OE6gVynhBbjfjHlSv/O8I5+llGpajumctrCQPT1OKBjOwvj02/1QyiU6sGIDjz4YJ0XTjS5f3kDS7cJylBDj20v/KMO5oZAhWyk7Ct3a7H1I9dsIKN+N+bESjfTFXk74a46Ja8tOr2uiiyMyP+j6F8mb5X5pND3NeL6dtuKrdxVBxJl0tXit08id1p+3/wuB6FXzkkT0VXhbT6clnMkxgXMsC+0TLcRmE8Mvh7n5wnr+Er42qoIxoXjk22lldOcQtC9MGlhJyMtidG2iozPyzhDMnDy6niIZuM9a1Cn82QT9XF7bQSAZKLZD11orS1qsThU97Oy5nu3+2uXAq70QTcYTbv4ba4E+b0hSQ1YziZ+lYLaNOpOCFvE6udj5coN/2QE/Rp6LCeL1M64INFCNTQFCf/3jm7UalKdXa54JMpLjsj5cpisbMBIcz7nk= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBXPR07MB320: X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;31:I+Cq6yoa6Q5ndzDR/wMR3sDAHJxxbnO3vW0Z8T+Vd6YyQ7VwM+12CkL/SIHjIwy7Sx0CEy+mwzMUA3LFlv7XLtunyoeYAqxpXOIQ//ukmLnwpHk8MzUxxhIjNiJ9mWO3T5JfXI79z/+sJ3PVdgswivNv3jryZFMDIq31W3CEbofTmY26ni8QOlYvu6taSpVcJh2g1Ew2VzU8HDSFNH4sDDfIS0IZ0g5ybdGWQzraWkE=;20:YDwLhjkR4IWxIdB8fXj4F+YKeuCpicbrw0PwBgLh19LBSn8aFO57oKsS0HCapGxoCEoIriPkXVoC+pRDY7taPKiXkND4Lv9RqMnFs5y60sKEjtoWvkoxiCSIAgqs8w6DqsEFqza3iBUa+AbW5sPLM+AwKPfCH/PNL3tXTpWGxzw2ZLRFqeVxSRWcUTUVcwi9K73CPEfslvcPlPcOIPlfOrGoGrG1E+7ZQPDY4RouyXOiAut6LnGKz6GJ91upAGwCudjxKc5wGSJOuR9AhThuthrCaievTc3m6lF4Ih0NIfQNYjIqJAKeVARUF+sIpQGKo96Tx4Wf5Bn8OtyK+ZlVK3lOc3ov9mQbRn0sBJD8XRTeUeSA1ENFZKxUZltuOCWQ1KYYaJpwxjhKiiJLSvubEDxMeMUXoXblENAAdJpi3tTEfzm3VL5D2alIK/4aGlfCSEXueHHnfzxqETdgBsI11q35zvOK/adydjStnbCl9rNnhwcv+Q/QGleH+4eyLdQ9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(22074186197030)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DBXPR07MB320;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DBXPR07MB320; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DBXPR07MB320;4:6PUWEwwSii97+H/rut/2XOMRDiBqOqJ3fJSFrZBp1yb?= =?us-ascii?Q?DuE+PvBNSVglcEa5EyR725PVCoGoZ3qWDIarsKToJ7DwQ1GBKPlRUWWVmGja?= =?us-ascii?Q?azcZLoolnwYek+xN6cIWxuwrZDq4zfjTA9imNHIxDyYXmSaq8EYm7Hcx85kg?= =?us-ascii?Q?b111xFK0abul128H1sDxzLKmSnqpBIb4OKsrNAqph29czHHfEf0Lm3T4DB+w?= =?us-ascii?Q?KC3D7yCk3UrUGF+PZeSIkaABjnkhB4fOzZ2/GvvAEINFoCD7gpkPqBXfRfjp?= =?us-ascii?Q?9y3IfdpJdXjuj2qF/8u8468wankgyA4Byv7J1nm/ICS1BoOa7jcdf4R4ApGy?= =?us-ascii?Q?AbPLsJ/8Pxcvt6wtfw5VL4cfx12aIx6l5iGFLjGOnNa+e73EDEqnut4KyWmt?= =?us-ascii?Q?qNuraazl12brPy9Lfeu/6xcGcytgfDBioU8TitNYO45g0fyLt+SsBCrY3N01?= =?us-ascii?Q?RYwWVHn+a9DLhPg8wMRz0v42esBiGShAjdpRh+BbVSjnfWacuSxGEd3jV+d9?= =?us-ascii?Q?RRP0n4FvCJXp0v2YrJsxmsqje6VEuhfacdJPBXIRnUHKTOyjl44ZdpBY9Qcc?= =?us-ascii?Q?IwrMfaXCZimLzfY7GYssg8KuqcMNlo3XoR18tDWAwT/7QBiDI4sX5LLtY2Ji?= =?us-ascii?Q?nOJtMW6SP0dnzYWH4m1lA+sl1JobFo1OjLEO4wJatOU5LW0JTmOVIRk7HIOl?= =?us-ascii?Q?30E+4EPe4Yc76zrt7E8qK6HlYfT2NhexI9R4haW0EMT7+c1jv2eNdmYQlvjh?= =?us-ascii?Q?nlxNejVoDXcozKWOw3UWkH2KrW4IvPCCc7m583tK5CZOWpEFyEq3SH8Z62ko?= =?us-ascii?Q?5JokBoHRTHRc4Y4ih40PzmHqZSC8meLL2xImvVompprenbi6hEKZJxG/q9Vi?= =?us-ascii?Q?Z8PZwvkIRpeVP+xKkQVC68bLALgg42WW6xAQ9CN9o7kn9aov6DJepbwN4PpJ?= =?us-ascii?Q?OXKg5oVUzgMDYND1P8QPYWEgjKTeWCwwRRkb1e0hsi/C7O61I9Zweff1GQdN?= =?us-ascii?Q?WGJZpM80oVT+0qvIthNFlF/ks1tkN29AULPp4KBLaMR466VCvea1jHRsCXCo?= =?us-ascii?Q?GoOb03RxSrOzmQtObm9Wh0LN8RMTcNIJujfYCdr1AE1ScE3/XUF4gwopAKq/?= =?us-ascii?Q?2c18q6Y72D/TUvLW0eoB4bnvkP1sred5p4os2nYppHLco+DAPRyK1ZRTDnyo?= =?us-ascii?Q?75d+F/eTYakB/mkx+XEoq5m6i0lh0aj31ngLQWUQ5qFN7/M/PDyWPsw=3D?= =?us-ascii?Q?=3D?= X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39860400002)(39450400003)(39410400002)(39400400002)(39850400002)(305945005)(86362001)(5660300001)(6666003)(25786009)(3846002)(6506006)(478600001)(6916009)(2950100002)(966005)(36756003)(8676002)(81166006)(189998001)(42186005)(6486002)(38730400002)(110136004)(107886003)(50986999)(48376002)(76176999)(66066001)(2351001)(2906002)(7736002)(47776003)(50466002)(4326008)(6512007)(5003940100001)(2361001)(6306002)(33646002)(50226002)(6116002)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB320;H:elxacz23q12.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DBXPR07MB320;23:fYoUs/OMsw4fDY5kipqNZVQ6GbiP7cDW1nMrJuzXv+?= =?us-ascii?Q?CtiNFB0dXb5DvHoMrEJbpl27OVHKXF8XFewaEYVmZcgwRG4jxCWIS7WRdfWF?= =?us-ascii?Q?GJ9Gj30X/vbqywfqzhd/DEE090ecjqkbAl91gmJP2diLkeTSNptpPpUH9g6u?= =?us-ascii?Q?u2X6k6c5j9PCiSTLqqRUaB1gwJLlKZUMdRyjgUUuhpC7axYN4b/YqrxcfTkd?= =?us-ascii?Q?w+oz6hvsiXKPq0ixYEBFiFJC5EP/8beChcaan5+Rtg013XWlImbLPqw+sPQ9?= =?us-ascii?Q?gC08XECkTr5010nzDCarZERlf4I60SjFZhr+H2Bga0W4VKK8apU61QGquas/?= =?us-ascii?Q?dx3ozJNOOn0De4qqXBJS20qVbqjnrv0Cej0xidTZyu/N5fVrNaAIswvWKn4T?= =?us-ascii?Q?5YbTEfMk6n9wHoOa09SIAvnWxBIE8tYXsoNxx5qG2dAVkbboi9Dt6F+2VUMN?= =?us-ascii?Q?1/6QMWA+Sq24i8qJN5O+o+bX728DhoamtcI6ERqSw09utcczUSOjdx4AKGwN?= =?us-ascii?Q?BiJKuzRmfrmMksAfQSdpb4GAAY7OWyziqUIZ6G7dKIYqtVufV8150Hq3+1WU?= =?us-ascii?Q?obLJaWijsW0Bzq9dd9i6kPfrM0KWh6Joe5DNTTIfK/At1i4xHBmMBHJqP+Y3?= =?us-ascii?Q?1s/Oa3ieNrFzGoTZxnASUUfaGxUfohsTJkyIajT+qcQpuPeaCpwH750CnKR4?= =?us-ascii?Q?gsZZF4XFB8HBTqtAE/4fri1oS+woYRKWQMr29u2BcTvasjfU0Jv0XFqSo87v?= =?us-ascii?Q?GwZX4x11atKF25Tnj/QmLn7/2IYnX6NEo0U0Zpyd7u5GI797QHKcV0p+PsoA?= =?us-ascii?Q?8Cc2avTKpl5LNEL7krWx4g3L8M4aCIymn9K/nVE7jeo6GyFnp4hT2oYA0uCo?= =?us-ascii?Q?5MMothyyApqJnM7ahUHExO1nzXZbOHD833p5/QHvzCSzsWRNXJn0jkd9UAxf?= =?us-ascii?Q?0FvK1AukRByNMr45koEIKTIJ/vacnl3OQl1C8omF3UTU2+vINJZN08LpQvsK?= =?us-ascii?Q?JoqNSKIbtWgjxFv5dQZGzqrbEbrOX5UNFE8Igan4jV1M+KyoNj4x69L+Xxuv?= =?us-ascii?Q?mV+tFOUct5YZIoOb49LixeRAgPrwhO9V6UcTHpTYIKp2SwS6eiCyOTB8wJuI?= =?us-ascii?Q?Spq3Z8VR8=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DBXPR07MB320;6:jCNHaZsWaVekCIajO5XTQ1trFOqfkDJdpJB+EdCTYDt?= =?us-ascii?Q?xBoUpkjEUEOWU3lBQJx0OMRzlgwCqa0CAQKFMMn52ef5jILqtGVba0wAv0dm?= =?us-ascii?Q?9ftYzmf97f73iltZ/NKiqP6GfRJVO+oeSTRzySml1in38vBJW5EAbBm4SCPl?= =?us-ascii?Q?imCnkWsBvR09kKFeXoOdOU520I3XDI1qb6wnk2Uk/NrXWas3e1EdAbc5RZFL?= =?us-ascii?Q?pG5zHtmje5lTYJ07C3GpGjkqSeeFQpo7nW3MUpAsx0CGxa+PjX0hREqaUoeU?= =?us-ascii?Q?ydQumPGJqLj7qim3aFryA3vQuj89gu8LWmtdC019wNA75Fr0YLQCjb0vuF4I?= =?us-ascii?Q?meZxuEBVlLJyqYhf3aoY8U/iwOOLOpV4hDnWWVCQS79CEnVMv3r7Xkb57eID?= =?us-ascii?Q?pZjDWXWDJVXFlc577ASBUHcHvyHoqjSfD8JSD6+ahvE8xK7QE9SOtseTqYbA?= =?us-ascii?Q?FHuE0n/ChbU4gqJp5VTonqqViNj7FvHcIubUBsXQjiF1/wuOK3iIhv3Fzfg1?= =?us-ascii?Q?igfk5Yz/1/IjBWztqXTqSKT5qDola6TvIWiSQjEA86La/3NWi6H1wnh8RI63?= =?us-ascii?Q?jje8xoXnxpiexZUVgh6PYdH18mqzIDPE1kyK/kADVEs5ASEmgVzcZTNSRwg1?= =?us-ascii?Q?uP5tIP/eAGxd2NJCbNiSv1xUkd+BlGLIO0JZpaG8GYJI/TjueGjyxTKLu8um?= =?us-ascii?Q?x4HQmvA8Cpt8R4VW9VQyKqzABQHTOvFZBM5Ki6AXeQIkUS3BJrKRBW9w6ZUA?= =?us-ascii?Q?xxlbrhXmj9EVd5DL+Jq2MtbojSyvpjjhVSU5zF9XG5KFu6BCft6O00staLlb?= =?us-ascii?Q?TvROy8/fxe/i/S6x7zaLrL/3dchnVQt9qrvhtHmmKskAFyqKf73pyP9YmZjS?= =?us-ascii?Q?JBbwmwKqb0/KdouTNAL46RkL2MXVRtKohPpRTeY4jJMWE8KcSP491IuMuA8Q?= =?us-ascii?Q?FsugfJX5+alHTzWA0E8vVb9Zy21kDxH9q8PXDQA5H86BaQdM/7rmb01bAipw?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;5:J/gGmF0KVM4uOBgjEVcSD53L8ANJ190Sr/+LhP0YKOmI7Bjyfh9vMTP1GBq70qg1OuLggH35xxtH696xzWS6oNQdUPX7qJhoHJz3revvBmufy5kebBAqDiqX7jkBj6/+S2EeLoj5oGDpJe42lkJlD56nyWoojtBEU3W6scRU1kuoWG7wojsW9WA0hRBmpSFruRM+1Xa1zvwJ0e53xAH9B/8Vxb/7aQLXuLds2GILPc6zYp2fM6CAvZoyli9rpD+GqgRLlcSLS0WYviBoW7gGjI2gF/msyXfjoumOpX7cGzdnuRxWgoNs20UYDwfVPMqRM9kYZdtQhZUFb5yNbMNDxhbw62E4YJ9mDGGizb5ABvx+O3F2fbr3FN6feEWrvqBrIebQHVOfLE97MUPOqiGL2v4F76GklJnwj58/MybJsqx0lzXDMVMNzSZGC2q5UJOe0MW/x7+Hno0JXgU6qGCR6HA0rLkzwS95UcUc+3TRGhCs0zpWLkG1wJwVTGoG6LmX;24:FFtyJcNKnuFABf0LrEITDV/Qv/JCHNaZu+lGNO6A9q/momYNvMIK0zmnuNA96ho9XUNAnp7HXSAUF5aYqlFfyH6EBE6TrIrbhd6gF4Rena8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB320;7:I3xZyj4XqWR/HFG2c/FR8HVlTCjmriY08AAU+noRZcNeOIVYxr+o4f4CNT+KEUCJkxrNKfBVaN4p1vZ3OXsyg21b7IfcoOxp3AJyrS3a+tTBhfqWXhQtlFscm4aW8HarAFJ06MR+Dx/sCDd1lbsVKZ4zxFfnnzwkm5YyhhsvWGAf5IxatCcIBTw5pIy6ya8+/yHnRwI84KCaiWOu+jdsdr2c6qb0xo8qqqYmUvB0yQtuVHlmpRQRCC7aevtyEvvQ5w1yS19WntS14I4wjeRDImty00AUuWUmiF3Ko85aMAVQuVhbpptPyfPTdUcieXWUS7mrgFd8gJbsnxA9eNP6/A8i7yUIfCaXS5ccquGnWSf/9y+OueiQkpCUWtXRkRQaKxCfzk02Is2BUHCfrt+QtGbQCgx02I2ZNwTSdTFvsLm9x8KAxdYknJounDEbkFY9JJUcN48ZFf/SDlkAglWCZXnWBnJFvcJvEnEthJbhjwLu393xf9fIyWLBucf4YtQZcn297nvgkSoajf6JPrXC2jGOaQOlfOQnIitV56iBalWDTyDixG08Wt5xr+rENGmjMqnFlWahD6KBzCOW5uUQ2YAAsofqMO6vkfDu0fU5eAJbfZl9wALCEPyKZZ9sWB2LE+SlYklQSP1rBXtq+t72R/8OzMhKvOw/IXghkwJY29EgBVU68Y68mGXYpFddLDb67PNvLe0fNJb8Xe65d1d/JdQf8nI9UpbuR8UoxNYSgKDLUvd0B/+yyqFqe+kQPQLL/Wrg86chMg820p21bQX/6vX2M39PVfqi/zuTtJSuUX8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2017 20:15:19.7786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB320 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00603.txt.bz2 clang shows this warning. /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: error: while loop has empty body [-Werror,-Wempty-body] while (*p++ != '\0' && p - strtab < strtab_size); ^ /home/emaisin/src/binutils-gdb/gdb/dtrace-probe.c:424:52: note: put the semicolon on a separate line to silence this warning Putting the semicolon on its own line is not a big sacrifice to get rid of this warning. I think it's also useful to keep this, because it can catch errors like this: while (something); { ... } although gcc would warn about it in a different way (misleading indentation). This warning is already discussed here in the GCC bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62184 gdb/ChangeLog: * dtrace-probe.c (dtrace_process_dof_probe): Put semi-colon on its own line. --- gdb/dtrace-probe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c index 122f8de..9a02694 100644 --- a/gdb/dtrace-probe.c +++ b/gdb/dtrace-probe.c @@ -421,7 +421,8 @@ dtrace_process_dof_probe (struct objfile *objfile, arg.type_str = xstrdup (p); /* Use strtab_size as a sentinel. */ - while (*p++ != '\0' && p - strtab < strtab_size); + while (*p++ != '\0' && p - strtab < strtab_size) + ; /* Silence clang's -Wempty-body warning. */ /* Try to parse a type expression from the type string. If this does not work then we set the type to `long -- 2.7.4