From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] Poison non-POD memset & non-trivially-copyable memcpy/memmove
Date: Thu, 13 Apr 2017 02:27:00 -0000 [thread overview]
Message-ID: <1492050475-9238-1-git-send-email-palves@redhat.com> (raw)
Here's a version of the hack at
<https://sourceware.org/ml/gdb-patches/2017-04/msg00357.html> that I'm
not shy about proposing to master.
The original idea was to catch invalid initialization of non-POD types
with memset, at compile time. After posting the above, I thought it'd
be good to catch invalid uses of memcpy/memmove too, in a similar way.
Unlike the version linked above, this version does not use macros.
Instead it simply defines deleted memset/memcpy/memmove overloads.
Yay C++11!
Patch #1 adds the poisoning of invalid memset/memcpy/memmove.
Patches 2-4^W 2-5 [1] fix problems the poisoning detected, except the
"struct inferior", which is already fixed by this other series:
https://sourceware.org/ml/gdb-patches/2017-04/msg00298.html
[1] another instance just made it into the tree, so I do think it's a
good idea to add the poisoning to master.
Tested on x86-64 Fedora 23, along with the struct inferior fix.
Pedro Alves (5):
Poison non-POD memset & non-trivially-copyable memcpy/memmove
Don't memcpy non-trivially-copyable types: Make enum_flags triv.
copyable
Don't memset non-POD types: struct bp_location
Don't memset non-POD types: struct btrace_insn
Don't memset non-POD types: struct breakpoint
gdb/ada-lang.c | 19 +++----
gdb/breakpoint.c | 23 ++-------
gdb/breakpoint.h | 125 +++++++++++++++++++++++----------------------
gdb/btrace.c | 19 ++++---
gdb/common/common-defs.h | 1 +
gdb/common/enum-flags.h | 15 +++---
gdb/common/function-view.h | 40 ++-------------
gdb/common/poison.h | 83 ++++++++++++++++++++++++++++++
gdb/common/traits.h | 55 ++++++++++++++++++++
9 files changed, 234 insertions(+), 146 deletions(-)
create mode 100644 gdb/common/poison.h
--
2.5.5
next reply other threads:[~2017-04-13 2:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 2:27 Pedro Alves [this message]
2017-04-13 2:28 ` [PATCH 3/5] Don't memset non-POD types: struct bp_location Pedro Alves
2017-04-13 2:28 ` [PATCH 2/5] Don't memcpy non-trivially-copyable types: Make enum_flags triv. copyable Pedro Alves
2017-04-20 3:34 ` Simon Marchi
2017-04-25 1:10 ` Pedro Alves
2017-04-13 2:28 ` [PATCH 1/5] Poison non-POD memset & non-trivially-copyable memcpy/memmove Pedro Alves
2017-04-20 3:27 ` Simon Marchi
2017-04-25 1:14 ` Pedro Alves
2017-04-25 1:19 ` Pedro Alves
2017-04-25 8:24 ` Yao Qi
2017-04-25 9:24 ` Pedro Alves
2017-04-25 10:02 ` Pedro Alves
2017-04-24 1:12 ` Simon Marchi
2017-04-24 1:53 ` Simon Marchi
2017-04-27 13:58 ` Pedro Alves
2017-04-30 1:51 ` Simon Marchi
2017-05-17 11:35 ` Pedro Alves
2017-05-17 13:11 ` Simon Marchi
2017-05-17 13:20 ` Pedro Alves
2017-04-27 13:57 ` Pedro Alves
2017-04-13 2:28 ` [PATCH 4/5] Don't memset non-POD types: struct btrace_insn Pedro Alves
2017-04-13 7:57 ` Metzger, Markus T
2017-04-25 1:11 ` Pedro Alves
2017-04-13 2:35 ` [PATCH 5/5] Don't memset non-POD types: struct breakpoint Pedro Alves
2017-04-20 4:00 ` Simon Marchi
2017-04-25 1:11 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492050475-9238-1-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox