From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10090 invoked by alias); 16 Mar 2015 14:55:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10078 invoked by uid 89); 16 Mar 2015 14:55:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: bigwig.baldwin.cx Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Mon, 16 Mar 2015 14:55:57 +0000 Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id AF5FDB915; Mon, 16 Mar 2015 10:55:55 -0400 (EDT) From: John Baldwin To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fetch all registers before writing the core register notes. Date: Mon, 16 Mar 2015 14:55:00 -0000 Message-ID: <1491489.frCxvRgD87@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <5506C7F2.5040605@redhat.com> References: <2653052.Cuv9hkMi4i@ralph.baldwin.cx> <5506C7F2.5040605@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00456.txt.bz2 On Monday, March 16, 2015 12:09:22 PM Pedro Alves wrote: > On 03/14/2015 10:02 PM, John Baldwin wrote: > > Without this, not all registers were present in the core generated by gcore. > > For example, running 'gcore' on a program without examining the vector > > registers (SSE or AVX) would store all the vector registers as zeros because > > they were not pulled into the regcache. Running 'info vector' before 'gcore' > > would store the correct values in the core since it populated the regcache. > > For Linux processes, a similar operation is achieved somewhat by having the > > thread iterator callback invoke target_fetch_registers on each thread before > > its corresponding register notes are dumped. > > > > (I don't plan on including that level of detail in the commit log, just as > > a way to explain the bug this change fixes.) > > I think it's good to have the detail in the log. If you felt the need to > explain it for review, then a future archaeologist looking at git log/blame > would likely appreciate the same info. Fair enough, I will include it. > > gdb/ChangeLog: > > > > * fbsd-tdep.c (fbsd_make_corefile_notes): Fetch all target registers > > before writing core register notes. > > Looks fine to me. > > Thanks, > Pedro Alves > -- John Baldwin