From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25065 invoked by alias); 4 Oct 2017 16:31:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25052 invoked by uid 89); 4 Oct 2017 16:31:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Oct 2017 16:31:24 +0000 Received: from ESESSHC024.ericsson.se (Unknown_Domain [153.88.183.90]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 2A.01.05471.9DC05D95; Wed, 4 Oct 2017 18:31:21 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.90) with Microsoft SMTP Server (TLS) id 14.3.352.0; Wed, 4 Oct 2017 18:30:30 +0200 Received: from [100.94.42.24] (192.176.1.88) by AM3PR07MB307.eurprd07.prod.outlook.com (2a01:111:e400:881b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Wed, 4 Oct 2017 16:30:27 +0000 Subject: Re: [PATCH] Fix -list-thread-groups --available logic and add test To: Pedro Alves , CC: References: <7b48234b-1a7d-b4b4-2de0-2514d70cc59c@redhat.com> <1507132859-27807-1-git-send-email-simon.marchi@ericsson.com> <92fed2cd-29a3-f074-3419-c066f2134577@redhat.com> From: Simon Marchi Message-ID: <148cef57-4bee-ba90-5dad-897e983e01c8@ericsson.com> Date: Wed, 04 Oct 2017 16:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <92fed2cd-29a3-f074-3419-c066f2134577@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0101CA0064.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::32) To AM3PR07MB307.eurprd07.prod.outlook.com (2a01:111:e400:881b::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 98ed3ac1-448d-453c-a0bb-08d50b4539c9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:AM3PR07MB307; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB307;3:vupUt82+Z/LNU4XcjlFCi7qNVW9S+pQ41MwohIsKD34afdBAHnfnnADe/XsjadT5iN2Uz/ssnfT7CRJHi6kgzAzmfsTWhToLR9SRWAoF9ucZoH5yGwhw7b+OX8QJwuvQMD5i8Hg+nlo5eTThNghsx7TjON0atsa1A2/BQ9MQLi9uahrxvil/HJwzat+QGEZISn1DSBSnIT5kpAmgc/cmZqm5Ks+hxVRMIGTIncuHdUGkRp0Qf17tXFbe7bWic+TS;25:138SI6uYjZAWILeQHSf06dWnMnki3g5zXT0FmsTL2KUnkUzQJm6ulIUNSP+NjZTT2eA88d9vvqaeRnyv24z7sm52IclH7N8DeMT2O3o0+E6fxN+KM5gNJvcF7St8EOkR5MXKKXowCp6VVuQQ3i0MxUZXiIdnnqf0SUf0WWOiH7yu12UQCenuFU8Bsl18LhINbcDQmML8FhyYqv7/GQbNQU5fHYeTm3LS7oopc0AxB5q6md7/jlTKYe/5H/32KAgw3xUlGfDUWp8pSVE+hENFdOQ4OiSEsg6D7IWFXM5cMeA5rG8mE1pCFjMjr2WRVU7nb9s5AymNVMwFWLyBALizyg==;31:GJceDP6Ne6bnZnUFKeWEFRC3s7PgTpGtvjTSTqs8z5QbgZLyycZGp/UNw9QAOI9aBv8WMf34DNYFirY93iMY3QRU/89VSTADMq/+iFxtgnO1C2SjVECWNl/z0M5L5PQycwoZObVB+zUIAohlO4vBnmvtLZsuSbVSExyH/nYvJgNZxrs9gO0xZ9YsNcjdqUPcqAf0EyD4z5bvztWvRGyXOzZwKOLAaP/Shk8BjljV7vU= X-MS-TrafficTypeDiagnostic: AM3PR07MB307: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB307;20:d4ZslbrwFhIPWlrt4xJEKNLBSFfU/lmYIb+droZhDV94TwmWTaJ/SV0CXKaCLBBXYULpj8ORY03sja1Ddk6EvT8Mc7FZXS8wLb6WTJ+pnfhULUwGH1JoUIYfjVSzij++HSxGvtNlGuQZfxDFVn8V7NVZT4WdG6v5qdSbu8Oy0+in+8whnQ5cDo70b7V/Bw6Q9jOVxR4npa2IUj+bqr4rRsE1WXzgjbnp5qHgjAPa639/oBq6U4d7I8fzcMXNKfcxf5Wk2BJXzdCpyroo9ike6IAUrP8fjNaXXYMZ1Lr0hE8SVBWZ8tUG21XbggCFJL9WJ+e5ItTtAU8LKxGdsj35v6Uu1ukBLYDmCCPZToIodBiU8wp8IgV26skEy7QqQL4dcNDloE3+F104vE+AjTt2TZ72GRaw1bAFEl/05KXlh+Zk4j0TkVED9hfgjvpzJOjgAyler8IzKnw00naLNsGS8coVK6z1Kl1XfqgZoAj/UcZaugWCm0S4Dsl6VP5nJ3aU;4:W0BaMe1cgxuyI16GJOj4r/81ah29Uo2tdJOzSlvPKiTnMwvOUu0CUvCA+Cb44N8LTLoEtTJY7MyrW5gr5jwlIkkUspVbIZYYHXAMaO4Zx+OVBPeVAi0Ihpoht2H2Me/e/1BOsfh5yPhOnrW4fwUUWp/lx2v2cLtunaGNpNsZQrEMcHRwb/YlHvq4o3gxAraexck6FLBu1GPZLFV6tEuv2IV4nd4vV1PBZReih4lonWRu62Gk673yoK64iymYxc00twPCFWTC4wfA8q8vHLiI1sLBmMNaH4vPg3LHmUGBWS8= X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR07MB307;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR07MB307; X-Forefront-PRVS: 0450A714CB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(39860400002)(376002)(346002)(377424004)(199003)(24454002)(189002)(377454003)(6246003)(230783001)(68736007)(50986999)(97736004)(76176999)(54356999)(105586002)(33646002)(16576012)(58126008)(65956001)(53936002)(23746002)(189998001)(16526018)(316002)(50466002)(47776003)(230700001)(64126003)(4326008)(6116002)(65806001)(3846002)(66066001)(101416001)(2906002)(106356001)(8936002)(53546010)(83506001)(31686004)(49976008)(7736002)(305945005)(478600001)(6486002)(36756003)(81156014)(8676002)(86362001)(5660300001)(229853002)(65826007)(5890100001)(81166006)(6666003)(2950100002)(25786009)(31696002)(78286006)(131093003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR07MB307;H:[100.94.42.24];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM3PR07MB307;23:Y9Ybe2zbt+7/o5FqnMitKRQU3b6mD6V0WTHNiM?= =?Windows-1252?Q?IfRYg88Bh+bKFF9LnpiSYxlWARImZwi+2vImcLlaEN5yfrfKz59LIwyu?= =?Windows-1252?Q?vTla4sKufB6EemKp/O9k0Rz3F+4HOe8sl8d7ZBXO/ZAv7dpSphnDPGRv?= =?Windows-1252?Q?1pXMqBnSI1r+Iabb7XYXjOM3TkgUGLxp549Tl7ZwTO4BCkezhki7JV06?= =?Windows-1252?Q?59+SW8K97WnaqY4WNYJJWLTZQKJcgMGIT+JIJke8t3RzJ/nc+rBSygHN?= =?Windows-1252?Q?AJrQ2XBltsFJUKmP4KcwHzN5v/J8tFbvmQ1GnOwVWxtAtRt9Qo8OL7Ye?= =?Windows-1252?Q?8t24Is7vNBtHdj3Sqac5Gi5ipPZG0Obxm2DYY8l5Rn//Rq9V4FX24Dpj?= =?Windows-1252?Q?eYyfzvIa51PtgPpH+vE9apt6BfYs5UtNzYjp1vsMzadgsfb3TIjzhKQS?= =?Windows-1252?Q?b6K20osyvIdPH7ZDwuzOC7Lr/+ePGI2WEUQ2BgpQokGAnCUOJMDl4K4m?= =?Windows-1252?Q?eTlCL+JFkm9IYGnTnoVVpHt9HPsjdKG3cpzykT3IUnx60jASv1Ie2aXt?= =?Windows-1252?Q?lORjo4AJccHcA5MUnZt8te3h+WJOnrdq9/amKA63oaO+w4tOeQRMsTaV?= =?Windows-1252?Q?WAs8QGcbZkfMoizwZfwya2JE0IaEVUzl72fbAbLXNuvEER2SF4uoC22Y?= =?Windows-1252?Q?RorKENijtY6lSJJPMHUrANt2qikYA7MtzAnTdt58pLkdum6JvLHEN1rI?= =?Windows-1252?Q?Un0CAa71p2c1HVKWQLWKGKmANKUeLlgS1vR/DoZBSOKhP3HBugmKBazM?= =?Windows-1252?Q?SA00cM01evTIvajmn7nKsi+b/9k7g7OdMyESYAiSUtrEoXw7s/mtr9Mf?= =?Windows-1252?Q?/Jg+7wQ7XQMb7kiukDC+7GgCYXa/oVrjOybFVQVUbkAGdWuQdQ8GVVgc?= =?Windows-1252?Q?Ih8cACk5R9A+bXIMxY1t8EagzsKNbZmXIr6E2XlLwwPDpxtw3Onbn+Zf?= =?Windows-1252?Q?yyj9ZXWo0a7/7nyajlL+Y2JunVeLvNsCjE1UN1pybdeJaffHa2gMiSRo?= =?Windows-1252?Q?5zukFG5Yi1FCP3SHihM4JMFgcwljKxNpxnpINdjK/8b6dn7jsUarLO7y?= =?Windows-1252?Q?JT8nIctPV6WUSW+IbzzENbx+VBOzHBc060k5+I6xHp/htJMu4fHIxal1?= =?Windows-1252?Q?9jgQD0NzR/IdcyXSoX7+PKWKzUTdhxCCtIJdVhmn9rB+VcSkyLmisKHY?= =?Windows-1252?Q?n1OF1oGOGygANF+owEOGNXelpfX769BFcwAHIW2ReNOQKWQOZU4xfqiB?= =?Windows-1252?Q?IIVoZllpDIBOCwtuTsCCZ4r7CXLbz5cdlUJil2S5sB1OaNTTVPBrkgTX?= =?Windows-1252?Q?p6T1L6xZB0R40Mt+DBRQ1JgZgeB3STWDlcMLcXKtFNIhLOOJSbyGAe6K?= =?Windows-1252?Q?Df4z7f7s6cW8YRW/kyBrURxX/y5pK/Z3m0ikKvPoGSMmBXe/gV0CI4hV?= =?Windows-1252?Q?x45SGBMpOmin6akuWFqIyca/fSlPYg+hcg/bhpsuWICqspyLEYHJ9V01?= =?Windows-1252?Q?st/jp2K6gcmhIQjMxGNsfUGLOquueoPsn5?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB307;6:8tUdX4rAiJQliCK+iAQ4r+oZV37gtRPOFU+WbwkOrG6ckbjQIwA3O81+QpmP/IHZDvwTylD3HxqwGITURo3BtbqdU7Tne2ne49PcL2g9+fl7vs8T7NvMStsxFHp5tgFuAnRLCbJcxNvQM6/0MNvZUCeaeXt3a6MPJ4RZ6WiT9qA1fzGffEeJKAWsZC3IttjygX0hdRI0FTGKZsEe+CFXWNkWrzyzc/W8bKjduz8d5HuLR6IuRZgRn5Vdm3HMPnBFOf71iMoY5rUkT+yx8bdIzAqo8QCM2a3jue7Vs24XCwk0gQnCw5ez6LmHKyjW0jIj19+eYTjLVucOKyvE/tXHhg==;5:f4F5/ea3XQCZC9YcyjUyOgQFvOmp/uH2HYaueaWhmyCvHH5Yu7IX5it9hCNma50c4+NJh3YMkKv9x3QZzEz786kUqfxMzzaKd6Bf/owZtXReIkg6AG8THeS5WsNq7hej8zKGSGPWhUteyMUQE2ddVw==;24:Z5X8NLdy2OJ5s4Ozt8wtOiMMwLylGch8zJuqLdJNtD6p+d6hLFxKzKw2jd9QnoAE7iehw2lqrwuytnBoaOcG+dLT27JL9rT4hCULsZeEN/g=;7:1PefCoPClgCNZXTkRTJsoMSFHuSWnBzOhikykexFiYop5hsL/ugqCBakO/d7cVMf7F75FO4NwXIFbWDLeULHIDzfVVExu7J+fv+t3KjZrNocUbd/bRfUWO1XWfHH6RdAD9y1cUOUHIWybVVgBztilpqmlAfDfaWXFoG65WZuMfyDp5XEx3aYQpSlc3SDvAfGFWx2SYDS7EyKDRLRJPISJvHPnQDFEzXlaD3XW68kCc8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2017 16:30:27.9207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB307 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00087.txt.bz2 On 2017-10-04 12:13 PM, Pedro Alves wrote: > On 10/04/2017 05:00 PM, Simon Marchi wrote: >> New in v2: >> >> - Match more precisely process entry in output. Actually, match two, to >> test that giving more than one pid works. >> > > Great, thanks! > > I noticed something else. Don't we need to kill/reap > the spawned spawn_id's? > > There's kill_wait_spawned_process for that, but it operators > on build, not on target. I just assumed dejagnu/expect/tcl did that for us. I looked at the process list just after running the test and there are no leftover test processes. I'll add some calls to kill_wait_spawned_process anyhow. If I replace use_gdb_stub with can_spawn_for_attach, as you suggest, it should work since we know that build == target. > Maybe it'd be OK to limit the test to local testing, > and so you'd use can_spawn_for_attach instead of > use_gdb_stub. > > Hmm, actually, I do think that you should do that, given: > > proc can_spawn_for_attach { } { > # We use exp_pid to get the inferior's pid, assuming that gives > # back the pid of the program. On remote boards, that would give > # us instead the PID of e.g., the ssh client, etc. > if [is_remote target] then { > return 0 > } > > (the "we" above refers to spawn_id_get_pid.) Good point, thanks. Simon