Re: [PATCH v6 00/11] c++/14441: Rvalue reference support

Pedro Alves
2017-03-13T18:51:17Z

On 03/10/2017 08:04 PM, Keith Seitz wrote:
> This patch series was submitted in June, 2016, and the original author does
> not have the time to see this through. Given that we would like this in the
> 8.0 release, I have contacted the orginal author, who is allowing me to
> champion his patch on his behalf.
>
> When this series was last reviewed, revisions were requested in patches 8
> and 11. I have highlighted in those patches what I have changed over the last
> submitted patch version (v5).

Thanks so much for this Keith.

I'll point out a few nits to patch #11, but otherwise the
series is OK.

Before committing, please address a couple procedural issues.

> +2017-MM-DD Keith Seitz <keiths@redhat.com>
> +
> + PR gdb/14441
> + From Artemiy Volkov <artemiyv@acm.org>

As explained in:

https://www.gnu.org/prep/standards/standards.html#Style-of-Change-Logs

Since the patch is unchanged, this should be written as:

2017-MM-DD Artemiy Volkov <artemiyv@acm.org>

PR gdb/14441

Likewise in the other patches, of course.

Likewise, the git commit "Author" should be preserved when
it makes sense. For the patches that are largely unchanged
from Artemiy's original versions, we should make sure that
our git history preserves his authorship.

When changes were done to the patches to fix things, to
apply modernization, etc., add your name as another author
for the patch, like:

YYYY-MM-DD Hacker 1 <hacker2@foo.com>
Hacker 2 <hacker2@bar.com>

For example, in patch #8, the ChangeLog entry for
the manual should be "squashed", and then both names
should appear as above, instead of keeping the "who did what"
parts separated.

Thanks,
Pedro Alves