From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63965 invoked by alias); 20 Jan 2017 14:39:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63799 invoked by uid 89); 20 Jan 2017 14:38:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mga05.intel.com Received: from mga05.intel.com (HELO mga05.intel.com) (192.55.52.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Jan 2017 14:38:59 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 20 Jan 2017 06:38:58 -0800 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 20 Jan 2017 06:38:57 -0800 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id v0KEcuSi018316; Fri, 20 Jan 2017 14:38:56 GMT Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id v0KEcuEZ031692; Fri, 20 Jan 2017 15:38:56 +0100 Received: (from mmetzger@localhost) by ulvlx001.iul.intel.com with œ id v0KEct1o031679; Fri, 20 Jan 2017 15:38:56 +0100 From: Markus Metzger To: gdb-patches@sourceware.org Cc: palves@redhat.com Subject: [PATCH v2 1/2] thread: add can_access_registers_ptid Date: Fri, 20 Jan 2017 14:39:00 -0000 Message-Id: <1484923135-31270-2-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1484923135-31270-1-git-send-email-markus.t.metzger@intel.com> References: <1484923135-31270-1-git-send-email-markus.t.metzger@intel.com> X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00413.txt.bz2 Add a function can_access_registers_ptid that behaves like validate_registers_access but returns a boolean value instead of throwing an exception. 2017-01-20 Markus Metzger * gdbthread.h (can_access_registers_ptid): New. * thread.c (can_access_registers_ptid): New. --- gdb/gdbthread.h | 4 ++++ gdb/thread.c | 20 ++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h index 455cfd8..041b7c2 100644 --- a/gdb/gdbthread.h +++ b/gdb/gdbthread.h @@ -625,6 +625,10 @@ extern void thread_cancel_execution_command (struct thread_info *thr); executing). */ extern void validate_registers_access (void); +/* Check whether it makes sense to access a register of PTID at this point. + Returns non-zero if registers may be accessed; zero otherwise. */ +extern int can_access_registers_ptid (ptid_t ptid); + /* Returns whether to show which thread hit the breakpoint, received a signal, etc. and ended up causing a user-visible stop. This is true iff we ever detected multiple threads. */ diff --git a/gdb/thread.c b/gdb/thread.c index e45b257..d5dfe80 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -1141,6 +1141,26 @@ validate_registers_access (void) error (_("Selected thread is running.")); } +/* See gdbthread.h. */ + +int +can_access_registers_ptid (ptid_t ptid) +{ + /* No thread, no registers. */ + if (ptid_equal (ptid, null_ptid)) + return 0; + + /* Don't try to read from a dead thread. */ + if (is_exited (ptid)) + return 0; + + /* ... or from a spinning thread. FIXME: see validate_registers_access. */ + if (is_executing (ptid)) + return 0; + + return 1; +} + int pc_in_thread_step_range (CORE_ADDR pc, struct thread_info *thread) { -- 1.8.3.1