From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106844 invoked by alias); 16 Dec 2016 10:14:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106821 invoked by uid 89); 16 Dec 2016 10:14:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1305, 2016-12-16 X-HELO: mga14.intel.com Received: from mga14.intel.com (HELO mga14.intel.com) (192.55.52.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Dec 2016 10:13:56 +0000 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP; 16 Dec 2016 02:13:54 -0800 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by orsmga004.jf.intel.com with ESMTP; 16 Dec 2016 02:13:53 -0800 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id uBGADqtL000764; Fri, 16 Dec 2016 10:13:52 GMT Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id uBGADqkq017559; Fri, 16 Dec 2016 11:13:52 +0100 Received: (from heckel@localhost) by ulvlx001.iul.intel.com with œ id uBGADqJp017556; Fri, 16 Dec 2016 11:13:52 +0100 From: Bernhard Heckel To: gdb-patches@sourceware.org Cc: Bernhard Heckel Subject: [PATCH obv] Darwin: Fix gdb compilation. Date: Fri, 16 Dec 2016 10:14:00 -0000 Message-Id: <1481883230-17279-1-git-send-email-bernhard.heckel@intel.com> X-IsSubscribed: yes X-SW-Source: 2016-12/txt/msg00317.txt.bz2 Due to changes introduced by commit 4d01a485d29732b19743e8b138897f3509e071b0 ('struct expression *' -> gdb::unique_xmalloc_ptr) compilation is broken on Darwin. ../gdb/darwin-nat-info.c:733:8: error: assigning to 'struct expression *' from incompatible type 'expression_up' (aka 'std::__1::unique_ptr >') expr = parse_expression (exp); 2016-12-16 Bernhard Heckel gdb/Changelog: * darwin-nat-info.c (info_mach_region_command): Use expression_up. --- gdb/darwin-nat-info.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gdb/darwin-nat-info.c b/gdb/darwin-nat-info.c index 314d265..0262026 100644 --- a/gdb/darwin-nat-info.c +++ b/gdb/darwin-nat-info.c @@ -725,13 +725,12 @@ info_mach_regions_recurse_command (char *args, int from_tty) static void info_mach_region_command (char *exp, int from_tty) { - struct expression *expr; struct value *val; mach_vm_address_t address; struct inferior *inf; - expr = parse_expression (exp); - val = evaluate_expression (expr); + expression_up expr = parse_expression (exp); + val = evaluate_expression (expr.get ()); if (TYPE_CODE (value_type (val)) == TYPE_CODE_REF) { val = value_ind (val); -- 2.7.1.339.g0233b80