Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: KARTHIKVENKATESH BHAT <kv.bhat@samsung.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
	"palves@redhat.com" <palves@redhat.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary
Date: Wed, 28 Nov 2012 05:14:00 -0000	[thread overview]
Message-ID: <14812687.87071354079664627.JavaMail.weblogic@epml19> (raw)

Hi Tom/Mark,
Done. Took care of formatting comments. Any other inputs?

Thanks

------- Original Message -------
Sender : Tom Tromey<tromey@redhat.com>
Date : Nov 28, 2012 00:58 (GMT+09:00)
Title : Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary

>>>>> "Karthik" == KARTHIKVENKATESH BHAT writes:

Karthik> Please find the Changes after comments -

There are some formatting issues in the patch.

Karthik> +      /* Clang always emits a line note before the prologue and another
Karthik> + one after.We trust clang to emit usable line notes  */

Two spaces after the ".".
A "." followed by 2 spaces at the end of the second sentence.

Karthik> +        return max(start_pc,post_prologue_pc);

Space before open paren and after the comma.

Tom

             reply	other threads:[~2012-11-28  5:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28  5:14 KARTHIKVENKATESH BHAT [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-12-04  6:09 KARTHIKVENKATESH BHAT
2012-11-27 13:47 KARTHIKVENKATESH BHAT
2012-11-21 15:39 KARTHIKVENKATESH BHAT
2012-11-20  4:58 KARTHIKVENKATESH BHAT
2012-11-19 15:19 KARTHIKVENKATESH BHAT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14812687.87071354079664627.JavaMail.weblogic@epml19 \
    --to=kv.bhat@samsung.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox