From: Luis Machado <lgustavo@codesourcery.com>
To: <gdb-patches@sourceware.org>, <palves@redhat.com>
Subject: [PATCH] [v2] Remove unneeded pattern matching in gdb.base/maint.exp
Date: Fri, 02 Dec 2016 19:02:00 -0000 [thread overview]
Message-ID: <1480705356-15200-1-git-send-email-lgustavo@codesourcery.com> (raw)
In-Reply-To: <4906c887-a561-be85-d918-34050f240d6d@redhat.com>
Thanks for clarifying the gdb_prompt situation. Updated patch attached.
Btw, check-read1 did catch the problem with a couple failures. I didn't know
about that one.
--
This gets rid of more useless pattern matching cases in gdb.base/maint.exp.
gdb/testsuite/ChangeLog:
2016-12-02 Luis Machado <lgustavo@codesourcery.com>
* gdb.base/maint.exp: Use gdb_test instead of gdb_test_multiple when
possible.
Remove useless pattern-matching code.
---
gdb/testsuite/gdb.base/maint.exp | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/gdb/testsuite/gdb.base/maint.exp b/gdb/testsuite/gdb.base/maint.exp
index 17c606b..c66c9ed 100644
--- a/gdb/testsuite/gdb.base/maint.exp
+++ b/gdb/testsuite/gdb.base/maint.exp
@@ -290,25 +290,13 @@ gdb_test_multiple "maint print msymbols msymbols_output2 ${testfile}" "maint pri
-re "^maint print msymbols msymbols_output2 \[^\n\]*\r\n$gdb_prompt $" {
gdb_test_multiple "shell ls msymbols_output2" "maint print msymbols" {
-re "msymbols_output2\r\n$gdb_prompt $" {
- gdb_test_multiple "shell grep factorial msymbols_output2" "maint print msymbols" {
- -re "\\\[ *$decimal\\\] \[tT\]\[ \t\]+$hex \\.?factorial.*$gdb_prompt $" {
- pass "maint print msymbols"
- }
- -re ".*$gdb_prompt $" {
- fail "maint print msymbols"
- }
- }
- gdb_test "shell rm -f msymbols_output2" ".*" \
- "shell rm -f msymbols_output2"
- }
- -re ".*$gdb_prompt $" {
- fail "maint print msymbols"
+ gdb_test "shell grep factorial msymbols_output2" \
+ "\\\[ *$decimal\\\] \[tT\]\[ \t\]+$hex \\.?factorial.*" \
+ "maint print msymbols"
+ gdb_test "shell rm -f msymbols_output2" ".*"
}
}
}
- -re ".*$gdb_prompt $" {
- fail "maint print msymbols"
- }
}
gdb_test "cd ${mydir}" \
"Working directory [string_to_regexp ${mydir}]\..*" \
--
2.7.4
next prev parent reply other threads:[~2016-12-02 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 17:06 [PATCH] " Luis Machado
2016-12-02 17:30 ` Pedro Alves
2016-12-02 17:41 ` Luis Machado
2016-12-02 17:48 ` Pedro Alves
2016-12-02 19:02 ` Luis Machado [this message]
2016-12-02 19:10 ` [PATCH] [v2] " Pedro Alves
2016-12-02 19:37 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480705356-15200-1-git-send-email-lgustavo@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox