From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30207 invoked by alias); 25 Nov 2016 10:07:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30121 invoked by uid 89); 25 Nov 2016 10:07:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=abuse, misuse, H*RU:74.125.83.65, Hx-spam-relays-external:74.125.83.65 X-HELO: mail-pg0-f65.google.com Received: from mail-pg0-f65.google.com (HELO mail-pg0-f65.google.com) (74.125.83.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 10:06:53 +0000 Received: by mail-pg0-f65.google.com with SMTP id p66so5218348pga.2 for ; Fri, 25 Nov 2016 02:06:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=7+z8M7QeJJI2B8YSBWaSAtZIkgD1iSkAwn6IiT8coIs=; b=HTfJdoWd23rd2LSa5/xM5rLaRJ2b/rZAEQc+BUiMSj0I9YlZ18KN7y25hWFRXh+t4R nuweNAToIxsoN5GEEN1C2N8Dxzp3O0Kb+WRYpCYknVZKOsMiAuzM6CQZlInRlkVUerA9 vGCzlSWo/Vn3lp208xlwD8pyvHtk8yTe+hTI1QGiC0kDpUAgEooVSPFcn79XXn9sW5np Iw9JEYt89kJimD+GR/XgyyvoNwRsnBG21q3UHakLzeyVtNc19J4Rtmvw3hgCLPQzcWB2 GUZskuPWtkJ9KcOOc7RlpZuVstMucF66knIo+Gw1B9ZqVcmP4r50vUIvvor8Q8p1D0qZ D0wA== X-Gm-Message-State: AKaTC01LrIBtcXEUr2mOaiT+5yy0XgjqvRTJUpLrw4wFa3IxGbYBBLC0YLzmE+7/dPJXAw== X-Received: by 10.99.123.87 with SMTP id k23mr12821168pgn.101.1480068411528; Fri, 25 Nov 2016 02:06:51 -0800 (PST) Received: from E107787-LIN.cambridge.arm.com (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 13sm66563287pfz.30.2016.11.25.02.06.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 25 Nov 2016 02:06:51 -0800 (PST) From: Yao Qi X-Google-Original-From: Yao Qi To: gdb-patches@sourceware.org Subject: [PATCH 0/3] regnum and next_frame_id are only used for lval_register Date: Fri, 25 Nov 2016 10:07:00 -0000 Message-Id: <1480068407-22616-1-git-send-email-yao.qi@linaro.org> In-Reply-To: <20161123125000.DBC6D10FB47@oc8523832656.ibm.com> References: <20161123125000.DBC6D10FB47@oc8523832656.ibm.com> X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00793.txt.bz2 This patch series changes 'struct value' fields regnum and next_frame_id are only used for lval_register. This patch series is from the discussion https://sourceware.org/ml/gdb-patches/2016-11/msg00630.html Nowadays, computed value still uses next_frame_id, which is a misuse or abuse to me. Patch #1 adds a frame id in piece_closure, so computed value can get frame id there. Patch #2 moves fields regnum and next_frame_id to value.location. Then, value.location.address is only used by lval_memory, patch #3 restrict the checking on using address. Regression tested on x86_64-linux. *** BLURB HERE *** Yao Qi (3): Move computed value's frame id to piece_closure Adjust Value.location for lval_register Restrict checking value.lval on using address gdb/ada-lang.c | 2 +- gdb/dwarf2loc.c | 25 ++++++++++++------------- gdb/elfread.c | 2 ++ gdb/valops.c | 1 - gdb/value.c | 57 +++++++++++++++++++++------------------------------------ 5 files changed, 36 insertions(+), 51 deletions(-) -- 1.9.1